Refactor: Replace LibBoostAsioHandler deadline_timer with steady_timer (pt 2) #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces `boost::asio::deadline_timer` with `boost::asio::steady_timer`. The previous implementation relied on the system wall clock (`boost::posix_time`). This caused issues where heartbeat timers could hang or fire incorrectly if the system time was adjusted (e.g., via NTP or Daylight Savings). The new implementation uses `std::chrono::steady_clock` (monotonic), ensuring timers fire at consistent intervals regardless of system time changes.
Contributor
Author
|
PR #551 should be merged before this one. PR 551 may necessitate conflict resolution thereafter. |
zerodefect
changed the title
|
I probably didn't understand how you intend to proceed, if we both try to factorize #550 we will probably waste a lot of time. |
Contributor
Author
|
I feel your changes are too ambitious - too many changes at once. If one needs to do a git bisect, it becomes difficult to nail down a problem if too many things are globbed. |
zerodefect
changed the title
Contributor
Author
|
For those interested, I've created a new repository which encapsulates an improved/updated implementation of LibBoostAsioHandler (aka LibBoostAsioHandler2). https://github.com/coralbay-tv/amqp-cpp-boost2 PRs welcome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces
boost::asio::deadline_timerwithboost::asio::steady_timer.The previous implementation relied on the system wall clock (
boost::posix_time). This caused issues where heartbeat timers could hang or fire incorrectly if the system time was adjusted (e.g., via NTP or Daylight Savings).The new implementation uses
std::chrono::steady_clock(monotonic), ensuring timers fire at consistent intervals regardless of system time changes.