fix: provider spec conformance audit — 29 violations fixed, 50+ drift tests added#168
Merged
fix: provider spec conformance audit — 29 violations fixed, 50+ drift tests added#168
Conversation
… Ollama conversions
…on, search, rerank
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Systematic spec conformance audit of all 21 aimock providers via 60+ specialized agents (MSAL). Found and fixed 29 spec violations across 10 providers. Added 50+ new drift tests covering 9 previously untested providers plus error shapes and reasoning/thinking for 5 existing providers.
Phase 0: Drift test gap closure (18 agents)
Phase 1-3: Per-provider conformance audit (33 agents)
Every handler audited for: request conversion, non-streaming shape, streaming shape, tool calls, error format.
Phase 4: Fix round (7 agents)
Request conversion fixes:
max_output_tokensandresponse_formatsilently droppedmaxOutputTokens,topP,topKdropped; spuriousfunctionCall.idtemperature,max_tokenstool_callson assistant messages,images,systemon generateResponse shape fixes:
param: null, leaking internalstatusillicit/illicit/violentcategorieswords/segmentsquery,images,response_time,answer)documentfieldWebSocket fixes:
evt-→event_), missing session/response fields,previous_item_idtracking, output itemstatusconfigalias, standaloneturnComplete, completehttpToGrpcmapperAnthropic thinking:
signaturefield +signature_deltaevent added to Claude Messages and Bedrock invoke thinking blocksCR: 13-agent MSAL review
Found 4 additional bugs (previous_item_id tracking, incomplete gRPC mapper, test false positive, Anthropic signature). All fixed.
Closes audit plan: https://www.notion.so/35a3aa38185281cc8001c5e863a098dd
Test plan
pnpm test— 2873 passednpx tsc --noEmit— clean