fix(docker): run the default image as a non-root user#475
Open
NickAldewereld wants to merge 1 commit into
Open
fix(docker): run the default image as a non-root user#475NickAldewereld wants to merge 1 commit into
NickAldewereld wants to merge 1 commit into
Conversation
Run as the built-in unprivileged `node` user, add a HEALTHCHECK, exclude .git/.github from the build context, and add no-new-privileges / cap_drop / read_only to the reference compose file.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default
Dockerfileruns the container as root (onlyDockerfile.rootlessdrops privileges, and it isn't the image the referencedocker-compose.ymluses).nodeuser (chown/app+USER node).HEALTHCHECKhitting/api/ping..git/.githubfrom the build context in.dockerignore(the builder stage doesCOPY . .).no-new-privileges,cap_drop: [ALL]andread_only(with atmpfsfor/tmp) to the reference compose file, plus a commented-out example of setting a strongAUTHENTICATION_JWT_SECRET.No application behaviour changes.