refactor(notes): use non-monotonic ULIDs for note ids#478
Open
NickAldewereld wants to merge 1 commit into
Open
refactor(notes): use non-monotonic ULIDs for note ids#478NickAldewereld wants to merge 1 commit into
NickAldewereld wants to merge 1 commit into
Conversation
In monotonic mode, ids minted within the same millisecond are a deterministic +1 of the previous random suffix rather than fresh entropy. Sortability isn't needed for a capability id, so keep the full 80 bits of randomness per id.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generateId()usesulidFactory(), which defaults tomonotonic: true. In monotonic mode, ids minted within the same millisecond are a deterministic+1of the previous random suffix rather than fresh randomness.Note ids are used as capability identifiers, not for sorting, so there's no reason to trade away entropy. Passing
{ monotonic: false }keeps the full 80 bits of randomness per id. Small, self-contained change.