Fix fontPath URL in figlet defaults - #1774
Open
WalidDevIO wants to merge 1 commit into
Open
Conversation
|
Contributor
|
Hi @WalidDevIO if you are interested in an up to date version of it-tools, with many improvements, new tools, and bug fixes, as this repo is almost no more maintained, I made a fork here : https://github.com/sharevb/it-tools (https://sharevb-it-tools.vercel.app/ and docker images https://github.com/sharevb/it-tools/pkgs/container/it-tools) |
gcandau
pushed a commit
to gcandau/it-tools
that referenced
this pull request
Aug 15, 2026
Seven long-open upstream fixes, verified in a real browser. ASCII text drawer (CorentinTh#1774/CorentinTh#1690/CorentinTh#1685/CorentinTh#1651 - four PRs for one bug): fonts were fetched from a protocol-relative `//unpkg.com/figlet@1.6.0/fonts/` URL, pinned to a version the project no longer installs. That resolves to file:// when the build is opened from disk, is blocked by strict connect-src policies, and leaves the tool stuck on "Loading font..." with no error whenever the CDN is unreachable - which is exactly what it did here before this change. The fonts are now emitted into the bundle by a small Vite plugin and served from the deployment's own origin, so the tool works offline and has no third-party runtime dependency. They are still fetched individually on demand, so the initial payload is unchanged. text-to-binary (CorentinTh#1085): encoded with charCodeAt per character, so anything above U+00FF produced more than eight bits and broke the octet grouping, and split('') tore surrogate pairs apart. Now encodes UTF-8, so every group is exactly eight bits and any script round-trips. text-to-unicode (CorentinTh#1087): same surrogate-pair bug - an emoji became two meaningless entities. Now iterates by code point. bcrypt (CorentinTh#1152): hashSync and compareSync throw on an out-of-range salt count and on a malformed hash. Those throws escaped a computed during render and blanked the whole tool; both are now guarded. Hash text (CorentinTh#986): adds the explicit SHA3-224/256/384/512 output sizes, since crypto-js silently defaults SHA3 to 512 bits. UUID generator (CorentinTh#1441): adds v6 and v7, which required uuid 9 to 11. The node identifier option changed from number[] to Uint8Array in that major, and the validation pattern now accepts versions 1-7. Command palette (CorentinTh#1440): the per-category result cap of five was written for the original tool set; with well over a hundred tools a search for "json" or "ip" hid most of its own matches. Raised to twelve. The API's hash and UUID endpoints pick up the new algorithms and versions. Lint, 356 unit tests, both typechecks, the build and all 72 Playwright e2e tests pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019u4HjVENAajio7cxNSDzir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix this issue