Repository navigation
Conversation
Pages ended their <title> with the site name: "Errors | cv4pve-api-java". They now end with what the library is, "Errors | Proxmox VE API client for Java" (titleSuffix of the theme), and Getting started, Connection and Troubleshooting have a title of their own. docs/public/og.png is the image shown when a page is shared. Theme 2.8.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Titles
The <title> of a page ended with the site name, for example
Errors | cv4pve-api-java: nothing a search for Proxmox VE would match. With thetitleSuffixoption of theme 2.8.0 it ends with what the library is:Errors | Proxmox VE API client for Java.Getting started, Connection and Troubleshooting, the pages people land on from a search, have a title of their own in the frontmatter (
head); the title in the menu and at the top of the page stays short. A Connection page that already had a descriptive title is left as it is.Social card
docs/public/og.png(1200x630) is the image shown when a page of the documentation is shared. Theme 2.8.0 addsog:imageandtwitter:imageto every page when that file is there; until now the pages asked for a large card (twitter:card) and had no image to show.The image is written by a script of the theme from the texts of the home page (product name, hero title, description) and the product icon, so it can be rewritten when the home page changes:
cd docs node node_modules/@corsinvest/cv4pve-docs-theme/tools/og-image.mjsChecked
Site built with theme 2.8.0: one
<title>per page,og:imageandtwitter:imageon every page with the address of the published image,og.pngin the built site.