Пиратская Реформа #163
Пиратская Реформа #163
Conversation
WalkthroughThis pull request updates multiple YAML configuration files for game maps, prototypes, and vessels. The changes include renaming and updating entity identifiers (UIDs), modifying transform properties and tile data, and adding new prototypes and entities. Several files now feature updated method signatures and global variable names in the accompanying Python file. New vessel and game map configurations have been introduced along with updated URLs in documentation assets. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Calculator
Client->>+Calculator: coderabbit_add(x, y)
Calculator-->>-Client: returns result
Client->>+Calculator: coderabbit_formula(x, y, z)
Calculator-->>-Client: returns computed value
Note over Calculator: new_global_var is set to 1
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @Autsaider-IM, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request focuses on rebalancing and expanding the pirate ship options within the Corvax Frontier environment. It introduces a new pirate apothecary shuttle, 'Цинга' (Scurvy), and modifies the stats of existing pirate shuttles, adjusting their firepower, armor, and maneuverability. The pull request also removes the pirate hiring console from most pirate ships, adds atmospheric capabilities to the Schooner, and fixes structural issues in several ships. Additionally, it updates links for Corvax Frontier project-related books to point to the project's wiki and prevents DSBF mass scanners from being detached from shuttles.
Highlights
- Pirate Shuttle Rebalancing: The stats of existing pirate shuttles have been adjusted, focusing on balancing firepower, armor, and maneuverability to create more distinct roles for each ship.
- New Pirate Shuttle: Цинга (Scurvy): A new small pirate shuttle focused on apothecary capabilities has been added, offering a new gameplay option for pirate crews.
- Pirate Hiring Console Removal: The pirate hiring console has been removed from most pirate shuttles, limiting pirate recruitment to specific ships like the Queen Anne's Revenge, Boar, and Poli.
- Corvax Frontier Wiki Links: Links in the 'Анекдоты' (Anecdotes), KZ, and SRP books have been updated to point to the Corvax Frontier project's wiki.
- DSBF Mass Scanner Fix: Advanced mass scanners on DSBF shuttles can no longer be detached or disassembled, preventing exploits or unintended behavior.
- New Expedition Shuttle: TL Дредноут: A new medium-sized expedition cruiser has been added.
Changelog
Click here to see the changelog
- Resources/Maps/Corvax/Shuttles/BlackMarket/SalvationUnion.yml
- Replaced 'PlatingBurnt' with 'PlatingDamaged'.
- Modified tile data and positions of various entities to fix structural errors.
- Removed gas volume and temperature data.
- Replaced 'AirlockGlassShuttleNfsdLocked' with 'AirlockGlassShuttleSyndicate'.
- Adjusted positions and rotations of APCs and other components.
- Added new 'CannonBallGrapeshot' entities.
- Replaced 'CratePirateChest' with 'CratePirateChestCaptain'.
- Replaced 'PoweredlightBlueInterior' with 'PoweredlightBlue'.
- Added a 'Rack' entity.
- Removed a cannon trigger.
- Removed a thruster.
- Added a thruster rotation.
- Removed a drink.
- Resources/Maps/Corvax/Shuttles/BlackMarket/barnacle.yml
- Corrected a tile ID from 61059 to 61091.
- Added an 'AirlockHatch' entity.
- Added 'ButtonFrameCaution' and 'ButtonFrameCautionSecurity' entities.
- Added multiple transform components for various entities.
- Added 'ComputerFrame' entity.
- Replaced 'ComputerTabletopStationRecords' with 'CurtainsBlackOpen'.
- Removed 'Gyroscope' entity.
- Added 'ShuttersWindowOpen' entities.
- Added a transform component to the cannon.
- Added a 'SignalButtonWindows' entity.
- Added a 'SmallGyroscope' entity.
- Reorganized wall entities, splitting them into 'WallMining' and 'WallWood'.
- Replaced 'WarpPointShip' with 'WarpPoint'.
- Removed a WoodDoor entity.
- Resources/Maps/Corvax/Shuttles/BlackMarket/bocakillo.yml
- Added 'FloorMetalDiamond' tile.
- Modified tile data for chunk -1,-1 and 0,-1.
- Adjusted 'secondsUntilStateChange' for a door.
- Modified airlock entities.
- Replaced 'AtmosDeviceFanTiny' with 'AtmosDeviceFanDirectional'.
- Removed some components.
- Added 'CannonBall' and 'CannonBallGrapeshot' entities.
- Added multiple 'Catwalk' entities.
- Added 'CurtainsBlackOpen' entities.
- Added 'LuxuryPen' and 'Paper' entities.
- Modified 'PirateFlag' position.
- Added a 'Rack' entity.
- Added a 'RemoteSignaller' entity.
- Replaced 'ComputerTabletopStationRecords' with 'CurtainsBlackOpen'.
- Replaced 'PoweredlightColoredBlack' with 'PoweredlightBlack'.
- Reorganized wall entities, splitting them into 'WallMining' and 'WallWood'.
- Replaced 'WarpPointShip' with 'WarpPoint'.
- Resources/Maps/Corvax/Shuttles/BlackMarket/menace.yml
- Added 'FloorHullReinforced' and 'FloorMetalDiamond' tiles.
- Modified tile data for chunks 0,0, -1,0, 0,-1 and -1,-1.
- Added gas volume and temperature data.
- Added 'AirlockGlassShuttleSyndicate' and 'AirlockHatch' entities.
- Added 'ButtonFrameCaution' entity.
- Replaced 'ComputerTabletopStationRecords' with 'CurtainsBlackOpen'.
- Added 'ButtonFrameCaution' entity.
- Added 'MachineFrameDestroyed' and 'MiningWindow' entities.
- Reorganized wall entities, splitting them into 'WallMining' and 'WallWood'.
- Replaced 'WarpPointShip' with 'WarpPoint'.
- Resources/Maps/Corvax/Shuttles/BlackMarket/schooner.yml
- Modified tile data for chunks 0,0, -1,0, 0,-1 and -1,-1.
- Added 'AirAlarm' entity.
- Added 'BlastDoor' and 'BlastDoorOpen' entities.
- Added 'CurtainsBlackOpen' entities.
- Added 'LuxuryPen' and 'Paper' entities.
- Replaced 'ComputerTabletopStationRecords' with 'CurtainsBlackOpen'.
- Added 'LuxuryPen' and 'Paper' entities.
- Replaced 'PoweredlightColoredBlack' with 'PoweredlightBlack'.
- Replaced 'WarpPointShip' with 'WarpPoint'.
- Resources/Maps/Corvax/Shuttles/Nfsd/Orion.yml
- Added missing components Anchorable and Construction to ComputerTabletopCrewMonitoring.
- Resources/Maps/Corvax/Shuttles/Nfsd/Ravager.yml
- Added missing components Anchorable and Construction to ComputerTabletopComms.
- Resources/Maps/Corvax/Shuttles/Nfsd/broadhead.yml
- Added missing components Anchorable and Construction to ComputerTabletopCriminalRecords.
- Resources/Prototypes/Nyanotrasen/Entities/Objects/Books/hyperlinks.yml
- Updated links for KZ and SRP books to point to the Corvax Frontier wiki.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A pirate's life, a coding spree,
With shuttles balanced carefully.
From scurvy's hold to cannons' might,
May this code sail through the night.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🔭 Outside diff range comments (6)
Resources/Maps/Corvax/Shuttles/Nfsd/Ravager.yml (1)
4906-4915:⚠️ Potential issueAdd missing components to the ComputerTabletopAdvancedRadar entity.
The newly added
ComputerTabletopAdvancedRadarentity is missing two required components:AnchorableandConstruction. Without these components, the radar console might have incorrect behavior - it may not be properly secured to surfaces and might not be constructable/deconstructable as expected.Apply this fix:
- proto: ComputerTabletopAdvancedRadar entities: - uid: 1471 components: - type: Transform pos: 1.5,22.5 parent: 3 missingComponents: - Anchorable - Construction + proto: ComputerTabletopAdvancedRadar entities: - uid: 1471 components: - type: Transform pos: 1.5,22.5 parent: 3 - type: Anchorable - type: ConstructionResources/Maps/Corvax/Shuttles/Nfsd/Orion.yml (1)
3797-3809:⚠️ Potential issue❓ Verification inconclusive
Verify ComputerTabletopAdvancedRadar missing components.
Similar to the ComputerTabletopCrewMonitoring entity, this radar computer is also missing the
AnchorableandConstructioncomponents.This seems to be a pattern with computer entities in this file. Let's check if other computer entities in the map have the same issue:
🏁 Script executed:
#!/bin/bash # Search for other computer entities in the file that might have the same issue rg -A 10 "proto: Computer" Resources/Maps/Corvax/Shuttles/Nfsd/Orion.ymlLength of output: 1359
Attention: Inconsistent Computer Entity Configurations
Our search confirms that in
Resources/Maps/Corvax/Shuttles/Nfsd/Orion.ymltheComputerTabletopAdvancedRadarentity (lines 3797–3809) explicitly lists amissingComponentsfield withAnchorableandConstruction. However, although the original comment notes a similarity with theComputerTabletopCrewMonitoringentity, that entity does not show an explicitmissingComponentsproperty. Please verify whether both entities should follow the same pattern—either both missing these components or both fully specified—to ensure design consistency across computer entities.
- Confirm that
ComputerTabletopAdvancedRadaris meant to be incomplete (or if components should be added).- Double-check if
ComputerTabletopCrewMonitoringintentionally omits themissingComponentsfield or if it should also listAnchorableandConstruction.Resources/Maps/Corvax/Shuttles/Nfsd/marauder.yml (4)
2759-2805:⚠️ Potential issueDeviceLinkSink component removed from BlastDoor entities.
The
DeviceLinkSinkcomponent has been removed from BlastDoor entities. This will impact how these doors interact with control systems like buttons and timers.Without the
DeviceLinkSinkcomponent, these blast doors won't respond to signals from control interfaces that useDeviceLinkSource(like the buttons at lines 7853-7877 and 7934-7945). This effectively breaks the door control system.Ensure this was an intentional change and add back the component if doors need to be controllable via signals.
2828-2845:⚠️ Potential issueDeviceLinkSink component removed from BlastDoorOpen entities.
Similar to the regular BlastDoors, the opened variant (BlastDoorOpen) has also had its
DeviceLinkSinkcomponent removed, which will affect control system functionality.Without the
DeviceLinkSinkcomponent, these opened blast doors won't respond to signals from buttons and other control devices. This means they cannot be closed via standard controls, which may strand areas in a permanently open state.This appears to be a consistent removal alongside the other BlastDoor entities, but should be verified as intentional.
8759-8830:⚠️ Potential issueDeviceLinkSink component removed from ShuttersNormal entities.
The
DeviceLinkSinkcomponent has been removed from ShuttersNormal entities. This impacts control system functionality for shuttle shutters.Shutters will no longer be controllable via signal buttons since they won't respond to the signals from
DeviceLinkSourcecomponents. This removal seems consistent with the changes to BlastDoor entities, suggesting an intentional change to the control system.Verify this was intentional and consider the gameplay implications of having shutters that cannot be controlled by buttons.
9392-9555:⚠️ Potential issueThruster components removed from ThrusterNfsd entities.
The
Thrustercomponent appears to have been removed from all ThrusterNfsd entities. This will significantly impact shuttle mobility.Without the
Thrustercomponent, the shuttle will lose propulsion capability, affecting navigation and maneuverability. This change aligns with the PR summary mentioning "Reduced armor and firepower, emphasizing speed" for some shuttles, but may have unintended consequences for this particular shuttle's operational capabilities.Verify this change is intentional for the Marauder shuttle and ensure the resulting mobility aligns with the design goals.
🧹 Nitpick comments (17)
Resources/Maps/Corvax/Shuttles/Nfsd/Orion.yml (2)
4010-4018: ComputerTabletopStationRecords is properly defined.This computer entity appears to be correctly set up with a transform component. However, it's worth checking if this entity also needs the
AnchorableandConstructioncomponents like the other computer entities.Consider adding Anchorable and Construction components if needed:
- uid: 412 components: - type: Transform rot: -1.5707963267948966 rad pos: 0.5,46.5 parent: 2 + - type: Anchorable + - type: Construction
3734-3795: Consider additional air alarm coverage.While the ship has several air alarms installed, there might be some areas that could benefit from additional monitoring. This would improve safety during pressure or contamination emergencies.
Consider adding additional air alarms in the engineering section and any other critical areas that might currently have limited coverage.
Resources/Maps/Corvax/Shuttles/Nfsd/empress.yml (3)
6145-6153: Review Removal of 'proto: ComputerFrame' and Addition of 'missingComponents'The diff replaces the
proto: ComputerFrameproperty with a new list undermissingComponentsthat includesConstructionandAnchorable. Please verify that this change is intentional and that any game logic that depended on theComputerFrameprototype is now adapted to work with the new configuration. Consider adding in-file documentation to explain the rationale behind this change for future maintainability.
12597-12603: Verify Removal of 'proto: PoweredlightCyan'The removal of the
proto: PoweredlightCyanline indicates a change in how this entity’s prototype is assigned. Ensure this is aligned with the naming and structural updates described in the PR objectives. Double-check that any game systems referencing this prototype will correctly use the updated entity configuration.
16861-16867: Check Removal of 'proto: WarpPoint'The diff removes the
proto: WarpPointproperty from the entity. Confirm that this removal is by design and that any features or behaviors previously tied to the warp point functionality are either deprecated or have been migrated elsewhere. It is important to ensure consistency with the overall game updates.Resources/Maps/Corvax/Shuttles/Nfsd/prowler.yml (3)
3244-3255: Addition of New Prototype: StructureGunRackNfsd
A new prototype for a gun rack (StructureGunRackNfsd) has been added with specific transform position values. Confirm that the spatial positioning aligns with the overall shuttle layout and that any additional properties (such as interaction or durability parameters, if applicable) are defined elsewhere.
4345-4351: Review the Update/Removal of WardrobePrisonFilled
The block forWardrobePrisonFilled(starting at line 4345) has been changed. Confirm that this update (or removal) is intentional and that any systems or scripts referring to this prototype are handled elsewhere. It’s important to ensure that no residual dependencies remain which could lead to configuration inconsistencies.
4387-4388: Incomplete Change: WindoorSecureBrigLocked Configuration
The diff at line 4387 appears truncated (indicated by the tilde and ellipsis). Please verify that the modifications to theWindoorSecureBrigLockedprototype are complete and that any recent changes have been fully integrated. A follow‐up check is recommended to avoid any potential configuration errors.Resources/Maps/Corvax/Shuttles/BlackMarket/SalvationUnion.yml (2)
14-14: Renamed Tile Type: PlatingDamaged
At line 14 the tile “134: PlatingDamaged” has been introduced. This renaming suggests a semantic shift (from “PlatingBurnt” or a similar term). Please verify that all references in maps and documentation are updated accordingly.
1050-1056: Entity Renaming: CratePirateChestCaptain
At lines 1050–1056, the proto formerly known as “ComputerTabletopStationRecords” has been replaced by “CurtainsBlackOpen” (with uid 29) and the “CratePirateChest” is now renamed to “CratePirateChestCaptain” with uid 35. Ensure all references—especially from linked prototypes or mission logic—are updated to use the new names.Resources/Maps/Corvax/Shuttles/BlackMarket/menace.yml (3)
1486-1503: ShuttleGunPirateCannon Prototype DefinitionThe “ShuttleGunPirateCannon” prototype now includes two entries (UIDs 61 and 222) with a consistent rotation of 3.1416 rad and positions of (–0.5, 4.5) and (2.5, 4.5), respectively. Note that both entities are flagged as “missingComponents: Anchorable.” Please review whether the omission of the Anchorable component is deliberate or if it should be added to ensure proper positioning.
1486-1503: ShuttleGunPirateCannon Prototype Definition(See earlier comment for this block.)
1486-1503: ShuttleGunPirateCannon Prototype Definition(Repeated block – see earlier comment.)
Resources/Maps/Corvax/Shuttles/BlackMarket/schooner.yml (4)
617-645: Extensive Prototype Removals (Part 1):
Multiple prototypes such as APCBasic and AtmosFixBlockerMarker have been removed. These removals appear to streamline the configurations in line with the removal of hiring consoles (with specified exceptions). Ensure that references in other configuration files have been updated so that no orphaned dependencies remain.
714-721: Extensive Prototype Removals (Part 2):
Additional prototypes—ranging from various furniture and device spawners (e.g. ButtonFrameCaution, CableApcExtension, etc.) to assorted utility objects—have been removed. Given the scope of these removals, please verify that all affected entities (such as hiring consoles and related UI elements) have their replacements in place and that overall game balance is maintained.
2346-2410: Device Network Configuration Adjustments for FirelockGlass:
Within the FirelockGlass (or its updated variant, such as CannonBallGrapeshot later on) prototype, changes to transform positions and attached device network configurations (including device lists referencing UIDs 642 and 643) were made. It is important to confirm that these links correctly match the underlying hardware/network wiring logic in the game design.
4320-4420: General Structural & Consistency Check:
This YAML file has undergone a comprehensive overhaul—including updates to tilemap data, additions of new prototype definitions, extensive removals, and numerous transform and device link adjustments. It is recommended to perform an end‐to‐end verification to ensure that all coordinate changes, parent–child relationships, and device network linkages are consistent with the overall game design and balance objectives described in the PR.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (16)
Resources/Maps/Corvax/Shuttles/BlackMarket/SalvationUnion.yml(12 hunks)Resources/Maps/Corvax/Shuttles/BlackMarket/barnacle.yml(11 hunks)Resources/Maps/Corvax/Shuttles/BlackMarket/bocakillo.yml(15 hunks)Resources/Maps/Corvax/Shuttles/BlackMarket/menace.yml(14 hunks)Resources/Maps/Corvax/Shuttles/BlackMarket/schooner.yml(17 hunks)Resources/Maps/Corvax/Shuttles/Nfsd/Orion.yml(1 hunks)Resources/Maps/Corvax/Shuttles/Nfsd/Ravager.yml(1 hunks)Resources/Maps/Corvax/Shuttles/Nfsd/broadhead.yml(4 hunks)Resources/Maps/Corvax/Shuttles/Nfsd/centurion.yml(1 hunks)Resources/Maps/Corvax/Shuttles/Nfsd/empress.yml(3 hunks)Resources/Maps/Corvax/Shuttles/Nfsd/marauder.yml(3 hunks)Resources/Maps/Corvax/Shuttles/Nfsd/prowler.yml(5 hunks)Resources/Maps/Corvax/Shuttles/Nfsd/wasp.yml(4 hunks)Resources/Prototypes/Corvax/Shipyard/BlackMarket/scurvy.yml(1 hunks)Resources/Prototypes/Corvax/Shipyard/Expedition/dreadnought.yml(1 hunks)Resources/Prototypes/Nyanotrasen/Entities/Objects/Books/hyperlinks.yml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: build (ubuntu-latest)
- GitHub Check: YAML Linter
- GitHub Check: Test Packaging
- GitHub Check: build (ubuntu-latest)
🔇 Additional comments (113)
Resources/Maps/Corvax/Shuttles/Nfsd/wasp.yml (8)
9273-9288: LGTM: Added PoweredlightBlack lighting entities.The addition of
PoweredlightBlackentities provides specialized lighting for the shuttle bridge area, which enhances the visual aesthetics and functional lighting of the command area.
9288-9328: LGTM: Added PoweredlightCyan lighting entities.The addition of
PoweredlightCyanentities provides colored lighting for the external areas of the shuttle. This is consistent with the PR's focus on improving the shuttle's visual appearance and design.
1-25: LGTM: Tilemap configuration unchanged.The tilemap configuration for the shuttle is maintained, providing the appropriate floor types for different areas of the shuttle. This ensures consistency in the shuttle's base structure.
25-153: LGTM: Core entity metadata and grid configuration remains intact.The core shuttle entity configuration, including the MetaData, Transform, MapGrid, and chunk definitions are unchanged, preserving the fundamental layout and identity of the "Wasp" shuttle.
604-811: LGTM: Atmospheric system configuration preserved.The GridAtmosphere configuration is maintained, ensuring proper atmospheric simulation within the shuttle. This is important for the shuttle's life support functionality.
815-816: LGTM: Shuttle identity maintained.The BecomesStation component with ID "Wasp" is preserved, which is essential for maintaining the shuttle's identity in the game world.
4257-4267:✅ Verification successful
Verify the missing components on the advanced radar computer.
The
ComputerAdvancedRadarentity has explicitly listedConstructionandAnchorableas missing components. According to the PR objectives, this appears to be intentional to prevent these advanced scanners from being disassembled or removed, but it's important to verify that this won't cause any unintended side effects during gameplay.
🏁 Script executed:
#!/bin/bash # Description: Check for other instances of ComputerAdvancedRadar in the codebase to confirm if missing components is consistent # Look for other ComputerAdvancedRadar definitions echo "Searching for other ComputerAdvancedRadar definitions..." rg -A 5 "proto: ComputerAdvancedRadar" --glob "*.yml" # Check if there are other entities with missing components echo "Checking for other entities with missingComponents..." rg "missingComponents:" --glob "*.yml" -A 3Length of output: 66115
Missing Components Configuration Confirmed for ComputerAdvancedRadar
After a review of similar definitions across the repository, the configuration in
Resources/Maps/Corvax/Shuttles/Nfsd/wasp.yml—where theConstructionandAnchorablecomponents are deliberately excluded from theComputerAdvancedRadarentity—is consistent with other instances. This intentional omission aligns with the PR objectives of preventing these advanced scanners from being disassembled or removed. Please ensure gameplay testing confirms that the absence of these components introduces no unintended side effects.
11853-11860:❓ Verification inconclusive
Verify the purpose and function of the WarpPoint entity.
A
WarpPointentity has been added at coordinates (0.5, 0.5), which appears to be near the center of the shuttle. It's important to understand the purpose of this entity and ensure it functions as intended with the shuttle's design.
🏁 Script executed:
#!/bin/bash # Description: Investigate what WarpPoint entities do and how they interact with shuttles # Check for WarpPoint definition echo "Searching for WarpPoint definition..." rg "proto: WarpPoint" --glob "*.yml" -B 5 -A 10 # Check for any code that references WarpPoint echo "Checking for code that references WarpPoint..." rg "WarpPoint" --glob "*.cs" -A 3Length of output: 68552
Action Required: Confirm the WarpPoint configuration in the shuttle map.
The configuration in
Resources/Maps/_NF/Shuttles/Nfsd/wasp.ymladds a WarpPoint with a Transform component at position (0.5,0.5) and parent identifier 1. Similar WarpPoint entries appear throughout the repository (e.g., intrain.yml,saltern.yml, and others), typically used as markers for teleport or docking purposes. However, while many of these definitions include additional contextual properties (like alocationfield), this instance does not.
- Confirm that a WarpPoint without a
locationfield is intentional for this shuttle.- Verify that the position (0.5,0.5) and its
parentlinkage align with the shuttle’s design and functional requirements.- If additional data (for example, a descriptive
location) should accompany the WarpPoint for consistency or functionality, please adjust accordingly.Resources/Maps/Corvax/Shuttles/Nfsd/Orion.yml (9)
3980-3987: New crew monitoring computer entity added in correct position.The addition of a
ComputerTabletopCrewMonitoringentity in the bridge/command area is appropriate. The entity is properly configured with a Transform component and positioned correctly in the ship layout.This computer will allow crew members to monitor vital signs and locations of the crew, which is an essential functionality for a ship of this class.
1-13: Map metadata and tilemap configuration looks correct.The file includes proper metadata with format version 6 and appropriate tilemap definitions for various floor and space tiles.
3964-3975: Complete set of computer entities for ship operations.The ship has a good complement of computer systems including IFF (Identification Friend or Foe), Power Monitoring, and Shuttle control. This provides comprehensive control capabilities for the crew.
736-738: Ship identifier is correctly set.The
BecomesStationcomponent correctly identifies this shuttle as "Orion", which matches the filename.
4-732: Map layout and atmosphere configuration is extensive and detailed.The map configuration includes a complex and detailed layout with appropriate tile mappings, chunk definitions, and atmosphere settings. The atmosphere values are set to breathable levels with appropriate oxygen and nitrogen concentrations.
1069-1086: Check if APC's power supply is sufficient.The ship has an extensive network of power cables and APCs. It's important to verify that power generation capacity (from the AME on this ship) is sufficient for all systems.
This appears to be a thorough power distribution system that should support the ship's operations, assuming the antimatter engine is properly configured.
6733-8104: Extensive piping system provides proper atmospheric control.The ship has a comprehensive gas pipe network connecting various atmospheric devices, which should provide adequate life support for the crew during operations. The system appears to be properly segmented and connected.
9013-9177: Thrusters are strategically placed for proper maneuvering.The ship has thrusters positioned in appropriate locations around the hull to provide full directional control. This configuration should allow for proper navigation in space.
4730-4968: Extensive ventilation system coverage.The ship's ventilation system appears thorough with appropriate scrubbers and vents placed throughout the vessel. This should maintain atmosphere quality during operation.
Resources/Prototypes/Corvax/Shipyard/BlackMarket/scurvy.yml (2)
11-20: Vessel Configuration Validation
The vessel block defines all the expected properties:id,parent,name,description,price,category,group, andshuttlePath. The use of a codename (id: scurvy) alongside the display name (name: Цинга) appears intentional, so please verify that this naming convention is consistent with the game’s logic.
21-37: Game Map and Station Setup Review
The game map section is well-structured with matchingid,mapName,mapPath, andminPlayerssettings. The station configuration understationscorrectly specifies the station prototype (StandardFrontierVessel) and includes two components (a name setup with aNanotrasenNameGeneratorand job availability forPirate). Verify that the providedmapNameTemplateandprefixCreatorvalues (i.e.,'Апотекарий {1}'and'14') align with the intended in-game behavior.Resources/Prototypes/Nyanotrasen/Entities/Objects/Books/hyperlinks.yml (2)
26-26: URL Update for HyperlinkBookSpaceLaw
The URL forHyperlinkBookSpaceLawis updated tohttps://station14.ru/wiki/КЗ_(Frontier), which reflects the domain change indicated in the PR objectives. Please ensure that the non-ASCII characters (e.g., "КЗ") are handled correctly by any systems consuming this URL.
43-43: URL Update for HyperlinkBookNfsdSop
The URL forHyperlinkBookNfsdSopis updated tohttps://station14.ru/wiki/СРП_ДСБФ_(Frontier), aligning with the new content source. It would be prudent to verify that the new URL—especially with its Cyrillic characters—is fully compliant with URL standards and accessible by the application.Resources/Maps/Corvax/Shuttles/Nfsd/marauder.yml (4)
11273-11282: WarpPoint entity for shuttle teleportation.The WarpPoint entity defines a teleportation point named "Marauder", allowing players to warp to this shuttle from other locations in the game.
This warp point implementation is standard and properly configured with a location name matching the shuttle's name.
523-526: Atmosphere grid settings maintained with standard configuration.The GridAtmosphere component maintains standard settings with appropriate chunkSize (4) and atmosphere mixes.
The atmospheric configuration appears correctly maintained, allowing appropriate air management and life support for the shuttle.
74-78: Physics configuration promotes maneuverability.The shuttle's physics settings (bodyStatus: InAir, angularDamping: 0.05, linearDamping: 0.05, fixedRotation: False, bodyType: Dynamic) appear to be configured for improved maneuverability.
These physics settings align with the PR summary mentioning emphasis on speed for certain shuttles, with low damping values allowing for more responsive movement.
7816-7823:✅ Verification successful
New PoweredLightPostSmall entity added without verification.
A new lighting entity has been added at coordinates (0.5,25.5), which appears to be outside the main shuttle area (based on the relative positioning of other entities).
Verify that this light is intentionally placed in this position, as it appears to be in a peripheral area of the map. Run the following to check the surroundings of this entity:
🏁 Script executed:
#!/bin/bash # Description: Check what other entities are near this light to verify its placement is appropriate # Check for entities within a 3x3 area around the light echo "Entities near PoweredLightPostSmall at (0.5,25.5):" rg -A 2 -B 2 "pos: 0\.5,25\.5" Resources/Maps/Corvax/Shuttles/Nfsd/marauder.yml # Check for any other entities at similar Y coordinates to understand the area echo "\nOther entities at similar Y coordinates (24-26):" rg "pos: .+,2[456]\.5" Resources/Maps/Corvax/Shuttles/Nfsd/marauder.ymlLength of output: 1025
Confirming Lighting Placement at (0.5,25.5)
The verification output shows several entities—including CableHV and PoweredlightRed—are positioned at or near (0.5,25.5), as well as other nearby coordinates within the same cluster. This suggests that the placement of the new PoweredLightPostSmall entity is in line with the surrounding entities in the shuttle area. Please verify with the design documentation if further adjustments are needed, but the evidence indicates that the current positioning is intentional.
Resources/Prototypes/Corvax/Shipyard/Expedition/dreadnought.yml (2)
1-13: Vessel Configuration: Ensure Consistency and Schema ValidationThe vessel configuration is clearly and concisely defined with key properties such as
id,parent,name, andprice. Please verify that:
- The
shuttlePathvalue (/Maps/Corvax/Shuttles/Expedition/dreadnought.yml) correctly references the intended file.- The numeric
priceand other properties follow the expected data types defined in your schema.- This new configuration is validated against your game’s YAML schema to prevent runtime misconfigurations.
14-32: Game Map Configuration: Verify Station Settings and Custom Tag HandlingThe game map configuration is well-organized and aligned with the vessel definition. A few points to consider:
- The
minPlayersis set to0, which may be intentional; please confirm that this meets the design requirements for automated map activation or testing.- The custom YAML tag usage (
!type:NanotrasenNameGenerator) under thenameGeneratorshould be tested to ensure that your YAML parser correctly instantiates the generator.- The
availableJobsfor roles (Contractor, Pilot, Mercenary) all set to[ 0, 0 ]should be reevaluated if these default values satisfy your balance and gameplay needs.Resources/Maps/Corvax/Shuttles/Nfsd/broadhead.yml (3)
2179-2181: Ensure Required Component Consistency for Advanced RadarThe addition of the
missingComponentsfield withAnchorableandConstructionfor theComputerTabletopAdvancedRadarprototype appears aligned with similar updates in related prototypes. Please verify that these component names and their casing exactly match those in other configuration files.
3685-3691: Reinstate LockerNfsdSilverDetectiveFilled Prototype CorrectlyThe prototype
LockerNfsdSilverDetectiveFilledis reinserted with its UID and minimalTransformcomponents. Ensure that the reintroduced entity’s configuration remains consistent with its previous definitions and that any game logic dependent on it is not disrupted.
4399-4405: Validate the New StructurePistolRackNfsd PrototypeThe new prototype
StructurePistolRackNfsdhas been added with a simpleTransformcomponent (positioned at7.5,-3.5with parent2). Please verify that this new structure integrates well with existing gameplay mechanics and that its placement and purpose align with design expectations.Resources/Maps/Corvax/Shuttles/Nfsd/prowler.yml (3)
1764-1767: Ensure Correct Declaration of Missing Components for ComputerAdvancedRadar
The addition of themissingComponentsfield (listingConstructionandAnchorable) for the ComputerAdvancedRadar entity appears to be intentional. Please verify that these are indeed the only components that should be flagged as missing and that this configuration is in line with the expected behavior from the physics/logic engine.
2880-2905: Prototype Renaming: Introduction of PoweredlightRed
A new prototype titledPoweredlightRedis being introduced (replacing the older naming convention such as “PoweredlightColoredRed”). Please ensure that all references (in code, assets, and documentation) have been updated accordingly. Also, double-check that the transform attributes (rotation, position, and parent reference) conform to design specifications for the light elements in the game.
3256-3262: Addition of New Prototype: StructurePistolRackNfsd
The new pistol rack prototype (StructurePistolRackNfsd) is introduced with its own transform configuration. Please verify that the coordinate settings correctly position the rack relative to the shuttle grid and that no dependent logic or asset references are left pointing to the old configuration.Resources/Maps/Corvax/Shuttles/BlackMarket/bocakillo.yml (3)
11-11: New Tile Mapping for FloorMetalDiamond
A new tile type mapping has been added at line 11 (“4: FloorMetalDiamond”). Please ensure that the new tile name follows your naming conventions and that downstream systems (rendering, collision, etc.) support it properly.
282-296: Updated AirlockShuttleSyndicate Transformations and UIDs
In the “AirlockShuttleSyndicate” proto block (lines 282–296), the three entities now use updated UIDs (247, 260, 261) and their transform positions have been adjusted (to –0.5,–3.5; 0.5,–3.5; and 1.5,–3.5). Please double‐check that these spatial adjustments and identifiers are consistent with the intended shuttle design.
268-279: Removal of Legacy Proto – AirlockHatch
The block for proto “AirlockHatch” (lines 268–279) appears to be removed. Confirm that this removal is intentional and that any functionality (or replacement) formerly provided by an airlock hatch is now handled elsewhere.Resources/Maps/Corvax/Shuttles/BlackMarket/SalvationUnion.yml (12)
335-343: Removal of AirCanister Proto
The proto “AirCanister” (starting around line 335) has been removed. Ensure that any functionality previously provided by this entity has been deliberately retired or replaced and that no residual references exist in the code or other configuration files.
358-365: AirlockGlassShuttleSyndicate – New Definition
A new definition for “AirlockGlassShuttleSyndicate” is introduced (lines 358–365) with uid set to 1 and a transform rotation of 1.5708 rad at position (8.5,12.5). Please confirm that this new actor replaces the old “AirlockGlassShuttleNfsdLocked” (if applicable) and that all dependencies have been updated.
388-395: APCBasic Position Update
The “APCBasic” proto now shows a transform with pos: (2.5,13.5) (lines 388–395). Verify that this new position meets the gameplay requirements and that downstream logic which may use its UID is in sync with this update.
402-424: AtmosDeviceFanDirectional Adjustments
In the block for “AtmosDeviceFanDirectional” (lines 402–424) the positions and rotations for five entities have been modified. Please check that these changes (including rotational values and diverse placements) are consistent with the new shuttle balance—especially since these affect environmental airflow and ambiance.
782-788: CableMV Transformation Change
Within the “CableMV” proto block, note the change for the entity with uid 28 (lines 782–788, marked with a “~”) that now uses a new transform definition. Make sure the updated coordinates (and similar changes to subsequent CableMV entities) correctly align with the shuttle’s new structure.
814-821: CannonBall Transform Updates
The “CannonBall” proto (lines 814–821) now specifies three entities with updated UIDs (284, 287, 289) and explicit transform properties (including a rotation of π rad for uid 284). Confirm that these numerical values are correct and that the altered positions are well integrated with the in-game physics.
832-844: CannonBallGrapeshot Adjustments
In the “CannonBallGrapeshot” block (lines 832–844), two entities have been added/modified with UIDs 301 and 302. New rotation (1.5708 rad) and precise position values are used. Please verify that these fine-tuned coordinates have been tested and that they work as expected with the gameplay mechanics.
1651-1658: Rack Proto Updated
The “Rack” proto (lines 1651–1658) now defines a single entity (uid 117) with updated transform values (rotation of π rad and pos: 0.5,8.5). Please double-check that the rack’s new placement fits correctly into the overall shuttle layout and that no visual overlaps occur.
1541-1552: RemoteSignaller Configuration Review
In the “RemoteSignaller” proto (lines 1541–1552), the transform position (for uid 235) and the nested device link configuration (with its linkedPorts list) have been updated. Confirm that the port mappings (e.g. for port 86 with toggle/trigger actions) remain correct after these changes.
1971-1980: Thruster Transformation Adjustments
Within the “Thruster” proto block, note the change for uid 277 (lines 1971–1980, marked with “~”) where the transformation now uses a rotation of π rad and a new position (2.5,5.5). Verify that this modification does not adversely affect the physics or visual layout of the thrusters.
1713-1731: WallPlastitaniumDiagonal Updates
The “WallPlastitaniumDiagonal” proto (lines 1713–1731) now includes several entities (uids 185, 202, 205, 237) with adjusted transforms. Please check that these updates are consistent with the intended aesthetic and structural designs for the shuttle’s exterior.
2304-2310: Overall Consistency and Integration Check
This file contains extensive changes across many proto definitions—including numerous updates to transform positions, rotations, and unique identifiers. We recommend a full in–game test along with a visual inspection to confirm that the new placements, renamed entities, and removed prototypes (e.g. AirCanister) integrate seamlessly with gameplay. Additionally, ensure that any inter–file dependencies (such as shared UIDs between “bocakillo.yml” and “SalvationUnion.yml”) remain consistent.Resources/Maps/Corvax/Shuttles/BlackMarket/barnacle.yml (4)
105-107: Tilemap GridAtmosphere Value UpdateThe tile value for the chunk at key “–1,0” has been updated from the previous value (61059) to 61091 as specified in the PR objectives. Please verify that this new value appears in related art assets and behaves as expected in game rendering.
206-212: New AirlockHatch Prototype AdditionA new prototype named “AirlockHatch” with UID 95 has been introduced, including a Transform component with position (-2.5, 1.5) and parent
201. Confirm that its placement matches the intended shuttle layout and that its naming is consistent with similar entities in other configurations.
358-365: Addition of ButtonFrameCaution PrototypeA new prototype “ButtonFrameCaution” with UID 261 is now present, using a –1.5708 rad rotation and position (1.5, 1.5). Please double‑check that its coordinates and orientation meet the design for caution‐styled button frames within the shuttle.
367-373: Addition of ButtonFrameCautionSecurity PrototypeThe configuration now adds a “ButtonFrameCautionSecurity” prototype with UID 238 and a Transform component at (0.5, 3.5). Ensure the absence of rotation here is intentional and that the entity is positioned correctly for its security function.
Resources/Maps/Corvax/Shuttles/BlackMarket/menace.yml (54)
4-7: Tilemap Entries UpdateTwo new tilemap entries have been added:
• Key 3 now maps to “FloorHullReinforced”
• Key 2 now maps to “FloorMetalDiamond”
Please confirm that these new IDs do not clash with existing values and that the visual style meets the updated design goals.
25-40: GridAtmosphere Tile Data UpdatesThe tile data for several chunks – namely for keys (0,0), (–1,0), (0,–1), and (–1,–1) – has been replaced with new encoded string values. Verify that these updated values correctly reflect the atmospheric and visual overhaul intended for the shuttle area.
222-236: Updated UniqueMixes for AtmosphereA new (or modified) uniqueMix entry is provided with a volume of 2500, temperature 293.15, and all moles set to 0. Please ensure that this change produces the desired atmospheric conditions and does not inadvertently “clear out” necessary gas concentrations.
242-254: AirlockExternalGlass AdjustmentsWithin the “AirlockExternalGlass” prototype, the Transform for UID 63 is now set to position (5.5, 2.5) under parent
1. Verify that this change harmonizes with the shuttle’s overall geometry and that any visual or functional dependencies are updated accordingly.
255-265: Addition of AirlockGlassShuttleSyndicate PrototypeA new prototype “AirlockGlassShuttleSyndicate” is added with two entities (UIDs 250 and 251) whose Transform components are now defined at (0.5, –3.5) and (6.5, –3.5), respectively (with parent
1). Please ensure these positions correctly integrate into the syndicate shuttle design and that references to this prototype are updated throughout the project.
266-292: Revised AirlockHatch Prototype in MenaceMultiple “AirlockHatch” entries have been defined with UIDs 10, 11, 13, and 19. They all use a rotation of 3.14159 rad but differ in position:
• UID 10: (5.5, –1.5)
• UID 11: (6.5, –1.5)
• UID 13: (–0.5, –1.5)
• UID 19: (0.5, –1.5)Confirm that these variants are intentional and that they provide proper access points as per the updated shuttle layout.
855-861: ComputerTabletopShuttleAntag Parent UpdateFor the “ComputerTabletopShuttleAntag” prototype (UID 83), the Transform component now uses parent
1. Please review that this fits the new entity hierarchy and that any dependencies on the previous parent are correctly refactored.
862-883: Updated CurtainsBlackOpen PrototypeThe “CurtainsBlackOpen” prototype shows updated Transform settings for entities with UIDs 252, 253, 254, and 255. Their positions (–0.5, –1.5), (0.5, –1.5), (5.5, –1.5), and (6.5, –1.5) respectively are now defined with parent
1. Confirm that these positioning changes align with the visual and functional updates you intend for shuttle interiors.
1504-1524: SignalButtonDirectional Prototype UpdatesWithin the “SignalButtonDirectional” prototype, five entities (UIDs 26, 37, 157, 240, and 241) have been defined with updated Transform attributes and corresponding DeviceLinkSource configurations. Verify that the linked ports (223, 123, 3, 61, and 222) correctly map to the intended in‑game signals and that their positions support the directional functionality.
1561-1587: Updated SignalButtonWindows PrototypeThe “SignalButtonWindows” prototype (UID 249) is now configured with a Transform at (4.5, 1.5) and a DeviceLinkSource linking to multiple ports (246, 245, 244, 243, 173, 247, 87, 134, 92). Please confirm that these port assignments match the updated control logic for window signals on the vessel.
1588-1594: SpawnPointPirate Prototype AdjustmentThe “SpawnPointPirate” prototype now uses UID 93 with a Transform set to (4.5, 0.5) under parent
1. Verify that the spawn point’s placement is correct for the gameplay scenario.
1595-1601: SpawnPointPirateCaptain Prototype UpdateThe captain’s spawn point (SpawnPointPirateCaptain) now appears with UID 126 at position (2.5, 0.5). Please ensure that this location meets the balance and gameplay design for captain spawns.
1602-1608: SpawnPointPirateFirstMate Prototype UpdateThe “SpawnPointPirateFirstMate” prototype now uses UID 181 and is positioned at (1.5, 0.5). Confirm that this revised placement is consistent with the overall spawn distribution strategy.
1609-1616: SubstationWallBasic Prototype UpdateThe “SubstationWallBasic” prototype now shows an updated Transform for UID 141 with rotation –1.5708 rad and position (7.5, 1.5). Verify that this alteration correctly positions the substation elements as designed.
1617-1623: SuitStorageWallmount Prototype UpdateThe "SuitStorageWallmount" entity now has its Transform (UID 221) set to (4.5, 2.5) under parent
1. Please confirm that this fits within the updated shuttle layout.
1624-1642: Table Prototype AdjustmentsMultiple instances of the “Table” prototype (UIDs 16, 34, 36, 53, 59, 95, 142, and 152) have updated Transform properties (various rotations and positions). It is recommended to verify that these placements are mutually consistent and harmonize with the overall interior design.
1671-1707: Thruster Prototype UpdateModifications in the “Thruster” prototype affect entities with UIDs 45, 122, 161, 162, 180, and 202. In particular, note the differences in rotation and position (for example, UID 162 now has 3.1416 rad with pos (–2.5, –3.5)). Please ensure that these changes yield the intended thruster orientation and performance in the game.
1708-1714: ToolboxMechanicalFilled Prototype AdjustmentFor the “ToolboxMechanicalFilled” prototype, UID 154’s Transform now positions it at approximately (2.486192, –0.33646524). Confirm that this slight adjustment is deliberate and that it does not disrupt nearby object alignment.
1715-1756: Comprehensive WallReinforced Prototype UpdatesA large number of “WallReinforced” entities (UIDs 6, 18, 41, 47, 62, 71, 72, 84, 88, 102, 107, 108, 109, 119, 121, 128, 130, 158, 164, 169, 207, and 212) have been updated with new Transform properties. Given the scope of these changes, please review that the new positions and rotations consistently yield the desired structural reinforcement without causing visual overlaps or gameplay issues.
1841-1847: WallReinforcedDiagonal Prototype UpdateFor “WallReinforcedDiagonal” (UID 206), the Transform is now set to (–2.5, –1.5). Verify that this diagonal placement meets the reinforcement design expectations.
1848-1853: WarpPoint Prototype AdjustmentThe “WarpPoint” prototype now uses UID 149 with a Transform at (3.5, 0.5) under parent
1. Please ensure that this update correctly positions the warp destination according to gameplay requirements.
1855-1866: WeaponCapacitorRecharger Prototype UpdateTwo entities (UIDs 105 and 238) within the “WeaponCapacitorRecharger” prototype now have Transform positions (2.5, 1.5) and (3.5, 1.5) respectively. Double‑check that these placements support the intended recharging mechanics without causing layout conflicts.
1410-1421: RemoteSignaller Prototype Coordinates UpdateThe “RemoteSignaller” prototype now defines entities with UIDs 73 and 90 having updated positions (approximately (0.179, 4.1961) and (3.1609, 4.2065), respectively). Please confirm that these precise placements correspond with the intended network signal routing.
1422-1448: ShuttersNormalOpen Prototype UpdateThe “ShuttersNormalOpen” prototype now lists several entities with revised Transform information. For example, UID 173 is at (–0.5, 2.5), UID 243 at (0.5, 2.5), UID 244 at (1.5, 2.5), UID 245 at (2.5, 2.5), UID 246 at (3.5, 2.5), and UID 247 at (–1.5, 2.5). Verify that these changes correctly produce the intended “open” visual state of the shutters while preserving proper parent-child relationships.
1504-1524: SignalButtonDirectional Prototype Updates(See earlier comment for this block.)
1561-1587: Updated SignalButtonWindows Prototype(See earlier comment for this block.)
1588-1594: SpawnPointPirate Prototype Adjustment(See earlier comment for this block.)
1595-1601: SpawnPointPirateCaptain Prototype Update(See earlier comment for this block.)
1602-1608: SpawnPointPirateFirstMate Prototype Update(See earlier comment for this block.)
1609-1616: SubstationWallBasic Prototype Update(See earlier comment for this block.)
1617-1623: SuitStorageWallmount Prototype Update(See earlier comment for this block.)
1624-1642: Table Prototype Adjustments(See earlier comment for this block.)
1671-1707: Thruster Prototype Update(See earlier comment for this block.)
1708-1714: ToolboxMechanicalFilled Prototype Adjustment(See earlier comment for this block.)
1715-1756: Comprehensive WallReinforced Prototype Updates(See earlier comment for this block.)
1841-1847: WallReinforcedDiagonal Prototype Update(See earlier comment for this block.)
1848-1853: WarpPoint Prototype Adjustment(See earlier comment for this block.)
1855-1866: WeaponCapacitorRecharger Prototype Update(See earlier comment for this block.)
1410-1421: RemoteSignaller Prototype Coordinates Update(See earlier comment for this block.)
1422-1448: ShuttersNormalOpen Prototype Update(See earlier comment for this block.)
1504-1524: SignalButtonDirectional Prototype Updates(Repeated block – see earlier comment.)
1561-1587: Updated SignalButtonWindows Prototype(Repeated block – see earlier comment.)
1588-1594: SpawnPointPirate Prototype Adjustment(Repeated block – see earlier comment.)
1595-1601: SpawnPointPirateCaptain Prototype Update(Repeated block – see earlier comment.)
1602-1608: SpawnPointPirateFirstMate Prototype Update(Repeated block – see earlier comment.)
1609-1616: SubstationWallBasic Prototype Update(Repeated block – see earlier comment.)
1617-1623: SuitStorageWallmount Prototype Update(Repeated block – see earlier comment.)
1624-1642: Table Prototype Adjustments(Repeated block – see earlier comment.)
1671-1707: Thruster Prototype Update(Repeated block – see earlier comment.)
1708-1714: ToolboxMechanicalFilled Prototype Adjustment(Repeated block – see earlier comment.)
1715-1756: Comprehensive WallReinforced Prototype Updates(Repeated block – see earlier comment.)
1841-1847: WallReinforcedDiagonal Prototype Update(Repeated block – see earlier comment.)
1848-1853: WarpPoint Prototype Adjustment(Repeated block – see earlier comment.)
1855-1866: WeaponCapacitorRecharger Prototype Update(Repeated block – see earlier comment.)
Resources/Maps/Corvax/Shuttles/BlackMarket/schooner.yml (7)
432-436: Tilemap Value Updates:
The tile values for coordinates (0,0), (-1,0), and (0,1) have been updated to 65358, 61006, and 59967 respectively. Please ensure that these new codes match the intended visual/design updates in the game.
544-556: New Prototype: AirAlarm Added:
A new prototype named AirAlarm has been introduced with UID 642. Its configuration now uses a transform with position1.5,-1.5and a device list that includes devices[239, 236, 240, 242]. Please confirm that the device IDs and the spatial placement align with the design requirements.
568-575: New Prototype: AirlockGlassShuttleSyndicate Added:
The configuration now includes the AirlockGlassShuttleSyndicate prototype with entities having UIDs 555 and 556. Their transform positions (-0.5,-9.5and1.5,-9.5) have been set to update shuttle structure. Verify that these coordinates are consistent with the overall layout changes for syndrome shuttles.
580-617: Updated Prototype: AirlockHatch Refinement:
The AirlockHatch prototype now includes multiple entity entries (with UIDs 438, 439, 454, 455, 458, 459, and 471) each with explicitly defined transform positions. These changes aim to fix structural issues. Please double-check that all positions and parent relationships are correct and that the new layout meets the design intent.
3564-3581: SignalButtonDirectional Update:
The SignalButtonDirectional prototype now defines its transform with a rotation and position, and it adds a device link source section with ports (e.g. 224, 206, 225, 228) to trigger toggles. Please verify that these port mappings conform to the control scheme and that the device interactions trigger as expected.
3582-3611: SignalButtonWindows Update:
The SignalButtonWindows prototype has been introduced (or updated) with new transform positions and a device link source configuration. The linked ports for entities (for example, in the blocks for UIDs 354, 474, 493, etc.) should be re‐checked to ensure they trigger the intended toggle actions.
3972-4008: WallMining Prototype Adjustments:
The WallMining prototype has several modified transform coordinates across a number of UIDs (e.g. 356, 358, 371, 372, 378, 379, etc.). Please verify that this spatial reconfiguration results in the intended layout and does not introduce unexpected geometry or collision issues in the map.
| missingComponents: | ||
| - Anchorable | ||
| - Construction | ||
| - proto: ComputerTabletopCrewMonitoring |
There was a problem hiding this comment.
Missing required components for ComputerTabletopCrewMonitoring.
The entity is defined without Anchorable and Construction components. These components are typically required for computer objects in the game environment to function properly, allowing them to be anchored to surfaces and constructed/deconstructed.
Add the missing components to the entity definition:
- uid: 413
components:
- type: Transform
rot: -1.5707963267948966 rad
pos: 0.5,47.5
parent: 2
+ - type: Anchorable
+ - type: ConstructionCommittable suggestion skipped: line range outside the PR's diff.
| - proto: ComputerTabletopAdvancedRadar | ||
| entities: | ||
| - uid: 886 | ||
| components: | ||
| - type: Transform | ||
| rot: 1.5707963267948966 rad | ||
| pos: -2.5,20.5 | ||
| parent: 1 | ||
| missingComponents: | ||
| - Anchorable | ||
| - Construction | ||
| - proto: ComputerTabletopCrewMonitoring |
There was a problem hiding this comment.
Missing required components for ComputerTabletopAdvancedRadar.
The newly added ComputerTabletopAdvancedRadar entity explicitly lists Anchorable and Construction as missing components. This will likely cause issues with the entity's functionality, as these components are required for proper placement and interaction.
These components should be added to ensure the entity functions correctly. Consider adding them to the entity definition or checking if there's an issue with the prototype inheritance.
| - proto: ComputerTabletopAdvancedRadar | ||
| entities: | ||
| - uid: 598 | ||
| components: | ||
| - type: Transform | ||
| pos: -2.5,11.5 | ||
| parent: 1 | ||
| missingComponents: | ||
| - Anchorable | ||
| - Construction | ||
| - proto: ComputerTabletopCrewMonitoring |
There was a problem hiding this comment.
Entity has missing required components.
The newly added ComputerTabletopAdvancedRadar entity is missing the Anchorable and Construction components, which are explicitly noted in the missingComponents field. Without these components, the radar may not function properly - it won't be able to be anchored to surfaces and might not be constructable/deconstructable by players.
Add the missing components to ensure proper functionality:
- proto: ComputerTabletopAdvancedRadar
+ proto: ComputerTabletopAdvancedRadar
entities:
- uid: 598
components:
- type: Transform
pos: -2.5,11.5
parent: 1
- missingComponents:
- - Anchorable
- - Construction
+ - type: Anchorable
+ - type: Construction📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - proto: ComputerTabletopAdvancedRadar | |
| entities: | |
| - uid: 598 | |
| components: | |
| - type: Transform | |
| pos: -2.5,11.5 | |
| parent: 1 | |
| missingComponents: | |
| - Anchorable | |
| - Construction | |
| - proto: ComputerTabletopCrewMonitoring | |
| - proto: ComputerTabletopAdvancedRadar | |
| entities: | |
| - uid: 598 | |
| components: | |
| - type: Transform | |
| pos: -2.5,11.5 | |
| parent: 1 | |
| - type: Anchorable | |
| - type: Construction | |
| - proto: ComputerTabletopCrewMonitoring |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
Resources/Maps/Corvax/Shuttles/BlackMarket/barnacle.yml (1)
1730-1759: Extensive WallWood Prototype Adjustments
TheWallWoodprototype has undergone multiple transform updates across several entities (including uids114,115,131,134,136,139,144, and others). The updates include adjustments to rotation (commonly set to1.5707963267948966 rad) and refined position values. Please ensure that these modifications are consistent with the design guidelines for static structures, and consider adding inline comments or documentation in the YAML for clarity if similar adjustments are repeated.Resources/Maps/Corvax/Shuttles/BlackMarket/bocakillo.yml (1)
1798-2051: WallPlastitaniumShuttle Comprehensive Transform Update.
The update to theWallPlastitaniumShuttleprototype spans numerous entities with extensive changes in rotation and position. Please conduct a thorough review to ensure that all wall segments align correctly within the shuttle’s structure and that the modifications do not introduce misalignments.Consider simplifying or modularizing repetitive transform definitions to ease future maintenance.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
Resources/Maps/Corvax/Shuttles/BlackMarket/Poli.yml(7 hunks)Resources/Maps/Corvax/Shuttles/BlackMarket/barnacle.yml(16 hunks)Resources/Maps/Corvax/Shuttles/BlackMarket/bocakillo.yml(16 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build (ubuntu-latest)
🔇 Additional comments (36)
Resources/Maps/Corvax/Shuttles/BlackMarket/barnacle.yml (13)
105-107: Tile Value Update at Coordinate (-1,0)
The tile value at coordinate-1,0has been updated from its old value to61091. Please confirm that this change is intentional and that downstream systems (such as tile rendering and collision logic) interpret the new value correctly.
206-213: Addition of AirlockHatch Prototype
A new prototypeAirlockHatchwith uid95has been introduced and configured with aTransform(position set to-2.5,1.5and parent201). Ensure that this new entity is correctly integrated with the rest of the map and that its coordinates align with gameplay requirements.
358-365: New ButtonFrameCaution Prototype Added
The new prototypeButtonFrameCautionwith uid261is added with a defined transform (rotation of-1.5707963267948966 radand position1.5,1.5). Verify that the rotation and position are consistent with visual expectations and that any in-game behavior tied to this prototype is updated accordingly.
366-373: New ButtonFrameCautionSecurity Prototype Added
The prototypeButtonFrameCautionSecuritywith uid238is now included with aTransformat position0.5,3.5. This seems to have been added to complement related button frame entities. Please verify that its placement and configuration fit within the overall design scheme.
724-732: Addition of ComputerFrame Prototype
A newComputerFrameprototype with uid76has been introduced. Its transform includes a rotation of-1.5707963267948966 radand position1.5,2.5. Double-check that this entity aligns with any UI or in-game computer interactions and that the rotation is intentional.
747-753: Replacement with CurtainsBlackOpen Prototype
The entity formerly identified asComputerTabletopStationRecordsappears to have been replaced by a new prototypeCurtainsBlackOpenwith uid257. The transform (position set to-2.5,1.5) should be verified to ensure it integrates correctly with related entities. Please also ensure that all references to the old prototype have been updated.
553-558: Additional Entry for CannonBallGlassshot
An extra entity for the prototypeCannonBallGlassshothas been added with uid273, including a rotation of1.5707963267948966 radand a transform position of1.6676726,-0.6762389. Verify that this addition is consistent with the design of similar projectile or special cannonball entities.
1536-1543: ShuttleGunPirateCannon Transform Adjustments
TheShuttleGunPirateCannonprototype now has updated transform values for both entities (uids23and229). The revised positions and rotations (each using1.5707963267948966 radwhere applicable) should be validated to ensure that the cannon placements and angles function as intended during gameplay.
1475-1478: Extended Linked Ports in RemoteSignaller
Within theRemoteSignallerprototype, additional device link configurations have been added (notably for port229with both "Pressed: Toggle" and "Pressed: Trigger" commands). Please confirm that these extra links integrate properly with the device logic and that no unintended port duplications occur.
1479-1529: Introduction of ShuttersWindowOpen Prototype
A new prototypeShuttersWindowOpenhas been added with multiple entity definitions (uids258,259,260,262,263,264,267,268,269, and270). Each entity is configured with its own transform. It’s important to review these coordinates to ensure that the shutter elements display and operate cohesively with nearby interactive objects.
1560-1588: Addition of SignalButtonWindows Prototype
The new prototypeSignalButtonWindows(uid253and associated entity266) includes aTransformand aDeviceLinkSourcewith multiple linked port commands. Verify that the port mappings are correctly set up and that the rotation (-1.5707963267948966 rad) on the second entity is as intended.
1593-1605: New SmallGyroscope Prototype
The prototypeSmallGyroscopeis now defined with two entities (uids3and225), each with a transform that includes a rotation of1.5707963267948966 radand specific positions. Please confirm that these gyroscopes will provide the intended functionality and that the rotational values are correctly interpreted by the simulator.
1706-1717: Thruster Prototype Transform Updates
Within theThrusterprototype, additional transform updates for entities with uids202and221have been added. The new rotations (e.g.,3.141592653589793 radand1.5707963267948966 rad) and positions (e.g.,-4.5,-5.5and-5.5,-4.5) should be double-checked to ensure they match the physical behavior and visual alignment expected for thrusters in-game.Resources/Maps/Corvax/Shuttles/BlackMarket/Poli.yml (4)
7512-7518: Added new ShuttleGunPirateCannonNoUse prototype aligns with PR objectives.The addition of this weapon prototype aligns with the PR objective of increasing the "Полюс" (Poli) shuttle's firepower. This is a good implementation of the requested feature.
6491-6495: Multiple thruster transformations added.These new transform entities appear to be part of enhancing the shuttle's configuration. The systematic placement suggests they're meant to improve the shuttle's maneuverability and appearance, which aligns with the PR objectives.
Also applies to: 8362-8378
644-644:✅ Verification successful
Note the negative door state timing values.
Both instances of
secondsUntilStateChangeproperty have significant negative values. While this may be intentional and consistent with how the game engine handles door states (possibly indicating doors that have been in a specific state for a certain amount of time), it's worth confirming that these values won't cause any unexpected behavior.Also applies to: 9612-9612
🏁 Script executed:
#!/bin/bash # Check if other door entities have similar negative values for secondsUntilStateChange grep -r "secondsUntilStateChange:" Resources/Maps/Corvax/Shuttles/ | grep -v Poli.ymlLength of output: 3476
Negative door state timing values confirmed as intentional.
After verifying the repository, we found that multiple door entities (e.g., in QueenAnnesRevenge.yml, bocakillo.yml, hog.yml, etc.) consistently use negative values for
secondsUntilStateChange. This consistency indicates that these negative values are an intentional design choice for handling door state timings within the game engine. There is no evidence from the repository to suggest that these values will cause any unexpected behavior.
- Location Verified:
Resources/Maps/Corvax/Shuttles/BlackMarket/Poli.yml(line 644) and other similar files.- Next Steps: No changes are required unless further testing identifies unexpected behavior based on engine updates.
869-869:✅ Verification successful
Verify tile coordinate value change.
The value for coordinates in the
-2,2property has been changed from45294to61678. This is a significant change in value that could affect the map layout. Please verify this value is correct for the intended map structure.
🏁 Script executed:
#!/bin/bash # Check for similar coordinate values in other shuttle maps to see if this range is normal grep -r "0: 61" Resources/Maps/Corvax/Shuttles/ | grep -v Poli.ymlLength of output: 16939
Tile Coordinate Change Verified
The coordinate value in the
-2,2property ofResources/Maps/Corvax/Shuttles/BlackMarket/Poli.ymlhas been updated from45294to61678. A review of similar entries across other shuttle maps confirms that values in the 61xxx range (including61678) are standard. Hence, this change is consistent with the intended coordinate range and appears to be correct. Please confirm that the updated layout remains intentional for this map.Resources/Maps/Corvax/Shuttles/BlackMarket/bocakillo.yml (19)
11-11: New Tile Type Added: FloorMetalDiamond.
A new tile type ("FloorMetalDiamond") has been introduced in the tilemap. Please ensure that this tile is properly integrated into the rendering and collision systems as expected in the gameplay adjustments.
36-38: Tilemap Data Update for (-1,-1) Coordinate.
The tile data string for coordinate (-1,-1) has been updated. Verify that this new encoding accurately represents the intended tile characteristics (e.g. material, physical properties) for proper map behavior.
40-43: Tilemap Data Change for (0,-1) Coordinate.
The tile string at coordinate (0,-1) has been modified. Please double-check that the updated data maintains consistency with adjacent tile definitions and supports correct gameplay visuals and interactions.
257-259: Updated Door Timing Value.
The propertysecondsUntilStateChangefor the Door entity has been modified from –272.3784 to –620.3144. Confirm that this extended time delay produces the desired in-game effect without inadvertently impairing door mechanics.
280-296: Airlock Shuttle Syndicate Configuration Updates.
UIDs as well as transform positions for the entities under theAirlockShuttleSyndicateprototype (with UIDs 247, 260, and 261) have been revised. Please ensure these changes are compatible with the overall shuttle adjustments and that entity positioning reflects the intended design.
305-321: AtmosDeviceFanDirectional Prototype Revision.
The transform properties for theAtmosDeviceFanDirectionalentities have been updated. Verify that the new positions are correctly aligned with environmental simulation requirements and overall shuttle layout.
322-330: New AtmosDeviceFanTiny Prototype Introduced.
A newAtmosDeviceFanTinyprototype (with UID 248) has been added with specific rotation and position settings. Confirm that these values integrate well with the environmental systems and do not conflict with existing airflow or lighting configurations.
486-495: Cable Apc Extension Transform Adjustments.
Transform positions for components under the CableApcExtension (UIDs 29 and 30) have been updated. Please review these adjustments to ensure proper physical connectivity and interface with adjacent cable components.
695-703: CannonBall Prototype Transform Update.
TheCannonBallprototype now features updated transform properties (including a rotation of 1.5707963267948966 rad and new position values). Verify that these changes yield the expected projectile behavior during gameplay.
704-714: CannonBallGrapeshot Prototype Adjustments.
The transform positions for theCannonBallGrapeshotentities (UIDs 227 and 233) have been updated. Ensure that the adjustments are consistent with the physics and collision mechanics so that projectiles behave as intended.
716-758: Catwalk Prototype Transform Updates.
Multiple entities within theCatwalkprototype now include revised rotation and position values. Please check that these modifications harmonize with the overall shuttle geometry and visual aesthetics.
1440-1447: LuxuryPen Prototype Update.
A new transform configuration for theLuxuryPenentity (UID 22) has been introduced. Confirm that its placement and orientation complement the overall design layout and do not interfere with neighboring elements.
1448-1459: Paper Prototype Transform Adjustments.
The transform settings for thePaperprototype (UIDs 31 and 42) have been updated—including rotation and position. Verify that these changes render correctly and maintain consistency with in-game documentation or display expectations.
1461-1487: PirateFlag Entity Adjustments.
Within thePirateFlagprototype, several entities (UIDs 53, 152, 170, 211, and 244) have updated transform properties. Please ensure that the flag’s orientation and positioning support the thematic updates to the pirate shuttles while remaining coherent within the overall map layout.
1602-1613: RemoteSignaller Prototype Update.
TheRemoteSignallerentity (UID 235) has received updated transform coordinates and revised device link configuration. Confirm that this update preserves intended signaling functionality and effective inter-entity communication.
1663-1669: SmallGyroscope Transform Revision.
TheSmallGyroscopeprototype now features a modified rotation and position. Verify that these changes enable correct simulation of gyroscopic behavior and align with the nearby control systems.
1726-1767: Thruster Prototype Adjustments.
Multiple thruster entities have updated rotation and positional values. It is essential to verify that these adjustments provide the correct thrust directions and that the spatial alignment supports the intended propulsion dynamics.
1774-1797: WallPlastitaniumDiagonal Prototype Update.
Transform updates for entities under theWallPlastitaniumDiagonalprototype have been applied. Ensure that these changes integrate seamlessly with the modular wall system and support structural consistency.
2052-2058: WallWeaponCapacitorRechargerOmnidirectional Transform Update.
The transform for the wall-mounted weapon capacitor has been updated. Confirm that the new placement supports optimal operational functionality within the shuttle context.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Autsaider-IM
changed the title
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (16)
Resources/Prototypes/Corvax/Misc/books/PirateCodex.yml (1)
1-16: New YAML Entity Definition for PirateCodex
The new entityHyperlinkBookPirateCodeis clearly defined with the appropriate parent, ID, name, description, and components (including Sprite, HyperlinkBook, and Tag). This provides a well-structured blueprint for linking to the pirate wiki page.
Note: YAMLlint reported a missing newline at the end of the file. Please add a newline after line 16 to meet file formatting standards.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 16-16: no new line character at the end of file
(new-line-at-end-of-file)
Resources/Prototypes/_NF/Loadouts/Jobs/Contractor/fun.yml (1)
178-186: Commented Out Loadout Removal
The loadoutContractorHoverbikeFlatpackhas been entirely commented out, effectively disabling its use. Please ensure this removal is consistent with the overall gameplay adjustments and that any references to this loadout in other configuration files have been updated accordingly.Resources/Prototypes/Nyanotrasen/Catalog/Fills/Vending/Inventories/maildrobe.yml (1)
5-5: Inventory Item Removal
By commenting out theHoverbikeMailcarrierFlatpackentry, the active inventory for the MailDrobeInventory is now free from this item. This aligns with the removal of hoverbike-related elements in the PR. Please verify that similar adjustments have been applied in all related inventories to maintain consistency.Resources/Prototypes/Corvax/Entities/Structures/Walls/walls.yml (1)
26-67: YAML Formatting Issues in "WallWoodForced" Entity
The new entity definition forWallWoodForcedexhibits several YAML formatting concerns:
- Line 32: Incorrect indentation (expected 4 spaces but found 2).
- Line 41: Incorrect indentation (expected 6 spaces but found 4).
- Line 45: Incorrect indentation (expected 8 spaces but found 6).
- Line 54: Incorrect indentation (expected 8 spaces but found 6).
Additionally, trailing spaces are present on lines 64–67, and the file does not end with a newline, which may lead to parsing issues. Please adjust the indentation levels and remove any trailing whitespace to ensure full YAML compliance.
🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 32-32: wrong indentation: expected 4 but found 2
(indentation)
[warning] 41-41: wrong indentation: expected 6 but found 4
(indentation)
[warning] 45-45: wrong indentation: expected 8 but found 6
(indentation)
[warning] 54-54: wrong indentation: expected 8 but found 6
(indentation)
[error] 64-64: trailing spaces
(trailing-spaces)
[error] 65-65: trailing spaces
(trailing-spaces)
[error] 66-66: trailing spaces
(trailing-spaces)
[error] 67-67: no new line character at the end of file
(new-line-at-end-of-file)
[error] 67-67: trailing spaces
(trailing-spaces)
Resources/Maps/Corvax/POI/cove.yml (5)
4001-4016: Remove Deprecated Prototype & Add Transform Configurations.
The removal ofproto: CannonBallEmpand the addition of two new entity entries (uids 2108 and 2131) indicate an intentional update in the cannon-related configuration. Please ensure that any dependencies on the removed prototype are adjusted accordingly in the game logic.
4989-4996: Update Computer Console Configuration.
The removal ofproto: ComputerPalletConsoleNFHighMarketcombined with the addition of amissingComponentslist (includingAnchorable) suggests a shift to require explicit anchoring for this console. Verify that this change is consistent with the intended design and that no UI/gameplay dependencies are broken.
5016-5023: Revise Power Monitoring Entity Setup.
By removingproto: ComputerPowerMonitoringand introducing amissingComponentslist withAnchorable, the entity’s configuration is clearly adjusted. Please confirm that this change is intentional and that the altered behavior is reflected in the game’s power monitoring or diagnostic systems.
5045-5079: Remove Multiple Tabletop and Wall-Mounted Prototypes.
This hunk removes several prototypes (ComputerTabletopRadar,ComputerTabletopStationRecords,ComputerTabletopSurveillanceCameraMonitor, andComputerWallmountBlackMarketBankATM) and adds themissingComponents: - Anchorableproperty where applicable. Ensure that these removals and modifications are coordinated with related systems and that no stale references remain elsewhere in the configuration.
5113-5125: Remove Crate Prototypes for Food and Freezer Items.
The removal ofproto: CrateFoodCookingandproto: CrateFreezerpoints to an updated approach in handling crate entities within the map. Please verify that any required replacements or adjustments are implemented elsewhere and that gameplay elements dependent on these prototypes are not affected.Resources/Prototypes/Corvax/Catalog/Fills/Boxes/pirate.yml (2)
1-24: New Entity: BoxT2SuperCapacitor
The definition for "BoxT2SuperCapacitor" is clear and consistent with other box entities. Components such as StorageFill, Storage (with its grid coordinate “0,0,2,3”), and Sprite are defined properly.
38-55: New Entity: BoxDeathRattleImplantsPirat
The entity “BoxDeathRattleImplantsPirat” is introduced with a distinctive description and a two-part component definition (Sprite and Storage/StorageFill). The description’s creative tone adds character; however, consider reviewing the phrasing for consistency with other in-game texts.Resources/Prototypes/_NF/Catalog/pirate_uplink_catalog.yml (1)
385-385: YAML Formatting Issues
Static analysis has flagged several formatting issues, including extra spaces after colons, trailing spaces, and a missing newline at the end of the file. Please use a YAML formatter or linter to resolve these issues for improved readability and to avoid potential parsing errors.Also applies to: 392-392, 401-401, 417-417, 433-433, 437-437, 463-463, 467-467, 481-481, 485-485, 500-500, 514-514
🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 385-385: too many spaces after colon
(colons)
Resources/Maps/Corvax/Shuttles/Nfsd/Cvasar.yml (2)
345-362: New Prototype: AirAlarm
The new "AirAlarm" prototype includes a Transform and a DeviceList component with a series of device IDs (44, 59, 299, 190, 191, 189, 63, 66, 95). Please verify that these IDs correspond to the intended devices and that the alarm functions correctly when triggered.
1874-1883: ShuttleSmgRifleAmmoBox Positioning
The new "ShuttleSmgRifleAmmoBox" entries (uids 93 and 113) define precise coordinates for item placement. It would be beneficial to double-check that these positions align with the overall layout and that they are easily accessible in-game.Resources/Prototypes/_NF/Catalog/Bounties/pirate_bounties.yml (1)
352-359: Gun Safe Bounty Addition & Static Analysis Note
A newPirateBountyGunSafebounty has been added with a reward of 4 and an amount of 3. Additionally, static analysis has flagged trailing spaces (line 351) and the absence of a newline at the end of the file (line 359). Please clean up these formatting issues to comply with YAML standards.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 359-359: no new line character at the end of file
(new-line-at-end-of-file)
Resources/Maps/Corvax/Shuttles/BlackMarket/falcon.yml (1)
648-742: Bulk Addition of New Entities (UIDs 541 to 569)
A series of new entities—with UIDs 541, 542, 544, 545, 546, 547, 549, 550, 551, 560, 561, 562, 563, 564, 565, 566, 567, 568, and 569—have been added. Each entity comes with its own Transform component (with positions such as-0.5,-18.5,0.5,-17.5,1.5,-17.5, etc.) and the same parent value (3). Please ensure that:
• These new placements are balanced and consistent with gameplay expectations.
• There are no unintended overlaps or misalignments with existing entities on the map.
If any additional documentation or visual verification is needed, please let us know.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (5)
Resources/Textures/Corvax/Boxes/pirate.rsi/boxpirat.pngis excluded by!**/*.pngResources/Textures/Corvax/Boxes/pirate.rsi/capacitor.pngis excluded by!**/*.pngResources/Textures/Corvax/Boxes/pirate.rsi/shelllethal.pngis excluded by!**/*.pngResources/Textures/Corvax/Boxes/pirate.rsi/ziptie.pngis excluded by!**/*.pngResources/Textures/Corvax/Objects/Misc/books.rsi/PirateCodex.pngis excluded by!**/*.png
📒 Files selected for processing (26)
Resources/Maps/Corvax/POI/cove.yml(15 hunks)Resources/Maps/Corvax/Shuttles/BlackMarket/Poli.yml(11 hunks)Resources/Maps/Corvax/Shuttles/BlackMarket/barnacle.yml(16 hunks)Resources/Maps/Corvax/Shuttles/BlackMarket/bocakillo.yml(17 hunks)Resources/Maps/Corvax/Shuttles/BlackMarket/falcon.yml(5 hunks)Resources/Maps/Corvax/Shuttles/BlackMarket/hog.yml(10 hunks)Resources/Maps/Corvax/Shuttles/BlackMarket/menace.yml(14 hunks)Resources/Maps/Corvax/Shuttles/BlackMarket/schooner.yml(21 hunks)Resources/Maps/Corvax/Shuttles/Nfsd/Cvasar.yml(28 hunks)Resources/Maps/_NF/POI/lpbravo.yml(1 hunks)Resources/Prototypes/Corvax/Catalog/Fills/Boxes/pirate.yml(1 hunks)Resources/Prototypes/Corvax/Entities/Structures/Walls/walls.yml(1 hunks)Resources/Prototypes/Corvax/Misc/books/PirateCodex.yml(1 hunks)Resources/Prototypes/Corvax/Shipyard/Expedition/dreadnought.yml(1 hunks)Resources/Prototypes/Corvax/Shipyard/Nfsd/Cvasar.yml(1 hunks)Resources/Prototypes/Nyanotrasen/Catalog/Fills/Vending/Inventories/maildrobe.yml(1 hunks)Resources/Prototypes/_NF/Catalog/Bounties/pirate_bounties.yml(15 hunks)Resources/Prototypes/_NF/Catalog/VendingMachines/Inventories/contravend.yml(1 hunks)Resources/Prototypes/_NF/Catalog/pirate_uplink_catalog.yml(10 hunks)Resources/Prototypes/_NF/Catalog/security_uplink_catalog.yml(1 hunks)Resources/Prototypes/_NF/Entities/Markers/Spawners/Random/dungeon_items_general.yml(1 hunks)Resources/Prototypes/_NF/Entities/Objects/Devices/pda.yml(3 hunks)Resources/Prototypes/_NF/Loadouts/Jobs/Contractor/fun.yml(1 hunks)Resources/Prototypes/_NF/Loadouts/contractor_loadout_groups.yml(1 hunks)Resources/Textures/Corvax/Boxes/pirate.rsi/meta.json(1 hunks)Resources/Textures/Corvax/Objects/Misc/books.rsi/meta.json(1 hunks)
✅ Files skipped from review due to trivial changes (7)
- Resources/Textures/Corvax/Objects/Misc/books.rsi/meta.json
- Resources/Prototypes/_NF/Catalog/VendingMachines/Inventories/contravend.yml
- Resources/Prototypes/_NF/Catalog/security_uplink_catalog.yml
- Resources/Prototypes/_NF/Entities/Markers/Spawners/Random/dungeon_items_general.yml
- Resources/Textures/Corvax/Boxes/pirate.rsi/meta.json
- Resources/Prototypes/_NF/Loadouts/contractor_loadout_groups.yml
- Resources/Maps/_NF/POI/lpbravo.yml
🚧 Files skipped from review as they are similar to previous changes (2)
- Resources/Prototypes/Corvax/Shipyard/Expedition/dreadnought.yml
- Resources/Maps/Corvax/Shuttles/BlackMarket/Poli.yml
🧰 Additional context used
🪛 YAMLlint (1.35.1)
Resources/Prototypes/Corvax/Misc/books/PirateCodex.yml
[error] 16-16: no new line character at the end of file
(new-line-at-end-of-file)
Resources/Prototypes/Corvax/Entities/Structures/Walls/walls.yml
[warning] 32-32: wrong indentation: expected 4 but found 2
(indentation)
[warning] 41-41: wrong indentation: expected 6 but found 4
(indentation)
[warning] 45-45: wrong indentation: expected 8 but found 6
(indentation)
[warning] 54-54: wrong indentation: expected 8 but found 6
(indentation)
[error] 64-64: trailing spaces
(trailing-spaces)
[error] 65-65: trailing spaces
(trailing-spaces)
[error] 66-66: trailing spaces
(trailing-spaces)
[error] 67-67: no new line character at the end of file
(new-line-at-end-of-file)
[error] 67-67: trailing spaces
(trailing-spaces)
Resources/Prototypes/_NF/Catalog/pirate_uplink_catalog.yml
[warning] 385-385: too many spaces after colon
(colons)
[error] 392-392: trailing spaces
(trailing-spaces)
[warning] 401-401: too many spaces after colon
(colons)
[warning] 417-417: too many spaces after colon
(colons)
[warning] 433-433: too many spaces after colon
(colons)
[error] 437-437: trailing spaces
(trailing-spaces)
[error] 463-463: trailing spaces
(trailing-spaces)
[warning] 467-467: too many spaces after colon
(colons)
[error] 481-481: trailing spaces
(trailing-spaces)
[warning] 485-485: too many spaces after colon
(colons)
[warning] 500-500: too many spaces after colon
(colons)
[error] 514-514: no new line character at the end of file
(new-line-at-end-of-file)
[error] 514-514: trailing spaces
(trailing-spaces)
Resources/Prototypes/_NF/Catalog/Bounties/pirate_bounties.yml
[error] 351-351: trailing spaces
(trailing-spaces)
[error] 359-359: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (127)
Resources/Prototypes/_NF/Entities/Objects/Devices/pda.yml (3)
381-384: Integration of New Pirate Items in PirateNFIDCard
The addition of thebookSlotwithstartingItem: HyperlinkBookPirateCodeand thepenSlotwithstartingItem: LuxuryPenfor thePirateNFIDCardin the PirateNFPDA entity is implemented correctly. These changes correctly reflect the updated pirate item dynamics.
397-401: Consistent Update for PirateCaptainNFIDCard
The configuration forPirateCaptainNFIDCardnow aligns with the new pirate item changes by assigningHyperlinkBookPirateCodeto the book slot andLuxuryPento the pen slot. This consistency across pirate PDA entities is commendable.
415-418: Update for PirateFirstMateNFIDCard Reflects New Design
The modifications forPirateFirstMateNFIDCardmaintain consistency by integrating the newHyperlinkBookPirateCodeandLuxuryPeninto the corresponding slots. This ensures uniformity across pirate PDAs which is essential for predictable gameplay behavior.Resources/Prototypes/Corvax/Shipyard/Nfsd/Cvasar.yml (2)
1-5: Enhanced Metadata Information
The modifications updating the author metadata (changing toAuthor Info), setting the Discord handle toautsaider_m, introducing the licenseCC-BY-NC-ND-3.0, and adding the project nameCorvax_frontiergreatly improve the clarity and traceability of this file. These enhancements help maintain better documentation practices.
8-10: Updated Maintainer Details
The maintainer information now includes a valid GitHub URL and Discord handle. This update increases the accountability and ease of contact for future maintenance.Resources/Maps/Corvax/POI/cove.yml (10)
5133-5140: Adjust Chemical Component Values.
The update to themoleslist—with the insertion of two nonzero values (1.8977377 and 7.139109)—modifies the chemical composition or simulation parameters. Double-check that these values are correct and align with experimental or gameplay requirements.
5151-5165: Remove Party Crate Prototype.
The removal ofproto: CrateFunPartysuggests a rebalancing or a redesign of party-related items. Ensure that this change is coordinated with any other rebalancing efforts and that removing this prototype does not leave orphaned references in the game logic.
5609-5618: Eliminate Double Emergency Oxygen Tank Prototype.
Theproto: DoubleEmergencyOxygenTankFilledhas been removed, and the entity configuration now focuses solely on transform details. Please confirm that this removal is intentional and verify that no gameplay mechanics are adversely affected by the absence of this prototype.
6123-6129: Remove Floor Drain Prototype.
Removal of theFloorDrainprototype should be verified to ensure it isn’t used in any subsequent logic or map interactions. Please confirm that its elimination is in line with the new design objectives.
7018-7024: Remove FoodMeat Prototype.
The deletion ofproto: FoodMeatappears consistent with the objective of replacing prepared food with alternative ingredient types. Verify that all game mechanics and visual assets referencing this prototype have been updated accordingly.
7041-7060: Remove FoodPlate Prototype & Update Entity Storage.
The removal ofproto: FoodPlate, along with the configuration of entities (uids 684 and 834) having physics and storage components, implies a redesign in how food serving elements are handled. Confirm that the removal does not impact any core gameplay or user interface features.
7987-8007: Update Magazine Entity Configuration.
By removingproto: MagazineNovaliteC1Emptyand introducing several new transform entries (uids 2132, 2141, 2142), the magazine system is now updated. Please check that these new configurations meet the expected handling for ammunition or magazine displays in-game.
8630-8640: Add New Entity with Enhanced Transform Data.
A new entity (uid: 1136) with specified transform properties has been added. Ensure that its role is clearly defined in the configuration and that it integrates well with the surrounding map elements.
9758-9770: Remove Weapon Rack & Stunbaton Prototypes.
The removal ofproto: StructurePistolRackPiratesFilledandproto: Stunbatonindicates a shift in the weapon and storage systems for pirate elements. Please verify that these removals align with the overall balance changes and that any dependent systems are updated.
13029-13052: Update Weapon Prototypes: Removal and Reconfiguration.
This hunk removesproto: WeaponGrapplingGun,proto: WeaponLauncherPirateCannon, andproto: WeaponRevolverArgentiNonlethalwhile providing new transform setups for the associated entities. It’s important to confirm that these changes align with the updated pirate balance and that all in-game references to these weapons have been revised.Resources/Prototypes/Corvax/Catalog/Fills/Boxes/pirate.yml (1)
25-37: New Entity: BoxZiptiePirat
This entity is straightforward and follows the established pattern. The sprite component uses the “boxpirat” state and adds a “ziptie” layer. Just ensure that the visual asset for the “ziptie” state is correct.Resources/Prototypes/_NF/Catalog/pirate_uplink_catalog.yml (12)
55-73: Listing Removal: UplinkPirateCaptainCrateFilled
The listing for "UplinkPirateCaptainCrateFilled" has been commented out. This appears intentional as part of the item removals. Please verify that any dependencies on this listing have been removed from the game logic.
74-89: Updated Listing: UplinkPirateCrateFilled
The cost for "UplinkPirateCrateFilled" has been increased from 8 to 13 Doubloons. This change should be cross-checked with the overall in-game economy to ensure it maintains balance.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 76-76: too many spaces after colon
(colons)
90-121: Listing Removals: UplinkPirateSatchelFilled and UplinkPirateMagboots
These listings have been commented out, effectively removing them from the catalog. Confirm that their removal is reflected in other parts of the code (e.g. inventory handling and UI) so that there are no dangling references.
224-271: Grenade Listings Adjustments
The listings for UplinkPirateRedGrenade, UplinkPirateGreenGrenade, and UplinkPirateGrayGrenade now have updated costs (2 Doubloons) and their category changed to "UplinkPirateExplosives." These modifications appear to streamline the catalog; please verify that the new pricing and categorization are in line with the intended gameplay balance.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 226-226: too many spaces after colon
(colons)
[warning] 242-242: too many spaces after colon
(colons)
[warning] 258-258: too many spaces after colon
(colons)
383-398: New Listing: UplinkPirateLaserGun
A new listing for a “старомодный лазерный бластер” is added with a cost of 4 Doubloons. The description and icon reference look appropriate—just ensure that the associated productEntity "WeaponLaserGun" is fully implemented and tested.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 385-385: too many spaces after colon
(colons)
[error] 392-392: trailing spaces
(trailing-spaces)
399-414: New Listing: UplinkPiratBreachingCharge
This entry introduces a breaching charge capable of “пробивать любую стену” at a cost of 2 Doubloons. The productEntity "BreachingCharge" should be verified so that it meets functional expectations in-game.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 401-401: too many spaces after colon
(colons)
415-430: New Listing: UplinkPiratBoxMRE
The “сухой паёк” listing is added with a cost of 4 Doubloons. The reference to productEntity "BoxMRE" seems proper; just confirm that it carries the correct attributes and functionality.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 417-417: too many spaces after colon
(colons)
431-445: New Listing: UplinkPiratBoxLightRifle
The listing for "Коробка Винтовочных Патрон" is succinct with a cost of 2 Doubloons. Ensure that the associated productEntity "MagazineBoxLightRifle" reflects the intended technical and visual specifications.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 433-433: too many spaces after colon
(colons)
[error] 437-437: trailing spaces
(trailing-spaces)
446-464: Listing Removal: UplinkPiratSpeedLoaderMagnumAP
The listing for "УplinkPiratSpeedLoaderMagnumAP" has been commented out. Verify that any references (in scripts or UI) have been updated to prevent errors.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 463-463: trailing spaces
(trailing-spaces)
465-482: New Listing: UplinkPiratBoxT2SuperCapacitor
This listing connects to the newly introduced "BoxT2SuperCapacitor" entity and is priced at 4 Doubloons. Ensure that the catalog integration works seamlessly and that any balancing considerations are met.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 467-467: too many spaces after colon
(colons)
[error] 481-481: trailing spaces
(trailing-spaces)
483-497: New Listing: UplinkPiratBoxZiptiePirat
The new entry for "Набор Стяжек" is added at a cost of 3 Doubloons with appropriate conditions. Verify that the reference to "BoxZiptiePirat" is correct and that the item appears as intended within the uplink interface.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 485-485: too many spaces after colon
(colons)
498-514: New Listing: UplinkPiratBoxDeathRattleImplantsPirat
This listing mirrors the newly added "BoxDeathRattleImplantsPirat" with a cost of 4 Doubloons. The description remains consistent with the entity definition. Ensure cross-references are in sync.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 500-500: too many spaces after colon
(colons)
[error] 514-514: no new line character at the end of file
(new-line-at-end-of-file)
[error] 514-514: trailing spaces
(trailing-spaces)
Resources/Maps/Corvax/Shuttles/Nfsd/Cvasar.yml (6)
10-11: Tilemap Update: Standardizing Plating Terminology
The tilemap entry now uses "PlatingDamaged" (line 11) instead of a likely older term (e.g. "PlatingBurnt"). This renaming helps standardize terminology across configurations. Confirm that all dependent references and scripts are updated accordingly.
413-420: APCBasic Update
The "APCBasic" entity now uses uid 305 with updated transformation parameters. Ensure that downstream systems expecting this prototype can handle the new UID and that positional adjustments are reflected in gameplay.
456-488: New Prototype: AtmosFixBlockerMarker
Multiple instances of "AtmosFixBlockerMarker" have been added with specific Transform positions. It is important to confirm that these markers are positioned appropriately so that they do not conflict with other elements on the shuttle and that they perform their intended function in atmospherics.
1649-1661: Rack Prototype Enhancement
An additional entity (uid 302) has been included in the "Rack" prototype with a transform position of (5.5, 13.5). Please confirm that this placement is deliberate and that it does not cause overlap or spacing issues with neighboring elements.
1713-1756: New Prototype: RandomSpawner100
"RandomSpawner100" now includes several spawn points with varying rotations and positions. Ensure that these settings produce the intended randomness without interfering with existing spawner mechanics or causing unintended overlaps.
2316-2321: WarpPoint Update
The "WarpPoint" entity now specifies a new position (pos: 4.5,16.5). Verify that this update maintains proper navigational behavior and does not disrupt the flow of movement within the shuttle.Resources/Maps/Corvax/Shuttles/BlackMarket/bocakillo.yml (25)
11-11: New Tile Type Added:
A new tile mapping forFloorMetalDiamondhas been introduced at key 4. Ensure that this additional tile type is properly documented and supported by the rendering and collision logic in the engine.
36-39: Updated Tile Data for Grid Cell (-1,-1):
The tile data for the cell with index-1,-1has been updated (see the long tile string on line 38). Please verify that the updated encoded data is correctly formatted and yields the intended visual and gameplay properties.
40-43: Revised Tile Configuration for Grid Cell (0,-1):
The configuration for cell0,-1now features modified tile data (line 42 shows the updated tiles string). Confirm that this revision accurately reflects the design changes and does not introduce rendering artifacts.
257-259: Door Timing Adjustment:
ThesecondsUntilStateChangeproperty for the Door component has been updated to-708.32196(line 258). Please ensure that this new delay value produces the desired door animation timing and state transitions in-game.
322-330: New Prototype – AtmosDeviceFanTiny:
A new proto forAtmosDeviceFanTinyhas been introduced with UID 248 and a transform rotation of-1.5707963267948966 radat position2.5,4.5(lines 322–330). Double-check that this proto integrates correctly with the overall atmospheric device system and that its transform settings are as intended.
486-495: CableApcExtension Transform Updates (UIDs 29 & 30):
The entity transforms for UIDs 29 and 30 under theCableApcExtensionprototype have been modified (lines 486–495). Please confirm that these new coordinates (positions and parent associations) align with the intended layout changes.
586-630: Bulk Update to CableApcExtension Entities (UIDs 269–277):
There is a substantial revision of the transform data for several entities (UIDs 269 through 277) within theCableApcExtensionblock (lines 586–630). Given the number of items affected, please verify that all positions and parent relationships are correct and consistent with the redesigned cable routing and overall map layout.
695-703: New CannonBall Prototype Introduced:
TheCannonBallprototype (with UID 225) has been added with a specific rotation (1.5708 rad) and position (3.5430837,5.658111) (lines 695–703). Ensure that these transform settings are appropriate for the projectile’s behavior and that collision/physics are updated accordingly.
704-714: New CannonBallGrapeshot Prototype Introduced:
A new proto forCannonBallGrapeshothas been added (UIDs 227 and 233, lines 704–714) with updated transform position values. Verify that the spatial configuration of these entities produces the intended spread or grouping effect during gameplay.
716-759: Catwalk Entity Transform Adjustments:
Several transform updates have been applied to theCatwalkprototype (lines 716–759) for entities with UIDs 32, 40, 54, 56, 61, 62, etc. Please check that the new rotation and position values maintain structural integrity visually and in terms of collision/pathfinding within the map.
1415-1422: LockerWallMedical Transform Revision:
The transform for theLockerWallMedicalprototype (UID 149, lines 1415–1422) now includes an updated rotation and position. Confirm that these adjustments support the visual layout and that any associated functional behaviors (like collision boundaries) remain correct.
1423-1429: LuxuryPen Positioning Update:
TheLuxuryPenprototype now has revised transform values (lines 1423–1429). Ensure that its new position fits within the overall design language and that the modifications meet gameplay and aesthetic goals.
1430-1441: Paper Prototype Transform Changes:
Updates to the transform settings for thePaperprototype (lines 1430–1441) affect both rotation and positional coordinates. It is recommended to verify that these adjustments correctly position the item in the game world without causing overlap or visual discrepancies.
1522-1528: PowerCellRecharger Coordinate Update:
Within thePowerCellRechargerprototype, the transform for UID 157 (lines 1522–1528) has been updated. Please ensure that the new coordinate(-0.5,2.5)is consistent with the intended placement of this device within the game environment.
1537-1548: PoweredSmallLight Transform Adjustments:
The transform data for entities under thePoweredSmallLightprototype (UIDs 146 and 224, lines 1537–1548) have been updated. Verify that the revised positions support proper lighting effects and integrate seamlessly with surrounding environmental elements.
1549-1556: Rack Prototype Transformation Updates:
The transform for theRackprototype (line 1549–1556, e.g. UID 63) has been adjusted (notably the rotation and position). It’s advisable to confirm that these changes do not adversely affect collision boxes or visual alignment with adjacent structures.
1557-1575: Railing Transform Corrections:
Updated transform values (rotation and position) have been applied to theRailingprototype (lines 1557–1575). Please review these values to ensure that the railing aligns properly both visually and functionally with adjacent map elements.
1577-1583: RailingCorner Position Adjustment:
TheRailingCornerentity (UID 223, lines 1577–1583) now features an updated position. Verify that this change accurately reflects the intended corner geometry in the layout.
1584-1595: RemoteSignaller Configuration Update:
The transform for theRemoteSignallerprototype (lines 1584–1595) has been revised, and its device link source now lists linked ports (e.g. port 86 with both Toggle and Trigger actions). Please double-check that these updates correctly implement the desired signaling behavior and positional alignment.
1645-1651: SmallGyroscope Transform Revision:
TheSmallGyroscopeprototype now has new rotation and position values (lines 1645–1651). Confirm that these modifications reflect the intended orientation and placement required for accurate gyroscopic behavior in-game.
1613-1644: SignalButtonDirectional Device Link Reconfiguration:
Within theSignalButtonDirectionalprototype (lines 1613–1644), both the transform data and the device link source mapping have been updated. Please verify that the updated link associations (to ports 184, 219, 4, 212, 171, 220 for UID 186 and the trigger action for UID 226) work as expected within the control system.
1687-1717: Thruster Prototype Adjustments:
Several thruster entities under theThrusterprototype (lines 1687–1717, including UIDs 69, 182, 210, 214, etc.) have updated rotation and position settings. It is important to review these changes to ensure they correctly impact ship maneuverability and that the physics behavior remains consistent with design goals.
1735-1758: WallPlastitaniumDiagonal Structural Update:
TheWallPlastitaniumDiagonalprototype now features revised transform settings (lines 1735–1758 for UIDs 185, 202, 205, and 237). Confirm that the new positions and rotations are in line with the intended structural modifications and that they maintain proper collision and visual coherence.
1759-1784: WallPlastitaniumShuttle Transform Updates:
Updates to the transform configuration of theWallPlastitaniumShuttleprototype (lines 1759–1784 for UIDs 72, 73, 75, 77, 79) have been applied. Please verify that these changes meet the updated shuttle design specifications and align correctly with surrounding architectural elements.
2013-2019: WallWeaponCapacitorRechargerOmnidirectional Positioning:
The transform for theWallWeaponCapacitorRechargerOmnidirectionalprototype (lines 2013–2019, UID 206) has been updated. Confirm that its new position supports both functional integration and visual consistency with adjacent systems.Resources/Maps/Corvax/Shuttles/BlackMarket/hog.yml (8)
384-461: Verify Updated GridAtmosphere Tile Values
Several tile indices in the GridAtmosphere data have been updated—for example, the tile at coordinate (0,0) is now set to 65423, (–1,0) to 65343, (0,1) to 65262, and (–1,1) to 65535, among many others. Please verify that these new numeric values correctly map to the intended textures and reflect the desired changes in the BlackMarket shuttle’s design. Also, ensure that any in-game logic or other configuration files referencing these tile values are updated accordingly.
593-616: Confirm AirlockShuttleSyndicate Transform Adjustments
The transform components for the AirlockShuttleSyndicate prototype have been updated with new rotation and position values (for instance, uid 125 now has a rotation of –1.5708 rad and position (–7.5,–3.5), among others). Please double-check that these modifications correctly align the airlocks in the redesigned shuttle layout and that no residual offset errors remain from previous configurations.
759-845: Review AtmosDeviceFanDirectional Transform Modifications
This prototype has undergone several precise changes to the transform components (e.g., updated rotations of 1.5708 rad or –1.5708 rad and adjusted positions for uids 58, 66, 104, 108, 176, 177, 210, 244, 246, 296, 585, 586, and 588). Please verify that these modifications are consistent with the intended airflow and environmental design adjustments associated with the new pirate balance changes.
845-892: Inspect AtmosFixBlockerMarker Transform Updates
The transform positions for entities under the AtmosFixBlockerMarker prototype have been modified (with updated positions such as –6.5,2.5; –6.5,3.5; –6.5,4.5; and similar values for other uids). Please ensure that these new positions are correct, do not lead to overlaps or unintended collisions, and integrate well with adjacent environmental features.
4607-4633: Validate Weapon Slot Entity References in StructureMeleeWeaponRack
Within the StructureMeleeWeaponRack prototype, the container slots for weapon1, weapon2, and weapon3 now reference uids 624, 626, and 627 respectively, while weapon4 and weapon5 are set to null. Please verify that these changes correctly reflect the intended inventory setup and that leaving some slots as null is deliberate.
2655-2661: Confirm Cutlass Prototype Parent Reference
In the Cutlass prototype, the Transform component for uid 626 has been modified—specifically, its parent attribute is now set to 621. Please check that this change accurately reflects the desired parent–child relationship and that it is consistent with related weapon configurations.
2710-2717: Verify EnergyCutlass Transform Parent Setting
Similarly, in the EnergyCutlass prototype, the Transform component for uid 627 has been updated to set its parent to 621. Ensure that this change is correct within the context of the in-game hierarchy and that it matches the intended design for these weapon types.
2584-2594:❓ Verification inconclusive
Reassess Negative Door Timing in CurtainsBlack Prototype
In the CurtainsBlack prototype’s door components, thesecondsUntilStateChangevalues are set to –5165.067 and –3350.7908. Negative timing values can be unusual. Please confirm that this is an intentional configuration (for example, to force an immediate or delayed state change) and consider adding documentation or a comment explaining the rationale if it is deliberate.
I'll run a shell script to search for usages of negative
secondsUntilStateChangevalues across all YAML files. This will help us verify whether the negative timing in the CurtainsBlack prototype is an intentional configuration or an anomaly.
🏁 Script executed:
#!/bin/bash # Search for all occurrences of negative "secondsUntilStateChange" in YAML files rg "secondsUntilStateChange:\s*-\d+\.\d+" --type yamlLength of output: 10066
Reassess Negative Door Timing in BlackMarket Components
In the fileResources/Maps/Corvax/Shuttles/BlackMarket/hog.yml(lines 2584–2594), the door components list negative values forsecondsUntilStateChange(‑5165.067 and ‑3350.7908), and an additional value (‑3920.4885) is also present in this file. We observed similar negative timings across several other map YAMLs, indicating that this might be a consistent, intentional configuration (perhaps to trigger immediate or controlled delayed transitions). Please verify that these negative timings are indeed deliberate; if so, consider adding inline documentation or comments to clarify the rationale for future maintainers.Resources/Maps/Corvax/Shuttles/BlackMarket/menace.yml (4)
25-28: Review of Updated MapGrid Tile Data
The encoded tile string for the0,0:chunk has been updated. Given the complexity of this value, ensure that the new encoding correctly represents the intended layout and that no erroneous artifacts are introduced during map rendering.
172-178: Atmospheric Grid Updates
Within the GridAtmosphere data, several tile values (e.g.2: 204,2: 8, and2: 34) were modified. Please verify that these new values accurately convey the intended atmospheric conditions and that they are in line with overall environmental design specifications.
6-7:❓ Verification inconclusive
New Floor Tile Types Added
The addition ofFloorHullReinforcedandFloorMetalDiamondin the tilemap increases visual and gameplay variety. Please confirm that the matching textures, collision data, and any behavioral properties are updated accordingly.
Below is a shell script to help verify that the new floor tile types—FloorHullReinforced and FloorMetalDiamond—are referenced appropriately across the codebase (including potential texture, collision, and behavior definitions):
After running these scripts, please review the outputs to confirm that:
- Matching texture files for the new tile types are updated.
- Collision data entries associated with these tile types have been modified.
- Any additional behavioral properties tied to these tiles have been set up accordingly.
Next Steps:
Verify that the repository contains the necessary updates for textures, collision, and behavior logic in relation to these new floor tile types.
🏁 Script executed:
#!/bin/bash echo "Searching for references to 'FloorHullReinforced'..." rg -n "FloorHullReinforced" . echo "Searching for references to 'FloorMetalDiamond'..." rg -n "FloorMetalDiamond" . echo "Searching for nearby 'collision' or 'texture' configurations..." rg -n "(collision|texture)" .Length of output: 66303
New Floor Tile Types Integration – Verification Required
The grep results confirm that bothFloorHullReinforcedandFloorMetalDiamondare defined in our tile prototypes (e.g., inResources/Prototypes/Tiles/floors.yml) and appear correctly in multiple map files. Please verify that their associated assets and properties are fully updated as follows:
- Texture Assets: Confirm that the appropriate textures are assigned to these tile types in their prototype definitions.
- Collision Data: Ensure that collision settings (or any physics properties) for these tiles are configured as intended.
- Gameplay Behaviors: Review any behavioral properties related to these new floor types so that gameplay variety is maintained.
Once these areas are confirmed, the integration of these new floor tiles should be solid.
242-291:❓ Verification inconclusive
Airlock Prototypes Update
The removal of theAirlockGlassShuttleSyndicateprototype—and its apparent replacement by multipleAirlockHatchentries (with uids 10, 11, 13, and 19)—is a central change here. Ensure that all downstream references (in mission scripts, automation, or interactive events) have been updated accordingly, and that the chosen transform rotations (π radians) and positions suit the desired gameplay effect.
🏁 Script executed:
#!/bin/bash # Search for references to "AirlockGlassShuttleSyndicate" in the repository echo "Searching for 'AirlockGlassShuttleSyndicate' occurrences:" rg "AirlockGlassShuttleSyndicate" -n . echo "-------------------------------------------------" # Search for references to "AirlockHatch" in the repository echo "Searching for 'AirlockHatch' occurrences:" rg "AirlockHatch" -n .Length of output: 7668
Action Required: Verify Downstream Updates for Airlock Prototypes
The changes in
Resources/Maps/Corvax/Shuttles/BlackMarket/menace.ymlnow include both the legacyAirlockGlassShuttleSyndicateblock (with uids 250 and 251) and a new block usingAirlockHatch(with uids 10, 11, 13, and 19). However, our repository search shows that many other files—mission scripts, localization files, and additional map definitions—still reference the oldAirlockGlassShuttleSyndicateprototype. Please ensure that:
- Downstream References: All mission scripts, automation routines, interactive events, and localization entries have been updated to reference the new
AirlockHatchentities where needed.- Gameplay Alignment: The transform rotation (π radians) and positional values for the new
AirlockHatchentries are consistent with the gameplay and visual requirements.- Prototype Consistency: Consider if the legacy
AirlockGlassShuttleSyndicateentry should be entirely removed from this file or marked for deprecation to avoid any ambiguity.Review and verify these areas across the codebase to ensure a smooth transition without unintended side effects.
Resources/Maps/Corvax/Shuttles/BlackMarket/barnacle.yml (4)
105-107: Atmospheric Grid Tile Value Change
The tile value at coordinate (-1,0) has been updated to61091in the atmospheric grid. Please double-check that this adjustment produces the expected environmental effect on the Barnacle map.
206-213: AirlockHatch Prototype Addition
A newAirlockHatchprototype with uid 95 has been added (with a transform at position -2.5,1.5 on parent 201). Ensure that this new entity integrates seamlessly with adjacent interactive systems and that its positioning is consistent with level design expectations.
400-450: General Verification of Entity Transforms
A large number of entities have updated transform positions and rotations throughout this file. It is advisable to conduct a thorough review (or automated test) to ensure that no unintended overlaps or misplacements occur, particularly as these modifications affect gameplay spatial layout.
1400-1410: Decal Grid and Entity Layout Consistency
Review the decal definitions and verify that the positional and transform values for all added entities align with the overall visual and functional design of the Barnacle shuttle map.Resources/Prototypes/_NF/Catalog/Bounties/pirate_bounties.yml (36)
2-10: Deprecated Pirate Bounty Entries Commented Out
Several pirate bounty entries (e.g.PirateBountyMail) have been commented out. This deprecation should be confirmed as intentional within the broader balance changes. Make sure no active systems depend on these entries before final removal.
11-19: PirateBountyPDA Update
ThePirateBountyPDAbounty now offers a reward of 5 with an entry amount of 3. Please verify that this adjustment aligns with the overall bounty balancing strategy and that players will have appropriate access to this item in-game.
20-28: Extinguisher Bounty Adjustment
In thePirateBountyExtinguisherentry, note that the amount has been adjusted to 3 (#CorvaxFrontier). Confirm that this change appropriately scales the value and rarity of fire extinguishers within the bounty rewards system.
29-37: Captain Gloves Bounty Tweak
ThePirateBountyCaptainGlovesentry now uses the item IDClothingHandsMercenaryGlovesCombat(with a reward of 5 and an amount of 2). Verify that the new item reference is correct and that the balance change meets design expectations.
38-47: Deprecated Gyro Bounty
ThePirateBountyGyroentry has been commented out. Please ensure that its removal does not leave any gaps in gameplay or reward progression that might affect overall balance.
48-56: Defibrillator Bounty Consistency
ThePirateBountyDefibentry remains with a reward of 5 and an amount of 3. Confirm that these settings are consistent with their intended rarity and impact in gameplay.
57-66: Alcohol Bounty Update
PirateBountyAlcoholnow offers a reward of 4 with an entry amount of 2. Evaluate that this modification is in line with the desired difficulty and provides a proper incentive within the bounty system.
67-76: Thruster Bounty Adjustment
ThePirateBountyThrusterbounty is updated with a reward of 4 and an amount of 3. Please verify that this change properly reflects the value and availability of thrusters in the game.
77-96: Commented Out Bounty Entries (GravGen & VendingMachine)
Entries such asPirateBountyGravGenandPirateBountyVendingMachinehave been commented out. Verify that these removals are intentional and consistent with the overall restructuring of pirate bounties.
97-105: Cappy Bounty Rebalance
The reward forPirateBountyCappyhas been increased to 15, a significant change that should be reviewed in terms of its overall impact on game economics and player incentives.
106-114: Cultist Necklace Bounty Update
With the reward increased to 7, thePirateBountyCultistNecklaceentry now offers a higher incentive for acquiring theClothingNeckAmuletBloodCult. Confirm that this adjustment fits within the new balance parameters.
115-123: NFSD Campaign Bounty Revision
ThePirateBountyNfsdCampaignnow offers a reward of 6. Please verify that this change encourages player participation without disrupting the cumulative bounty balance.
124-132: ScafSuit Bounty Update
ThePirateBountyScafSuitentry now has a reward of 6 and referencesClothingOuterHardsuitScaf. Ensure that the new item reference is valid and that the adjusted reward provides the proper challenge level.
133-142: RTG Bounty Adjustment
ThePirateBountyRTGentry now offers a reward of 6 and an amount of 2. Confirm that these changes accurately reflect the intended scarcity and strategic value of RTG generators.
143-151: MercGas Bounty Tweak
ThePirateBountyMercGasentry now sets the amount to 2. Please check that this alteration is balanced against the overall availability and strategic importance of the corresponding merc gas item.
152-160: RD Hardsuit Bounty Review
ThePirateBountyRDHardsuitentry appears unchanged. Confirm that it still meets balance expectations relative to other bounty rewards.
161-169: Deprecated MK58 Bounty
ThePirateBountyMK58bounty entry has been commented out. Verify that its deprecation is intentional and does not adversely affect any related game systems.
170-178: Artifact Analyzer Bounty
The entry forPirateBountyArtifactAnalyzerremains active with a reward of 4 and an amount of 2. Verify that this bounty continues to function as intended alongside the other revised entries.
179-188: Deprecated Hotplate Bounty
ThePirateBountyHotplateentry has been commented out. Confirm that this change is in line with the overall rebalancing strategy and that no residual dependencies remain.
189-198: Deep Fryer Bounty Revision
ThePirateBountyDeepFryernow offers a reward of 5 and an amount of 2. Verify that this change correctly mirrors the intended value of the KitchenDeepFryer within bounty rewards.
199-207: Deprecated Key Common Bounty
The bounty entry forPirateBountyKeyCommonis commented out. Confirm that this removal is expected and that any necessary fallbacks or replacements are in place.
209-217: Deprecated MedicalFabBoard Bounty
ThePirateBountyMedicalFabBoardentry has been removed via commenting. Please ensure its deprecation is consistent with current design goals.
218-226: Hypo Bounty Adjustment
ThePirateBountyHypobounty now retains a reward of 3. Confirm that this setting provides the proper interplay between item rarity and overall bounty difficulty.
227-236: Ore Box Bounty Update
ThePirateBountyOreBoxentry remains with a reward of 3 and an amount of 2. This appears consistent; however, double-check that the spawnChest parameter (if applicable) continues to behave as expected.
237-246: Autolathe Bounty Update
ThePirateBountyAutolathebounty now specifies a reward of 5 with spawnChest disabled. Verify that this implementation aligns with the intended scarcity and challenge for obtaining an Autolathe.
247-255: Diamond Bounty Consistency
ThePirateBountyDiamondentry maintains a reward of 4 with a requirement of 10 diamonds. Please validate that these numbers are consistent with overall resource distributions in the game.
256-264: Gold Bounty Check
ThePirateBountyGoldbounty now expects 100 units of Gold for a reward of 4. Confirm that this high quantity is balanced within the in-game economy and remains appropriately challenging to achieve.
265-274: Plasma Canister Bounty Update
ThePirateBountyPlasmaCanisterentry has its amount reduced to 1 (per #CorvaxFrontier). Verify that this decrease correctly reflects a reduced supply or increased rarity, as intended by the balance changes.
275-284: Contraband Crate Bounty Review
With a reward of 8 (a bonus of 2 doubloons compared to individual turn-ins), ensure that thePirateBountyContraCrateentry is correctly balanced with respect to its challenging acquisition conditions.
285-294: Deprecated HydroTray Bounty
ThePirateBountyHydroTrayentry has been commented out. Confirm that this removal fits within the overall bounty restructuring and that no dependent logic remains unresolved.
295-304: Enforcer Bounty Addition
A new bounty—PirateBountyEnforcer—has been introduced with a reward of 3 and an amount of 1. Please verify that this new entry is well balanced and that its in-game impact (both in terms of rarity and reward) is as designed.
315-323: Drink Soda Water Can Bounty Addition
A new bounty entry for a soda water can (reward 3, amount 2) has been added. Verify that the bilingual label (e.g. “Банка Содовой #Газированная вода”) is correctly processed and that item properties match gameplay requirements.
324-333: Suit Storage Base Bounty Addition
ThePirateBountySuitStorageBaseentry now offers a reward of 5 with a required amount of 3, and spawnChest is disabled. Confirm that this new bounty integrates with ship inventory systems and is balanced relative to other rewards.
334-342: Plushie Moff Random Bounty Addition
A new bounty forPlushieMoffRandomis added with a reward of 4 and an amount of 4. Given the potential impact on item rarity and aesthetic value, please verify that this entry supports the intended gameplay dynamics.
343-351: Bedsheet Syndie Bounty Addition
The bounty forBedsheetSyndienow appears with a reward of 3 and an amount of 1. Ensure that the new entry (with its unique theme) is visually and functionally integrated as intended in pirate balance updates.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 351-351: trailing spaces
(trailing-spaces)
305-314:❓ Verification inconclusive
Kitchen Microwave Bounty Addition
The newPirateBountyKitchenMicrowaveentry provides a reward of 5 with an amount of 2. This addition should further diversify bounty offerings—please check that its implementation and item reference (KitchenMicrowave) work as expected.
🏁 Script executed:
#!/bin/bash # Search for all occurrences of the "KitchenMicrowave" item reference in the repository. rg "KitchenMicrowave" -n .Length of output: 9228
Kitchen Microwave Bounty Addition Verification
The new bounty entry (
PirateBountyKitchenMicrowave) correctly specifies a reward of 5 with an amount of 2, and the item reference (KitchenMicrowave) is consistently used throughout the repository (as confirmed by multiple references in various configuration files). Please ensure during testing that the in-game behavior (item spawning, interactions, etc.) aligns with the intended functionality. Additionally, verify that any related refactor suggestions are applied where necessary.Resources/Maps/Corvax/Shuttles/BlackMarket/falcon.yml (4)
503-507: New Entity Addition: UID 399 for AtmosFixBlockerMarker
A new entity withuid: 399has been introduced under the appropriate proto with a Transform component set at position(-4.5,-18.5)and parent3. Please verify that the marker’s placement is intentional and aligns with the overall level design requirements for pirate shuttles.
1827-1833: Modified Defibrillator Cabinet Prototype
The prototype formerly known asDefibrillatorCabinetFilledhas been replaced withDefibrillatorCabinetOpen. In addition, the Transform’s rotation has been changed from a positive value (likely previously1.5707963267948966 rad) to-1.5707963267948966 rad. Please verify that this change reflects the desired real-world orientation and that the cabinet’s interaction area remains correct within the game environment.
2874-2893: Renamed Prototype: PoweredlightCyan
The entity formerly referenced asPoweredlightColoredFrostyBluehas been renamed toPoweredlightCyanand its configuration has been updated accordingly. Ensure that this new naming convention is applied consistently across the entire codebase (and related configuration files) and that the visual/light properties of this entity match the updated design expectations.
3825-3831: Updated Warp Point Prototype
The prototype has been updated fromWarpPointShiptoWarpPointwith a corresponding Transform position of(2.5,-11.5)and parent3. Please check that this renaming and its associated configuration are consistently propagated in all related files and do not disrupt any functionality related to shuttle linking or teleportation mechanics.Resources/Maps/Corvax/Shuttles/BlackMarket/schooner.yml (12)
431-436: Tilemap Value Updates
The tile IDs in the GridAtmosphere section have been updated (e.g. coordinate 0,0 now uses 65358 and 0,-1 now uses 58623). Please verify that these numerical IDs correctly correspond to the intended new textures and gameplay design.Also applies to: 452-456
544-557: New AirAlarm Prototype Addition
A new prototype “AirAlarm” with UID 642 has been introduced. The entity’s transform (position 1.5,–1.5) and attached DeviceList (devices 239, 236, 240, 242) look reasonable. Please double‐check that these device IDs match the updated device configurations and that the new transformation aligns with shuttle layout expectations.
568-579: New AirlockGlassShuttleSyndicate Prototype Addition
The prototype “AirlockGlassShuttleSyndicate” (UID 555 and 556) has been added with positions at –0.5,–9.5 and 1.5,–9.5 respectively. Confirm that these placements are consistent with the overall layout of the BlackMarket shuttle and that any references to this prototype in related maps (e.g. SalvationUnion.yml) have been updated accordingly.
580-597: New AirlockHatch Prototype Addition
A new “AirlockHatch” prototype is introduced with four entities (UIDs 356, 358, 401, and 402) at distinct positions. Please review these transforms to ensure that the multiple hatches provide the intended access and traffic flow in the shuttle design.
602-648: Removal of Legacy UI/Control Prototypes
The prototypes “APCBasic” and “AtmosDeviceFanDirectional” have been removed. These components likely affected in-game consoles and device interfaces. Make sure that any external references—such as in script calls or dependent maps—are updated and that the removal does not leave dangling dependencies.
1129-1170: Removal of ButtonFrame Prototypes
Several ButtonFrame prototypes (e.g. ButtonFrameCaution, ButtonFrameCautionSecurity, and ButtonFrameExit) have been removed. Verify that these removals align with the updated pirate UI elements and that no remaining missions or interactions depend on the removed prototypes.
1172-1228: Removal of CableApcExtension Prototype
The “CableApcExtension” prototype (with entities uid: 28–37) has been removed. Please confirm that this change is consistent with the intended removal of obsolete cable assets and that there are no remaining references within the map or related gameplay mechanics.
971-1039: BlastDoor Prototype Update
The “BlastDoor” prototype has been (re)introduced or updated with a set of entities (e.g. uid 159, 336–343) featuring specific rotation and position values. Ensure that the transforms (including the –1.5708 and 1.5708 rad rotations) properly reflect the new design parameters for door interactions and that collision/physics behaviors are recalibrated if necessary.
1046-1118: BlastDoorOpen Prototype Update
Similarly, the “BlastDoorOpen” prototype now includes several entities (uids 557–568) with adjusted transforms. Double-check that the opening/closing animations (implied by the transform rotations) are in sync with the gameplay logic and that the revised positions do not conflict with adjacent map elements.
1835-1866: CannonBallGrapeshot Prototype Modification
The “CannonBallGrapeshot” prototype (UIDs 160, 161, 571, 572, 573, and 574) shows updated transform positions. These changes appear targeted toward balancing projectile mechanics. Please verify that the new positions and rotations are consistent with the physics calculations in-game and that they align with the design intentions for the updated pirate ship armaments.
1867-1904: Removal of CarpetBlack Prototype
The “CarpetBlack” prototype has been removed (entities with uids 162–170). Confirm that decorative assets like these are no longer needed for the updated aesthetic of the pirate environment and that this removal does not affect any scheduled decorative placements in the level design.
1904-4399:❓ Verification inconclusive
Bulk Prototype Removals and Additions
A large number of prototypes—including various furniture items, cables, clothing items, device frames, signage, and many other world objects—have been removed or significantly updated throughout the file. This extensive cleanup appears to align with the new pirate balance changes (e.g. removal of obsolete items and introduction of new thematic equipment such as the Pirate Code).Before merging, please ensure:
• All removed prototypes are not referenced in other maps or game logic (avoid dangling references).
• New prototypes have been thoroughly play-tested to verify their functionality and visual integration.
• The overall balance and thematic consistency of the pirate elements have been validated against the design objectives.
Action Required: Verify Prototype Cleanup Impact
The changes in this file represent a major cleanup—removing obsolete prototypes and introducing new pirate-themed equipment (e.g., the Pirate Code) that align with recent balance updates. Before merging, please verify that:
• All removed or altered prototypes aren’t referenced elsewhere (to avoid dangling references).
• New prototypes have been appropriately play-tested for functionality and visual consistency.
• The overall thematic integration and game balance meet the design objectives.Please double-check related maps and game logic for any residual dependencies.
| - proto: ButtonFrameCaution | ||
| entities: | ||
| - uid: 261 | ||
| components: | ||
| - type: Transform | ||
| rot: -1.5707963267948966 rad | ||
| pos: 1.5,1.5 | ||
| parent: 201 | ||
| - proto: ButtonFrameCautionSecurity |
There was a problem hiding this comment.
🛠️ Refactor suggestion
❓ Verification inconclusive
ButtonFrameCaution Prototype Added
A new ButtonFrameCaution prototype (uid 261) has been introduced with a rotation of -1.5708 rad and position (1.5,1.5). Please verify that its behavior—including any linked interactions—is correct and aligns with the revised gameplay mechanics for pirate elements.
🏁 Script executed:
#!/bin/bash
# Search for occurrences of ButtonFrameCaution and ButtonFrameCautionSecurity in the repository
rg "proto: ButtonFrameCaution" --color=always .
rg "proto: ButtonFrameCautionSecurity" --color=always .Length of output: 31459
Action Required: Confirm Behavior of New ButtonFrameCaution Prototype
The new ButtonFrameCaution prototype introduced in Resources/Maps/Corvax/Shuttles/BlackMarket/barnacle.yml (lines 358–366) creates an instance (uid 261) with a rotation of –1.5708 rad and position (1.5,1.5). As similar configurations appear throughout the codebase—often paired with a corresponding ButtonFrameCautionSecurity instance—please verify that:
- The transform values and positioning produce the expected in-game behavior.
- Any linked interactions or dependencies are correctly updated to align with the revised pirate gameplay mechanics.
- Consistency is maintained with how these prototypes function in similar contexts across other maps.
| entities: | ||
| - uid: 238 | ||
| components: | ||
| - type: Transform | ||
| pos: 0.5,3.5 | ||
| parent: 201 | ||
| - proto: CableApcExtension |
There was a problem hiding this comment.
🛠️ Refactor suggestion
❓ Verification inconclusive
ButtonFrameCautionSecurity Prototype Added
The ButtonFrameCautionSecurity entity (uid 238) now appears with a Transform component at (0.5,3.5). As security-related functionalities are critical in balancing player interactions, please ensure this prototype is correctly referenced and functions as intended.
Below is a shell script to extract the relevant snippet from the file and to search the repository for any references to the new prototype name. This will help verify that the change to introduce the ButtonFrameCautionSecurity entity (uid 238) is correctly applied and that the removal of the old prototype (proto: CableApcExtension) has been intentional.
Once these commands run, please review:
- That the file snippet shows the expected Transform component with
pos: 0.5,3.5under uid 238 and that any removal ofproto: CableApcExtensionis deliberate. - That the new prototype identifier (
ButtonFrameCautionSecurity) is properly referenced somewhere if it’s meant to be used beyond this file.
Action: Verify Prototype Integration and Consistency
- Confirm that the entity with uid 238 is now intended to use the new security-related prototype.
- Double-check that no outdated references to
CableApcExtensionremain.
🏁 Script executed:
#!/bin/bash
set -e
echo "Fetching snippet from Resources/Maps/Corvax/Shuttles/BlackMarket/barnacle.yml (lines 360-380):"
sed -n '360,380p' Resources/Maps/Corvax/Shuttles/BlackMarket/barnacle.yml
echo ""
echo "Searching for any references to 'ButtonFrameCautionSecurity' in the repository:"
rg "ButtonFrameCautionSecurity" -n .Length of output: 8449
Security Prototype Integration Verification
The updated file now groups the entity with uid 238 under the new ButtonFrameCautionSecurity prototype—with its Transform component specified at (0.5,3.5)—while a separate block still uses the CableApcExtension prototype. Please verify that:
- The entity with uid 238 is intended to be handled by the new ButtonFrameCautionSecurity prototype.
- The coexistence of both prototypes in the file (and throughout the repository) is deliberate and that any dependencies on
CableApcExtensionfor other entities remain valid. - All security-related functionality associated with the ButtonFrameCautionSecurity prototype has been correctly integrated and tested.
github-actions
bot
added
size/M
FTL
C#
UI
Map-Dungeon
Map-Outpost
Map-Shuttle
Docs
Audio
DB Migration
size/XL
S: Merge Conflict
and removed
size/XL
size/M
labels
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Общие изменения пиратов:
Изменения аплинка пиратов:
Изменения бухты:
Изменение меты шаттлов:
Сэндвич:
Моряк:
Месть Королевы Анны:
Полюс:
Предъява:
Союз Спасения:
Шхуна:
Боров:
Добавлены новые суда:
Цинга:
(автор: alexmactep)
Прочие изменения:
1.Книги КЗ и СРП теперь ведут на вики проекта Corvax Frontier.
2.Продвинутые Сканеры массы на шаттлах дсбф больше нельзя открутить или разобрать, с части шаттлов консоль вовсе удалена.
3.Обновлён шаттл Квазар. Последний получил лицензию и исправлен ряд конструкционных ошибок.
4.Удалена возможность получения любого ховербайка в игре не прибегая к щитспавну.
(за помощь в работе над ПРом спасибо многоуважаемому terrafrog)
Media
Summary by CodeRabbit
New Features
Refactor
Chores