Пачка ftl и крошка фикса #168
Conversation
WalkthroughThis pull request updates a server-side configuration by increasing the maximum number of simultaneous storage windows from 2 to 3. It also adds multiple new Russian localization entries across various files for chat emotes, bounty contracts, escape menu options, and uplink catalog items. These changes adjust configuration values and expand localization support for enhanced UI text and in-game interactions. Changes
Suggested labels
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (6)
⏰ Context from checks skipped due to timeout of 90000ms (5)
🔇 Additional comments (9)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @percent-temp-percent, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request primarily focuses on Russian localization updates and a minor gameplay tweak. Specifically, it increases the maximum number of simultaneously opened storage windows from two to three and introduces/updates several Russian translations for emotes, bounty contracts, options menu items, and uplink store items.
Highlights
- Storage Limit Increase: The maximum number of simultaneously opened storage windows has been increased from 2 to 3, controlled by the
control.storage_limitCVar. - New Emotes: Adds new emotes (spin, jump, bubble, pop, crack, reptilian-hiss) with corresponding names and messages in Russian.
- Bounty Contract Localization: Expands Russian localization for bounty contract related texts, including author information, radio announcements, UI elements, and error messages.
- Options Menu Localization: Adds Russian localization for new options menu items, including AHelp sound and speech bubble opacity settings.
- Uplink Store Localization: Adds Russian localization for new uplink store items, including 'Combat Bakery' and 'Fake Mindshield'.
Changelog
Click here to see the changelog
- Content.Shared/CCVar/CCVars.Interactions.cs
- Increased the
StorageLimitCVar default value from 2 to 3.
- Increased the
- Resources/Locale/ru-RU/_Goobstation/emotes.ftl
- Added localization for 'spin' and 'jump' emotes.
- Resources/Locale/ru-RU/_Impstation/chat/emotes.ftl
- Added localization for 'bubble', 'pop', 'crack', and 'reptilian-hiss' emotes.
- Resources/Locale/ru-RU/_NF/bounty-contracts/bounty-contracts.ftl
- Added localization for bounty contract author without a job.
- Added localization for bounty contract announcements and collection names.
- Added localization for bounty contract UI elements (loading, unknown author).
- Added localization for bounty contract creation error messages (name, vessel, description too long).
- Resources/Locale/ru-RU/escape-menu/ui/options-menu.ftl
- Added localization for AHelp sound option.
- Added localization for classic antagonist overlay and speech bubble opacity settings.
- Resources/Locale/ru-RU/store/uplink-catalog.ftl
- Added localization for 'Combat Bakery' and 'Fake Mindshield' uplink items.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
The Cyrillic alphabet, used for the Russian language, was developed in the First Bulgarian Empire during the 9th-10th centuries AD, based on the Greek uncial script.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request includes an increase in the storage limit and several localization updates. The changes seem straightforward, but it's important to ensure that the increased storage limit doesn't negatively impact performance or game balance. The localization updates should also be verified for accuracy and consistency.
Summary of Findings
- Increased Storage Limit: The storage limit has been increased from 2 to 3. Ensure this change is thoroughly tested and doesn't introduce any unexpected issues with the game's balance or performance.
- Localization Updates: Several new localization strings have been added for emotes, bounty contracts, and UI elements. Verify that these translations are accurate and fit within the game's context.
Merge Readiness
The pull request appears to be in good shape for merging, but it's recommended to thoroughly test the increased storage limit and verify the accuracy of the localization updates before merging. I am unable to approve the pull request in any circumstance, and users should have others review and approve this code before merging.
Максимальное количество одновременно открытых окон хранилищ увеличено с двух до 3-х.
Summary by CodeRabbit