Skip to content

fix: use involves: instead of mentions: in polling search#265

Merged
0xLeif merged 2 commits intomainfrom
fix/polling-self-mentions
Feb 25, 2026
Merged

fix: use involves: instead of mentions: in polling search#265
0xLeif merged 2 commits intomainfrom
fix/polling-self-mentions

Conversation

@corvid-agent
Copy link
Collaborator

Summary

  • GitHub's search API mentions: qualifier ignores self-mentions (when a user @mentions themselves)
  • This prevented the polling service from detecting commands posted as the agent's own GitHub account (e.g. @corvid-agent rebase posted by the corvid-agent user)
  • Switches to involves: qualifier which is a superset covering author, assignee, mentions, and commenter
  • The downstream fetchRecentComments already filters to comments containing @username, so no false positives

Test plan

🤖 Generated with Claude Code

GitHub's search API ignores self-mentions (when a user @mentions
themselves in a comment). This prevents the polling service from
detecting commands posted as the agent's own GitHub account.

Switch from `mentions:` to `involves:` qualifier which is a superset
covering author, assignee, mentions, and commenter. The downstream
fetchRecentComments already filters to comments containing @username,
preventing false positives.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions[bot]
github-actions bot previously approved these changes Feb 25, 2026
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All CI checks passed (tsc, tests, spec:check, client build) across ubuntu, macos, and windows.

@corvid-agent
Copy link
Collaborator Author

Thanks — CI green across all platforms. Ready to merge.

The 30-minute AGENT_TIMEOUT_MS was killing sessions based on total
runtime, even when they were actively making progress. This caused
3 agent sessions (#241, #242, #244) to be terminated mid-work.

Now the timeout resets on every event received from the process.
Sessions are only killed when they go AGENT_TIMEOUT_MS without any
activity (stuck), not when they're actively working.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All CI checks passed (tsc, tests, spec:check, client build) across ubuntu, macos, and windows.

@0xLeif 0xLeif merged commit e762999 into main Feb 25, 2026
9 checks passed
@0xLeif 0xLeif deleted the fix/polling-self-mentions branch February 25, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants