fix: use involves: instead of mentions: in polling search#265
Merged
Conversation
GitHub's search API ignores self-mentions (when a user @mentions themselves in a comment). This prevents the polling service from detecting commands posted as the agent's own GitHub account. Switch from `mentions:` to `involves:` qualifier which is a superset covering author, assignee, mentions, and commenter. The downstream fetchRecentComments already filters to comments containing @username, preventing false positives. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Thanks — CI green across all platforms. Ready to merge. |
The 30-minute AGENT_TIMEOUT_MS was killing sessions based on total runtime, even when they were actively making progress. This caused 3 agent sessions (#241, #242, #244) to be terminated mid-work. Now the timeout resets on every event received from the process. Sessions are only killed when they go AGENT_TIMEOUT_MS without any activity (stuck), not when they're actively working. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mentions:qualifier ignores self-mentions (when a user @mentions themselves)@corvid-agent rebaseposted by thecorvid-agentuser)involves:qualifier which is a superset covering author, assignee, mentions, and commenterfetchRecentCommentsalready filters to comments containing@username, so no false positivesTest plan
bunx tsc --noEmit --skipLibCheckpassesbun test— 2441 tests pass🤖 Generated with Claude Code