Skip to content

Fix: pluralize doctor working-tree file count correctly - #457

Merged
0xLeif merged 1 commit into
mainfrom
fix/453-doctor-plural
Jul 2, 2026
Merged

Fix: pluralize doctor working-tree file count correctly#457
0xLeif merged 1 commit into
mainfrom
fix/453-doctor-plural

Conversation

@0xLeif

@0xLeif 0xLeif commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • fledge doctor previously always printed "uncommitted changes (N files)", so a single change read as "(1 files)".
  • The working-tree check now selects the singular noun ("file") when exactly one file changed and the plural ("files") otherwise.

Test Plan

  • cargo fmt
  • cargo build
  • cargo clippy --bin fledge -- -D warnings (clean)
  • cargo test --bin fledge doctor (9 passed)

πŸ€– Generated with Claude Code

Closes #453

https://claude.ai/code/session_016AvsKakjAc3EKN2ztcMfYi

`fledge doctor` printed "uncommitted changes (1 files)". Use the
singular "file" when the count is 1 and "files" otherwise.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016AvsKakjAc3EKN2ztcMfYi
@0xLeif
0xLeif requested a review from a team as a code owner July 2, 2026 15:05
@0xLeif
0xLeif requested review from 0xGaspar, Kyntrin and tofu-ux July 2, 2026 15:05

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the git check in src/doctor.rs to correctly pluralize the word 'file' based on the number of uncommitted changes. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@0xGaspar 0xGaspar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct singular/plural fix. count == 1 guard is right and the inline-captured format args are tidy. LGTM.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

βœ… Corvin says...

      _
    <(^\  .oO(Caw! ^v^)
     |/(\
      \(\\
      " "\\

"Caw! Found a shiny new spec!"

CI Summary

Check Status
Dependency Audit βœ… Passed
Integration (3 OS) βœ… Passed
Lint (fmt + clippy) βœ… Passed
Spec Validation βœ… Passed
Tests (3 OS) βœ… Passed

Powered by corvid-pet

@0xLeif
0xLeif merged commit 7f3f858 into main Jul 2, 2026
13 checks passed
@0xLeif
0xLeif deleted the fix/453-doctor-plural branch July 2, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doctor: pluralize 'uncommitted changes (1 files)'

2 participants