Add: trailing success confirmation with elapsed time to fledge run (human output) - #458
Conversation
…(human output) The human (non-JSON) path of `fledge run <task>` previously printed only "▶️ Running task: <name>" with no completion signal. Add a trailing "✅ <task> (0.3s)" line timed with std::time::Instant around the command run. Only the human path changes; the --json run_task envelope is untouched and stays byte-identical. Closes #455 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AvsKakjAc3EKN2ztcMfYi
There was a problem hiding this comment.
Code Review
This pull request modifies src/run.rs to track and print the execution duration of tasks. It captures the start time using std::time::Instant::now(), calculates the elapsed time after the task command completes, and prints a success message with the duration in seconds. There are no review comments, and we have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
0xGaspar
left a comment
There was a problem hiding this comment.
Clean addition — Instant wraps only .status(), the line prints only after the success check (a failing task still bails first), and the --json envelope is untouched so snapshots stay byte-identical. LGTM.
There was a problem hiding this comment.
✅ Corvin says...
_
<(^\ .oO(Caw! ^v^)
|/(\
\(\\
" "\\
"Caw! Your code sparkles like a dropped french fry."
CI Summary
| Check | Status |
|---|---|
| Dependency Audit | ✅ Passed |
| Integration (3 OS) | ✅ Passed |
| Lint (fmt + clippy) | ✅ Passed |
| Spec Validation | ✅ Passed |
| Tests (3 OS) | ✅ Passed |
Powered by corvid-pet
Summary
fledge run <task>previously printed only▶️ Running task: <name>with no completion signal.✅ <task> (0.Ns)line, timed withstd::time::Instantaround the command's.status()call, printed only on success (a failing task still bails before the line, as before).execute_task(src/run.rs) changes. The--jsonrun_taskenvelope is untouched and stays byte-identical, so its tests/snapshots remain green.Test Plan
cargo fmt --checkcleancargo clippy --bin fledge -- -D warningscleancargo test --bin fledge run(72 passed)cargo test --test run(20 passed, incl.cli_run_task_json_emits_envelope)✅ hello (0.0s)line;--jsonoutput shows the unchanged 8-key envelope with no extra line🤖 Generated with Claude Code
Closes #455
https://claude.ai/code/session_016AvsKakjAc3EKN2ztcMfYi