Skip to content

Add: trailing success confirmation with elapsed time to fledge run (human output) - #458

Merged
0xLeif merged 1 commit into
mainfrom
fix/455-run-confirm
Jul 2, 2026
Merged

Add: trailing success confirmation with elapsed time to fledge run (human output)#458
0xLeif merged 1 commit into
mainfrom
fix/455-run-confirm

Conversation

@0xLeif

@0xLeif 0xLeif commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The human (non-JSON) path of fledge run <task> previously printed only ▶️ Running task: <name> with no completion signal.
  • Adds a trailing ✅ <task> (0.Ns) line, timed with std::time::Instant around the command's .status() call, printed only on success (a failing task still bails before the line, as before).
  • Only the human path in execute_task (src/run.rs) changes. The --json run_task envelope is untouched and stays byte-identical, so its tests/snapshots remain green.

Test Plan

  • cargo fmt --check clean
  • cargo clippy --bin fledge -- -D warnings clean
  • cargo test --bin fledge run (72 passed)
  • cargo test --test run (20 passed, incl. cli_run_task_json_emits_envelope)
  • Manual smoke test: human output shows the new ✅ hello (0.0s) line; --json output shows the unchanged 8-key envelope with no extra line

🤖 Generated with Claude Code

Closes #455

https://claude.ai/code/session_016AvsKakjAc3EKN2ztcMfYi

…(human output)

The human (non-JSON) path of `fledge run <task>` previously printed only
"▶️ Running task: <name>" with no completion signal. Add a trailing
"✅ <task> (0.3s)" line timed with std::time::Instant around the command
run. Only the human path changes; the --json run_task envelope is
untouched and stays byte-identical.

Closes #455

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016AvsKakjAc3EKN2ztcMfYi
@0xLeif
0xLeif requested a review from a team as a code owner July 2, 2026 15:05
@0xLeif
0xLeif requested review from 0xGaspar, Kyntrin and tofu-ux July 2, 2026 15:05

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies src/run.rs to track and print the execution duration of tasks. It captures the start time using std::time::Instant::now(), calculates the elapsed time after the task command completes, and prints a success message with the duration in seconds. There are no review comments, and we have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@0xGaspar 0xGaspar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean addition — Instant wraps only .status(), the line prints only after the success check (a failing task still bails first), and the --json envelope is untouched so snapshots stay byte-identical. LGTM.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Corvin says...

      _
    <(^\  .oO(Caw! ^v^)
     |/(\
      \(\\
      " "\\

"Caw! Your code sparkles like a dropped french fry."

CI Summary

Check Status
Dependency Audit ✅ Passed
Integration (3 OS) ✅ Passed
Lint (fmt + clippy) ✅ Passed
Spec Validation ✅ Passed
Tests (3 OS) ✅ Passed

Powered by corvid-pet

@0xLeif
0xLeif merged commit edac3a9 into main Jul 2, 2026
13 checks passed
@0xLeif
0xLeif deleted the fix/455-run-confirm branch July 2, 2026 15:48
@0xLeif 0xLeif mentioned this pull request Jul 3, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

run: confirm completion of a passing task (human output)

2 participants