Update: enforce Cargo.lock in CI with --locked - #459
Merged
Conversation
Now that Cargo.lock is committed (#436), add --locked to the cargo build/test invocations in ci.yml and release.yml so CI fails if the lockfile is stale or drifts. Leaves the audit job's own generate-lockfile step untouched. Closes #450 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AvsKakjAc3EKN2ztcMfYi
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
0xGaspar
approved these changes
Jul 2, 2026
0xGaspar
left a comment
0xGaspar
left a comment
Contributor
There was a problem hiding this comment.
Right call now that Cargo.lock is committed — --locked makes a stale lockfile fail loudly. Good judgment leaving audit alone (rustsec regenerates its own lockfile) and skipping fmt/clippy where it's a no-op. LGTM.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Corvin says...
_
<(^\ .oO(Caw! ^v^)
|/(\
\(\\
" "\\
"That's a nice looking export you've got there."
CI Summary
| Check | Status |
|---|---|
| Dependency Audit | ✅ Passed |
| Integration (3 OS) | ✅ Passed |
| Lint (fmt + clippy) | ✅ Passed |
| Spec Validation | ✅ Passed |
| Tests (3 OS) | ✅ Passed |
Powered by corvid-pet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cargo.lockis committed (Fix: bump wasmtime to 46.0.1 (RUSTSEC-2026-0188) + commit Cargo.lock (H-6) #436), make CI enforce it by adding--lockedto the cargo build/test invocations..github/workflows/ci.yml:cargo test --verbose --locked(test job) andcargo build --release --locked(integration job)..github/workflows/release.yml:cargo test --verbose --locked(test gate) andcargo build --release --target ... --locked(both cross and native build steps).auditjob (rustsec/audit-check manages its own lockfile viacargo generate-lockfile) andcargo fmt/cargo clippysteps.Closes #450
Test Plan
yaml.safe_loadon both files).--lockedon the PR; a staleCargo.lockwould now fail the build/test steps.https://claude.ai/code/session_016AvsKakjAc3EKN2ztcMfYi