Fix empty string encoding in AssetCreateTransaction #3
Conversation
Empty strings for url, unitName, and assetName were being encoded as "au": "", "un": "", "an": "" in MessagePack instead of being omitted. Algorand's canonical encoding requires empty/default values to be omitted entirely, causing signature verification failures. Added !isEmpty checks to properly omit empty strings from encoding.
0xLeif
force-pushed
the
fix/empty-string-encoding
branch
from
092bd34 to
7713013
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical encoding bug in AssetCreateTransaction where empty strings for optional asset parameters were being included in the MessagePack encoding instead of being omitted. Algorand's canonical encoding requires empty/default values to be entirely omitted, and the presence of empty string fields was causing signature verification failures.
- Added
!isEmptychecks to conditionally omit empty strings from encoding - Applied the fix to all three optional string fields:
unitName,assetName, andurl
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if let unitName = assetParams.unitName, !unitName.isEmpty { | ||
| apar["un"] = .string(unitName) | ||
| } | ||
| if let assetName = assetParams.assetName { | ||
| if let assetName = assetParams.assetName, !assetName.isEmpty { | ||
| apar["an"] = .string(assetName) | ||
| } | ||
| if let url = assetParams.url { | ||
| if let url = assetParams.url, !url.isEmpty { | ||
| apar["au"] = .string(url) | ||
| } |
There was a problem hiding this comment.
The new behavior for empty strings (unitName, assetName, url) should be covered by tests. Consider adding a test case that creates an AssetCreateTransaction with empty strings for these optional fields and verifies they are properly omitted from the encoded output.
Empty strings for url, unitName, and assetName were being encoded as "au": "", "un": "", "an": "" in MessagePack instead of being omitted. Algorand's canonical encoding requires empty/default values to be omitted entirely, causing signature verification failures.
Added !isEmpty checks to properly omit empty strings from encoding.