Clarify documentation and complete BitVec reconstruction - #96
Merged
dollspace-gay merged 3 commits intoJul 29, 2026
Conversation
dollspace-gay
marked this pull request as ready for review
July 29, 2026 06:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
BitVec Nreconstruction surface for wrapping arithmetic, unsigned comparisons, bitwise operations, shifts, division, remainder, casts, and boolean connectivesbvudiv-by-zero behavior explicitly because LeanBitVecdivision uses a different defaultBitVec.eq_eq_beqsorryThermite/SmtExport.leanfixtures and trust documentationWhy
The repository had accumulated dense, repetitive comments and documentation that obscured the actual invariants. The QF_BV exporter also covered only an arithmetic/comparison subset, leaving bitwise, shift, division, and remainder clauses solver-trusted. The pinned lean-smt revision additionally emitted a compiled
sorrywarning from its BitVec reconstruction module.Thermite now handles its complete QF_BV term surface through direct literal
BitVec Nnormalization proofs. This avoids relying on lean-smt's broader, still-partial bit-blast reconstructor and keeps the generated proof terms within the project's Lean axiom allowlist.Impact
declaration uses sorrywarningsorryoradmitdeclarations{propext, Classical.choice, Quot.sound}Validation
cargo test --workspace --no-fail-fastcargo test -p forge --bin forge --no-fail-fast— 468 passedcargo test -p forge --test g1_gate --test metrics_dashboard --features bv --test bv_lowering -- --nocapture— live Z3-backed suites passed, including 16/16 BitVec testscargo test -p thermite-lower --test l2_conformance -- --nocapture— 7/7 live Kani tests passedcargo test -p forge --test l2_check --test degrade_conformance -- --nocapturelake build— 1120 jobs, nosorrywarningbash scripts/lean-axiom-probe.sh— all 11 theorem probes passedpython3 -m unittest discover -s tooling/tests -p 'test_*.py'— 46 passedcargo fmt --checkgit diff --check