Skip to content

Filesys#338

Open
christianrouhana wants to merge 56 commits intomasterfrom
FILESYS
Open

Filesys#338
christianrouhana wants to merge 56 commits intomasterfrom
FILESYS

Conversation

@christianrouhana
Copy link

Initialized FATFileSystem in CougSat1-Software/CougSat1-IHU/src/main.cpp
Included test code in /CougSat1-IHU/test/FATFileSystem

Copy link

@james-ponce james-ponce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In FileSystem/SatFileHandler.cpp move the three #include under SatFileHandler.h into SatFileHandler.h

Remove FileSystem/main.cpp as to not confuse others trying to use it as the FileSystem files should be the files for the class

Copy link
Member

@WattsUp WattsUp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Your workspace is not setup. Follow the readme. There should not be 66 changed files. I count 5 or 6 that should actually be changed.

@arkennia
Copy link

arkennia commented Mar 12, 2020

Your workspace is not setup. Follow the readme. There should not be 66 changed files. I count 5 or 6 that should actually be changed.

@WattsUp

So part of the reason for that is that I had accidentally added a bunch of doxygen files into it, which are now deleted. I fixed the gitignore.

Now the reason it may appear different than some others is that I had to use mbed cli because I couldn't get platformio to work on my machine. To get it to compile I had to copy files into the include directory, which account for some more of the "changed" files. Really, they are just copied includes. Now if anyone were to take just that folder, it should compile using mbed. So how would you propose this be fixed? I can gitignore the include folder but then whenever someone clones the repo and tries to build the IHU they'll just have to copy them back.

Also the reason I am responding and not christian is that I am the one that wrote most of the code and restructured the directory.

@WattsUp
Copy link
Member

WattsUp commented Mar 13, 2020

Platformio works. If you have the errors I can help fix. IF you really have to use mbed CLI then you need to setup it to use the CISLibrary, duplicating the files defeats the purpose of the library

@arkennia
Copy link

I fixed the include directory to just be a symlink. Seems to work now. No extra files. Well apart from the symlink. Once @christianrouhana accepts my pull request to the branch those changes will appear here @WattsUp . Does that work for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants