Skip to content

Reject unknown v2 API parameters#3414

Open
caydyan wants to merge 1 commit into
CounterpartyXCP:developfrom
caydyan:fix-unknown-api-params-2164
Open

Reject unknown v2 API parameters#3414
caydyan wants to merge 1 commit into
CounterpartyXCP:developfrom
caydyan:fix-unknown-api-params-2164

Conversation

@caydyan

@caydyan caydyan commented Jun 9, 2026

Copy link
Copy Markdown

Fixes #2164.

This is a develop-based replacement for #3367.

Summary:

  • Reject unrecognized v2 API query parameters before route arguments are coerced.
  • Reuse the parsed request query parameters while preparing route args.
  • Keep allowed parameters such as verbose working.
  • Add regression coverage for both unknown-parameter rejection and the allowed verbose path.

Tests:

  • .venv/bin/python -m pytest counterpartycore/test/units/api/apiserver_test.py -q
  • .venv/bin/python -m ruff check counterpartycore/lib/api/apiserver.py counterpartycore/test/units/api/apiserver_test.py
  • .venv/bin/python -m ruff format --check counterpartycore/lib/api/apiserver.py counterpartycore/test/units/api/apiserver_test.py
  • git diff --check

BTC payout address if this qualifies for a contributor/security reward: bc1qev5ant33v5y89qqjvcf4mh9hlax5svqf5xd7gc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant