Skip to content

Validate dust size parameters#3424

Open
caydyan wants to merge 1 commit into
CounterpartyXCP:developfrom
caydyan:fix-dust-size-param-validation-develop
Open

Validate dust size parameters#3424
caydyan wants to merge 1 commit into
CounterpartyXCP:developfrom
caydyan:fix-dust-size-param-validation-develop

Conversation

@caydyan

@caydyan caydyan commented Jun 10, 2026

Copy link
Copy Markdown

Supersedes #3382 with the same fix rebased onto the current develop branch.

Deprecated but still-active compose parameters regular_dust_size and multisig_dust_size accepted negative values. Those values are used directly when creating default destination/change/data outputs, so a negative dust size can become an invalid transaction output amount.

This PR rejects negative dust size overrides with a clear ComposeError.

Changes:

  • Rejects negative regular_dust_size.
  • Rejects negative multisig_dust_size.
  • Adds regression coverage for both parameters while preserving existing default and positive override behavior.

Tests:

  • python -m pytest counterpartycore/test/units/api/composer_test.py::test_dust_size -q
  • python -m pytest counterpartycore/test/units/api/composer_test.py -q
  • python -m ruff check counterpartycore/lib/api/composer.py counterpartycore/test/units/api/composer_test.py
  • python -m ruff format --check counterpartycore/lib/api/composer.py counterpartycore/test/units/api/composer_test.py
  • git diff --check

Bounty payment address (BTC): bc1qev5ant33v5y89qqjvcf4mh9hlax5svqf5xd7gc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant