Validate confirmation target#3426
Open
caydyan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #3384 with the same fix rebased onto the current
developbranch.prepare_fee_parameters()accepted anyconfirmation_targetvalue before passing it to Bitcoin Core fee estimation. The backend helper documents the valid range as 1 to 1008 blocks, but compose-time callers could pass 0, negative values, or values above 1008 and let the error surface later at the RPC layer.This PR validates the confirmation target before calling
estimatesmartfee.Changes:
MAX_CONFIRMATION_TARGET = 1008.confirmation_targetvalues below 1 or above 1008 when fee estimation will use the parameter.Tests:
python -m pytest counterpartycore/test/units/api/composer_test.py::test_prepare_fee_parameters -qpython -m pytest counterpartycore/test/units/api/composer_test.py -qpython -m ruff check counterpartycore/lib/api/composer.py counterpartycore/test/units/api/composer_test.pypython -m ruff format --check counterpartycore/lib/api/composer.py counterpartycore/test/units/api/composer_test.pygit diff --checkBounty payment address (BTC):
bc1qev5ant33v5y89qqjvcf4mh9hlax5svqf5xd7gc