Skip call price checks after callability parameter removal#3434
Open
caydyan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
issuance_callable_lock_fixprotocol change at the current 11.1.0 activation batchContext
This is a
develop-based replacement for the earliermasterPR:The earlier review confirmed the bug but requested a new future protocol gate to avoid a retroactive consensus change. This version keeps that gate and the activation boundary test on current
develop.Verification
/Users/cayd/Documents/btc/work/counterparty-core/counterparty-core/.venv/bin/python -m pytest counterpartycore/test/units/messages/issuance_test.py::test_validate -q/Users/cayd/Documents/btc/work/counterparty-core/counterparty-core/.venv/bin/python -m pytest counterpartycore/test/units/messages/issuance_test.py -q/Users/cayd/Documents/btc/work/counterparty-core/counterparty-core/.venv/bin/python -m ruff check counterpartycore/lib/messages/issuance.py counterpartycore/test/units/messages/issuance_test.py/Users/cayd/Documents/btc/work/counterparty-core/counterparty-core/.venv/bin/python -m ruff format --check counterpartycore/lib/messages/issuance.py counterpartycore/test/units/messages/issuance_test.py/Users/cayd/Documents/btc/work/counterparty-core/counterparty-core/.venv/bin/python -m json.tool counterpartycore/protocol_changes.jsongit diff --checkPayout
If this qualifies for a contributor or bug-fix reward, please send BTC to:
bc1qev5ant33v5y89qqjvcf4mh9hlax5svqf5xd7gc