Skip to content

feat: removed IDVF usage #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turtledreams merged 1 commit into from
Apr 16, 2025
Merged

feat: removed IDVF usage #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
## XX.XX.XX
* ! Minor breaking change ! Removed UIDevice.currentDevice.identifierForVendor usage in device id generation. The SDK now exclusively uses random UUIDs for device id generation.
* Added a Content feature method "refreshContentZone" that does a manual refresh.

## 25.1.2
Expand Down
4 changes: 0 additions & 4 deletions CountlyDeviceInfo.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,6 @@ - (NSString *)ensafeDeviceID:(NSString *)deviceID
if (deviceID.length)
return deviceID;

#if (TARGET_OS_IOS || TARGET_OS_VISION || TARGET_OS_TV)
return UIDevice.currentDevice.identifierForVendor.UUIDString;
#else
NSString* UUID = [CountlyPersistency.sharedInstance retrieveNSUUID];
if (!UUID)
{
Expand All @@ -118,7 +115,6 @@ - (NSString *)ensafeDeviceID:(NSString *)deviceID
}

return UUID;
#endif
}

- (BOOL)isDeviceIDTemporary
Expand Down
4 changes: 0 additions & 4 deletions CountlyTests/CountlyDeviceIDTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,17 +116,13 @@ class CountlyDeviceIDTests: CountlyBaseTestCase {
}

func getIDFV() -> String {
#if (os(iOS) || os(tvOS))
return UIDevice.current.identifierForVendor?.uuidString ?? ""
#else
var UUID = CountlyPersistency.sharedInstance().retrieveNSUUID()
if UUID == nil {
UUID = UUID().uuidString
CountlyPersistency.sharedInstance().storeNSUUID(UUID)
}

return UUID ?? ""
#endif
}

}
Expand Down