Skip to content

Commit be648fc

Browse files
authored
Merge pull request #6490 from Countly/anna/master
[core] handle switching to report manager for table
2 parents 84b74fd + 170dfc4 commit be648fc

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,12 @@ Fixes:
99
- [crashes] Fix free session for home widget
1010
- [crashes] Use na for free session and free user when there's no data
1111
- [crashes] Fix trend and change calculation for crash stats
12+
- [push] Show segmentation, geo and cohorts related components in push drawer on editing draft.
1213

1314
Enterprise Fixes:
1415
- [ldap] Error handling in ldap plugin on search error
1516
- [license] Display notification for non global admin user
17+
- [users] Load table data from report if user table calculation goes to report manager
1618

1719
Dependencies:
1820
- Bump puppeteer from 24.14.0 to 24.15.0

frontend/express/public/javascripts/countly/vue/data/vuex.js

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -274,14 +274,23 @@
274274
options.onOverrideResponse(context, res);
275275
}
276276
var convertedResponse = _dataTableAdapters.toStandardResponse(res, requestOptions);
277-
if (!Object.prototype.hasOwnProperty.call(convertedResponse, "echo") ||
278-
convertedResponse.echo >= context.state[echoField]) {
279-
if (typeof options.onReady === 'function') {
280-
convertedResponse.rows = options.onReady(context, convertedResponse.rows);
277+
if (res.task_id) {
278+
if (typeof options.onTask === 'function') {
279+
options.onTask(context, res.task_id);
281280
}
282281
context.commit(_capitalized("set", resourceName), convertedResponse);
283282
context.commit(_capitalized("set", lastSuccessfulRequestKey), requestOptions);
284283
}
284+
else {
285+
if (!Object.prototype.hasOwnProperty.call(convertedResponse, "echo") ||
286+
convertedResponse.echo >= context.state[echoField]) {
287+
if (typeof options.onReady === 'function') {
288+
convertedResponse.rows = options.onReady(context, convertedResponse.rows);
289+
}
290+
context.commit(_capitalized("set", resourceName), convertedResponse);
291+
context.commit(_capitalized("set", lastSuccessfulRequestKey), requestOptions);
292+
}
293+
}
285294
})
286295
.catch(function(err) {
287296
if (typeof options.onError === 'function') {

0 commit comments

Comments
 (0)