Skip to content

[SER-1922] add audit logs to hook create edit delete actions #5584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 2, 2024
Merged

[SER-1922] add audit logs to hook create edit delete actions #5584

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fd9b176
Added audit logs to hooks plugin
umtcntp Sep 19, 2024
30c52d3
audit logs
umtcntp Sep 30, 2024
6fb9266
deepscan issues
umtcntp Sep 30, 2024
5199ef6
eslint fixes
umtcntp Sep 30, 2024
399cb6f
hook audit logs update and create operations
umtcntp Sep 30, 2024
0c19291
back to first commit and run tests again
umtcntp Oct 1, 2024
bb2bcfd
Merge branch 'next' into SER-1922-add-audit-logs-to-hook-create-edit-…
ArtursKadikis Oct 2, 2024
2d1836e
Merge branch 'next' into SER-1922-add-audit-logs-to-hook-create-edit-…
ArtursKadikis Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions plugins/hooks/api/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,12 @@ plugins.register("/i/hook/save", function(ob) {
{new: true},
function(err, result) {
if (!err) {
// Audit log: Hook updated
plugins.dispatch("/systemlogs", {
params: params,
action: "hook_updated",
data: { updated: result.value }
});
common.returnOutput(params, result && result.value);
}
else {
Expand All @@ -318,6 +324,12 @@ plugins.register("/i/hook/save", function(ob) {
function(err, result) {
log.d("insert new hook:", err, result);
if (!err && result && result.insertedIds && result.insertedIds[0]) {
// Audit log: Hook created
plugins.dispatch("/systemlogs", {
params: params,
action: "hook_created",
data: { created: hookConfig }
});
common.returnOutput(params, result.insertedIds[0]);
}
else {
Expand Down Expand Up @@ -467,6 +479,12 @@ plugins.register("/o/hook/list", function(ob) {
const member = _.find(members, {_id: a.createdBy});
a.createdByUser = member && member.full_name;
});
// Audit log: Hook list viewed (without logging individual hooks)
plugins.dispatch("/systemlogs", {
params: params,
action: "hook_list_viewed",
data: { hookCount: hooksList.length, requestedBy: params.member._id }
});
common.returnOutput(params, { hooksList } || []);
});
});
Expand Down Expand Up @@ -514,6 +532,12 @@ plugins.register("/i/hook/status", function(ob) {
}
Promise.all(batch).then(function() {
log.d("hooks all updated.");
// Audit log: Hook status updated
plugins.dispatch("/systemlogs", {
params: params,
action: "hook_status_updated",
data: { updatedHooksCount: Object.keys(statusList).length, requestedBy: params.member._id }
});
common.returnOutput(params, true);
});
}, paramsInstance);
Expand Down Expand Up @@ -548,6 +572,12 @@ plugins.register("/i/hook/delete", function(ob) {
function(err, result) {
log.d(err, result, "delete an hook");
if (!err) {
// Audit log: Hook deleted
plugins.dispatch("/systemlogs", {
params: params,
action: "hook_deleted",
data: { deletedHookID: hookID, requestedBy: params.member._id }
});
common.returnMessage(params, 200, "Deleted an hook");
}
}
Expand Down