Skip to content

[push] fixed migration related push payload issues #5598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[push] fixed migration related push payload issues #5598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions plugins/push/api/send/platforms/a.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,24 @@ class FCM extends Splitter {
const one = Math.ceil(bytes / pushes.length);
let content = this.template(pushes[0].m).compile(pushes[0]);

// new fcm api doesn't allow objects or arrays inside "data" property
if (content.data && typeof content.data === "object") {
for (let prop in content.data) {
switch (typeof content.data[prop]) {
case "object":
content.data[prop] = JSON.stringify(content.data[prop]);
break;
case "number":
content.data[prop] = String(content.data[prop]);
break;
}
}
}

const errors = {};
/**
* Get an error for given code & message, create it if it doesn't exist yet
*
*
* @param {number} code error code
* @param {string} message error message
* @returns {SendError} error instance
Expand All @@ -141,8 +155,7 @@ class FCM extends Splitter {
return errors[err];
};

const tokens = pushes.map(p => p.t);
const messages = tokens.map(token => ({
const messages = pushes.map(p => p.t).map((token) => ({
token,
...content,
}));
Expand Down
Loading