merge master into next #6382
Closed
merge master into next #6382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[QT-317] Changed test-id with the data-test-id and updated its value.
type improvements
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR merges the latest changes from master into the next branch.
- Replaces a static
test-idattribute with a dynamicdata-test-idbinding in the Vue template - Normalizes JSDoc
@typeannotation syntax inlocalization.jsandcommon.js
Reviewed Changes
Copilot reviewed 3 out of 20 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/express/public/javascripts/countly/vue/templates/content/content-header.html | Switches test-id to a dynamic :data-test-id and updates its value |
| api/utils/localization.js | Converts /** @type(import(...)) */ comments to /** @type {import(...)} */ |
| api/utils/common.js | Adds missing @ in @typedef tags and wraps @type imports in braces |
Comments suppressed due to low confidence (1)
frontend/express/public/javascripts/countly/vue/templates/content/content-header.html:92
- Updating from
test-idtodata-test-idmay break existing test selectors. Please update any corresponding test queries or selectors to use the newdata-test-idattribute.
:data-test-id="'journey-' + (toggleLocalValue ? 'Pause' : 'Publish').toLowerCase() + '-button'"
| toggleLocalValue ? 'el-button--warning' : 'el-button--success' | ||
| ]" | ||
| test-id="journey-publish" | ||
| :data-test-id="'journey-' + (toggleLocalValue ? 'Pause' : 'Publish').toLowerCase() + '-button'" |
There was a problem hiding this comment.
[nitpick] The inline expression for data-test-id is a bit complex. Consider moving this logic into a computed property (e.g., computedTestId) to improve readability and make future updates easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.