fix: double correction on dates #6919
Open
+9
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timestamps were being adjusted twice (once via moment.tz(timezone) and once again using utcOffset) This caused a double shift in date boundaries. Now the logic ensures only one correction is applied: - If a timezone is provided, only timezone-based conversion (moment.tz) is used. - If only an offset is provided, offset-based correction is applied This can be also observed in the formulas or retention pages in the UI. Select the date range `January 1, 2024 - January 30, 2024` and check the values in the daily bucket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timestamps were being adjusted twice (once via moment.tz(timezone) and once again using utcOffset) This caused a double shift in date boundaries.
Now the logic ensures only one correction is applied:
This can be also observed in the formulas or retention pages in the UI. Select the date range
January 1, 2024 - January 30, 2024and check the values in the daily bucket.