Refactor courses to course#1732
Open
AngelsandDevsLOL wants to merge 2 commits into
Open
Conversation
Coverage Report for CI Build 0Coverage increased (+0.04%) to 58.647%Details
Uncovered Changes
Coverage Regressions54 previously-covered lines in 3 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Building off the previous PR #1721 (which renamed the
Coursedata type toCourseDataand moved it intoModels/Course.hs), this PR renames theCoursesdatabase table toCourse. It adds a v3 migration toDatabase/Migrations.hsso the existing database table is renamed. It updates theCoursesdatatype inDatabase/Tables.hsto beCourse, as well as updating all of the accessor functions fromcoursesXtocourseX.With the
Coursename now free from the previous PR, renaming theCoursestable toCoursemakes the schema consistent with the rest of the table names and naming conventions....
Screenshots of your changes (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments