Upgrade dependencies for PHP8.2+ support and removing Security Advisories#272
Upgrade dependencies for PHP8.2+ support and removing Security Advisories#272homersimpsons wants to merge 1 commit intoCouscousPHP:masterfrom
Conversation
| $filename = $this->replaceExtension($file->relativeFilename); | ||
|
|
||
| return new HtmlFile($filename, $document->getContent(), $file); | ||
| return new HtmlFile($filename, rtrim($document->getContent(), "\n"), $file); |
There was a problem hiding this comment.
Looks like the new CommonMarkParser append a trailing \n. This creates a lot of tests failure as:
Testgets outputted as
<p>Test</p>
+| @@ -1,4 +1,4 @@ | |||
| <h1 id="custom-id">Markdown Extra heading</h1> | |||
| <h1 id="markdown-extra-heading-custom-id">Markdown Extra heading {#custom-id}</h1> | |||
There was a problem hiding this comment.
I believe that an extension is missing https://commonmark.thephpleague.com/2.x/customization/extensions/
|
|
||
| use PHPUnit\Framework\Attributes\CoversNothing; | ||
|
|
||
| #[CoversNothing] |
There was a problem hiding this comment.
Technically, the tests here invoke the bin/couscous command, so I believe that coverage won't get reported anyway.
|
|
||
| public function testFootnotes() | ||
| { | ||
| $this->markTestSkipped('TODO'); |
There was a problem hiding this comment.
I believe we are missing an extension, I will try to dig into that, but any hint would help.
|
|
||
| public function testAbbreviations() | ||
| { | ||
| $this->markTestSkipped('TODO'); |
There was a problem hiding this comment.
I believe we are missing an extension, I will try to dig into that, but any hint would help.
| "twig/twig": "^3.0", | ||
| "erusev/parsedown": "^1.7.4", | ||
| "erusev/parsedown-extra": "^0.8.1", | ||
| "phine/phar": "^1.0", |
There was a problem hiding this comment.
TODO: replace phine/phar with box-project/box2
| "mnapoli/front-yaml": "^1.5", | ||
| "php-di/php-di": "^6.0", | ||
| "psr/log": "^1.0", | ||
| "padraic/phar-updater": "^1.0" |
There was a problem hiding this comment.
padraic/phar-updater is abandoned (removed as it does not support latest php version), what should we do?
There was a problem hiding this comment.
Might be OK to just drop that 🤷
| "vimeo/psalm": "^3.16" | ||
| "phpunit/phpunit": "^11.0", | ||
| "squizlabs/php_codesniffer": "^4.0", | ||
| "vimeo/psalm": "^6.0" |
There was a problem hiding this comment.
Maybe psalm 7.0 will be released soon?
vimeo/psalm 6 requires php ~8.2.4
2 participants
Fixes #271
DRAFT: It mostly works, there are changes that can be seen as regressions
phpunit/phpunitupgraded to 11phpunit/phpunit13 requires php >= 8.4.1phpunit/phpunit12 requires php >= 8.3Run psalm:
docker run -it --rm -v "$PWD":/usr/src/myapp -w /usr/src/myapp php:8.3-cli vendor/bin/psalm