Add audio for Dialogue Message nodes #843
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naros
requested changes
Feb 11, 2025
| } | ||
|
|
||
| Variant scene_file = p_context.get_input(2); | ||
| Variant scene_file = p_context.get_input(3); |
Member
There was a problem hiding this comment.
Unfortunately, this change won't be backward compatible. You can't change the pin order or indices without there being issues. In short, this means that any older orchestrations won't connect their pins properly.
You may need to take a look at _upgrade or reallocate_pins_during_reconstruction to deal with correctly handling the upgrade for existing dialogue message nodes in older orchestrations.
Naros
force-pushed
the
add_audio_for_dialogue_nodes
branch
from
ba9e0e5 to
2ac0383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to solve #842.