Skip to content

Node Metadata Access to DialogueMessage and DialogueChoice Nodes #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ch0m5 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Node Metadata Access to DialogueMessage and DialogueChoice Nodes #853

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
322f8e8
DialogueMessage to GDScript Scene Data Expansion
Jan 16, 2025
33d93af
DialogueMessage to GDScript Scene Data Expansion
Jan 16, 2025
fd2444f
Merge branch 'add-dialogue-message-node-metadata-gdscript-access' of …
Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions src/script/nodes/dialogue/dialogue_message.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,19 @@ class OScriptNodeDialogueMessageInstance : public OScriptNodeInstance
return FileAccess::file_exists(vformat("%s.remap", p_path));
}

Dictionary _get_object_metadata(Object obj) const
{
TypedArray<String> keys = obj.get_meta_list();
Dictionary metadata;
for (int i = 0; i < keys.size(); i++)
{
StringName key = keys[i];
Variant value = obj.get_meta(key);
metadata[key] = value;
}
return metadata;
}

public:
int get_working_memory_size() const override { return 1; }

Expand Down Expand Up @@ -88,13 +101,21 @@ class OScriptNodeDialogueMessageInstance : public OScriptNodeInstance
Dictionary data;
data["character_name"] = p_context.get_input(0);
data["message"] = p_context.get_input(1);
data["metadata"] = _get_object_metadata(*this->_base);

Dictionary options;
for (int i = 0; i < _choices; i++)
{
Dictionary choice = p_context.get_input(3 + i);
if (choice.has("visible") && choice["visible"])
options[i] = choice["text"];
Dictionary choice_data;
choice_data["visible"] = choice.has("visible") && choice["visible"];
choice_data["text"] = choice["text"];

Ref<OScriptNodePin> choice_input_pin = this->_base->find_pin(4 + i, PD_Input);
Ref<OScriptNodePin> choice_output_pin = choice_input_pin->get_connections()[0];
choice_data["metadata"] = _get_object_metadata(*choice_output_pin->get_owning_node());

options[i] = choice_data;
}
data["options"] = options;

Expand Down