Skip to content

Conversation

@ashao
Copy link
Member

@ashao ashao commented Sep 10, 2025

When including scalarfield.h into an application, MetadataBuffer was never defined. Add an explicit include to the header file to ensure that applications can build.

@ashao ashao requested a review from MattToast September 10, 2025 21:24
@ashao ashao enabled auto-merge (squash) September 10, 2025 21:24
@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.62%. Comparing base (4937fbd) to head (6938651).
⚠️ Report is 21 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #530       +/-   ##
============================================
- Coverage    95.92%   57.62%   -38.31%     
============================================
  Files           10      147      +137     
  Lines          884    11908    +11024     
  Branches         0     1137     +1137     
============================================
+ Hits           848     6862     +6014     
- Misses          36     4895     +4859     
- Partials         0      151      +151     
Files with missing lines Coverage Δ
include/scalarfield.h 100.00% <ø> (ø)

... and 136 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks for the catch!

@ashao ashao merged commit 552d05b into CrayLabs:develop Sep 10, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants