/ah search <item> [player] #221
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add: /ah search <item> [player] to either search globally or from a specified player. You can also use quotes if you want to search item with spaces, for example: /ah search 'Diamond sword' Abasing or /ah search "Jack'o Lactern" Abasing Signed-off-by: Abasing <[email protected]>
What changed: Added search to the first argument completions. Added example item names when typing the second argument. Added player name suggestions when typing the third argument. This makes /ah search diamond Steve tab-completable. Signed-off-by: Abasing <[email protected]>
True to Default!
added:
permissions:
crazyauctions.search:house.
default: true
Signed-off-by: Abasing <[email protected]>
|
I believe it would be better to provide a menu for players to purchase the items they are looking for instead of informing them about the available items. |
Yeaa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ability to search items either globally or from a specified player:
Example:
Base CMD:
/ah search [player]
Usage Example:
/ah search Diamond Abasing - Searches auction listings related to "Diamond" (diamond armors, weapons, or related) from Abasing
If the player arg is not provided search will be conducted globally
Also supports quotes!
like:
/ah search 'Diamond Sword'
/ah search "Jack'o Lectern"