armorchangeevent error and dust fix #903
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Armor fix: removing an enchantment from the yml would normally make this armorchangeevent throw a massive error every 1s -- now doesn't give errors anymore
Dust fix: Magical Dust (Angel/Fixing) previously always returned early as it wrongfully compared item-data. This made you not able to apply the dust on a book. I'm assuming the official jar did not use the latest github version? Well now it is fixed
// this new and updated code will make it parse 'bookData' as the currentItem, and 'dustData' as the cursor item.
// Before, it always incorrectly compared bookData and dustData to null as both were created using the same item!
// And a single item cannot be both a book and both dust, so one is bound to be null.
// However with my commit it will compare the 2 different datacontainer items.
Please read my code comments for more info