3.0.0 Update #906
Open
3.0.0 Update #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is no player argument, it checks if the sender is a player. and if not, it returns early.
Add multiple todo()'s for the future. Added default config options to at least not brick the plugin in areas. Improved null checks. Replaced a lot of areas where null was used as a parameter for ItemStacks with ItemStack#empty() Replaced item stack null checks with ItemStack#empty() Throw an exception in BlackSmithResult if item is null or empty. Fixed a null pointer with MultiArrow enchantment Fixed another null pointer with arrow enchantments Fixed multiple null pointers with playing sounds Fixed a potential null pointer with adding a cooldown. Improved performance by moving heavy calls ahead of less intensive checks
…g unnecessary config calls. This will definitely have some improvement on performance for heavy tasks.
This stops people from asking questions about it saying you've hit a limit, and requiring them to add permissions. The default behavior should be configuration based.
Added default values for each option in ShopOption, useful when building items to prevent user error. Lifted the ShopOption cache into CrazyInstance Added config utils if we want an easy way to define default values.
This improves how things are instantiated to prevent tangled messages.
Signed-off-by: Ryder Belserion <[email protected]>
…g inventory types. This improves readability, as well as not having to perform string splitting for every click.
Signed-off-by: Ryder Belserion <[email protected]>
This will cache player heads, mob heads, and skulls from HeadDatabaseAPI in base64 format.
Signed-off-by: Ryder Belserion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.