feat(health): dependency checks in health endpoint - #158
Closed
ryzen-xp wants to merge 1 commit into
Closed
Conversation
Test output: 95.65% coverage on health.ts. Security/ops notes: Fast-fail liveness probe added at /health/live. Readiness probe at /health includes 5000ms timeout for Horizon fetch to prevent hanging. No PII or Stellar keys exposed.
|
@ryzen-xp Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends the
/healthendpoint to report dependency readiness (database ping, Horizon reachability) as requested in #101. To support fast-fail semantics alongside slower readiness checks, a new/health/liveroute has been introduced.Changes
GET /health: Now acts as a readiness probe, checking Postgres and Stellar Horizon (with a 5s timeout) before returning a200or503.GET /health/live: Added as a pure, lightweight liveness probe (instant200 ok)./health/livefor liveness checks and added comprehensive coverage for health.ts (95.65% touched coverage).Security/Ops Notes
AbortController(5000ms) to prevent infinite hanging if the testnet is unreachable.