fix(benchmark): show the v2 score in Benchmark History - #1210
Open
chriscrosstalk wants to merge 1 commit into
Open
fix(benchmark): show the v2 score in Benchmark History#1210chriscrosstalk wants to merge 1 commit into
chriscrosstalk wants to merge 1 commit into
Conversation
The history table rendered nomad_score for every row, so a v2 run showed its
legacy score while the Benchmark Details card directly above it showed the v2
one. The same run read as 65.0 in the table and 1036.1 in the card.
Rows predating v2 have no v2 score and can only show the legacy number, so the
two scales necessarily share a column. They differ by more than 10x, and
without the scale on screen a v2 run sitting above older runs reads as a
collapse rather than a rescale. Legacy rows now carry a "/ 100" suffix, which
names the scale in place and reuses the wording the details card already uses
("Legacy scale: X / 100").
This compounds the re-run guidance in the release notes: someone re-runs on
1.34 as asked, gets a real v2 score, and their own history then shows the old
number as though the machine got slower.
Frontend only. getAllResults() already returns full rows, so nomad_score_v2
was in the payload the whole time.
Verified on the NOMAD2 dev environment with a seeded history matching a real
mixed case (one v2 run at 1036.1 plus two pre-v2 runs): the v2 row shows
1036.1 with no suffix and agrees with the details card, and the legacy rows
show 71.1 / 100 and 86.5 / 100. Inertia typecheck shows the same 30
pre-existing errors as dev with none in this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1209.
The history table rendered
nomad_scoreunconditionally, so a v2 run showed its legacy score while the Benchmark Details card directly above showed the v2 one. The same run read as 65.0 in the table and 1036.1 in the card.Rows predating v2 have no v2 score and can only show the legacy number, so the two scales necessarily share a column. They differ by more than 10x, and without the scale on screen a v2 run sitting above older runs reads as a collapse rather than a rescale. Legacy rows now carry a muted
/ 100suffix, which names the scale in place and reuses the wording the details card already uses ("Legacy scale: X / 100").This compounds the re-run guidance in the release notes: someone re-runs on 1.34 as asked, gets a real v2 score, and their own history then shows the old number as though the machine got slower.
Frontend only, one file.
getAllResults()already returns full rows, sonomad_score_v2was in the payload the whole time. No API or migration change.Result
/ 100/ 100The top row now agrees with the Benchmark Details card above it.
Testing
Browser-verified on a dev environment with a seeded history matching a real mixed case: the v2 row shows
1036.1with no suffix and agrees with the details card, and the legacy rows show71.1 / 100and86.5 / 100with the suffix visually subordinate to the number.Inertia typecheck (
tsc -p inertia/tsconfig.json) reports the same 30 pre-existing errors asdev, with none in this file.