WIP: Fullcalendar 4.0.0 #123
Conversation
|
Hey @BrockReece, Any chance your able to integrate the build changes implemented in #126 into this as well? I want to use bootstrap 4 theme in fullcalendar.io but it requires version 3.9+. I could help with testing and updating the docs for version 4.0 or some examples on codesandbox. Thanks |
|
Ah good idea, thanks. |
dist/vue-full-calendar.es.js
Outdated
|
|
||
| self.$emit.apply(self, ['day-click'].concat(_toConsumableArray(args))); | ||
| }, | ||
| select: function select(start, end, jsEvent, view, resource) { |
There was a problem hiding this comment.
I can't comment on the line in the original source because it wasn't changed but instead of ordered arguments, select now receives an object argument.
Fullcalendar 4.0.0
|
Is there any timeline foreseen on this PR? We're about to start using FullCalendar v4 into our VueJS project and it would be awesome if we could (re)use this Vue wrapper instead of reinventing the wheel ourselves! Big H5YR for the work on this! |
|
@highstone I guess if we updated the fullcalendar dependency to use 4.0.0 instead of the alpha and pre-released this to NPM you could start trialing it right away? I don't really have the time at the moment though to test a lot of this out myself, sorry. |
|
@BrockReece would be glad to test it out and report back any issues if you can do that. |
|
That would be awesome! When we start implementing, we will provide you with direct feedback on it's behaviour. |
|
Hmm so it looks like they have split the fullcalendar into separate 'plugin' modules. I think it makes sense to install the following plugins by default What does everyone think? |
|
That seems reasonable to me - my gut feeling is that covers the most common use cases. |
|
@highstone @BrockReece Same here, I'm about to start an integration with fullcalendar in my Vue project. Would like to get in on this 4.0 branch! |
|
Might want to merge the bili PR. Unless others want to pull in the source code for this lib and include it into your webpack bundles, or include the node_modules/vue-fullcalendar dir. |
|
Judging by the commits, the bili branche is already merged into here. |
|
Fullcalendar just release their 4.1.0. I'll still be waiting for this repo instead of fullcalendar's own vue integration. |
| aspectRatio: 2, | ||
| timeFormat: 'HH:mm', | ||
| events: this.events, | ||
| eventSources: this.eventSources, | ||
|
|
||
| eventRender(...args) { | ||
| if (this.sync) { | ||
| self.events = cal.fullCalendar('clientEvents') | ||
| self.events = self.calendar.getEvents() |
There was a problem hiding this comment.
Just wondering if we can remove duplicates here by add lodash.uniq on
self.events = lodash.uniq(self.calendar.getEvents())
and everywhere this is required.
Reason: I see people using older version of Vue and the reactivity of an array is at stake sometimes as in those versions, Vue does not watch when a small change is made. Also removing dependency on Vue watch altogether as watch is expensive.
Thanks.
First tentative move into the brave new jQuery-less word of Fullcalendar 4.0.0 as requested in #121
From my early tests there doesn't look like there is going to be any breaking changes for users of this wrapper. But let me know if you notice anything.