Skip to content
This repository was archived by the owner on Feb 16, 2021. It is now read-only.

Fix jquery 3.5.1 support #222

Open
wants to merge 2 commits into
base: bug/fix-fullcalendar-version
Choose a base branch
from

Conversation

wmcmurray
Copy link

Fix problems encountered when using the new jQuery 3.5.1 as mentioned here : fullcalendar/fullcalendar#5348 (comment)

Copy link
Collaborator

@BrockReece BrockReece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this, maybe we should think about unfixing the versions if this has been fixed upstream?

@wmcmurray wmcmurray requested a review from BrockReece October 17, 2020 23:14
Copy link
Collaborator

@BrockReece BrockReece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for this.

I think the upstream issue that required us fixing the dependency versions temporarily has been fixed so I am not sure if this is needed anymore.

If you are still having issues with the latest version of this package, we can pick this up again.

Thanks again

@wmcmurray
Copy link
Author

@BrockReece honestly, I don't know 🤷🏻‍♂️ It was relevant on a project I worked on at the time, but I don't work there anymore lol 😄 so feel free to do whatever you want with this PR, I don't mind ! 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants