Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmerge contact #2211

Merged
merged 13 commits into from
Feb 23, 2024
Merged

Unmerge contact #2211

merged 13 commits into from
Feb 23, 2024

Conversation

gaspergrom
Copy link
Contributor

Changes proposed ✍️

What

copilot:summary

copilot:poem

Why

How

copilot:walkthrough

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Feature Created by Linear-GitHub Sync label Feb 22, 2024
@gaspergrom gaspergrom self-assigned this Feb 22, 2024
Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update/fix these:

  • As in the designs we should have an unmerge button in the identities drawer (image 1)
  • Organizations display in the modal is not correct (image 2)
  • If this is going to be merged with main, we should still use "contact" everywhere instead of "contributor". The text updates, should then be done for crowd-linux
  • "Change identity" button style is with blue color. When we merge to main, we should still keep the original styles (should be brand color)
  • After unmerging identities, I think we should GET the current member being displayed. I think some changes happen immeadiately, so it would be good to reflect them right away.
  • "Engagement level" display is not correct in modal. Should be as unknown for both (image 3)
  • I've waited for a couple of minutes but I never got the WS message with the confirmation. Were you able to test this?

Screenshot 2024-02-22 at 13 09 59

Screenshot 2024-02-22 at 13 10 56

Screenshot 2024-02-22 at 13 13 12

@gaspergrom gaspergrom merged commit 878394b into main Feb 23, 2024
10 checks passed
@gaspergrom gaspergrom deleted the feature/unmerge-contact branch February 23, 2024 12:10
gaspergrom added a commit that referenced this pull request Feb 26, 2024
Co-authored-by: anilb <[email protected]>

(cherry picked from commit 878394b)
gaspergrom added a commit that referenced this pull request Feb 27, 2024
Co-authored-by: anilb <[email protected]>

(cherry picked from commit 878394b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants