-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unmerge contact #2211
Merged
Merged
Unmerge contact #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanagmaia
requested changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update/fix these:
- As in the designs we should have an unmerge button in the identities drawer (image 1)
- Organizations display in the modal is not correct (image 2)
- If this is going to be merged with main, we should still use "contact" everywhere instead of "contributor". The text updates, should then be done for crowd-linux
- "Change identity" button style is with blue color. When we merge to main, we should still keep the original styles (should be brand color)
- After unmerging identities, I think we should GET the current member being displayed. I think some changes happen immeadiately, so it would be good to reflect them right away.
- "Engagement level" display is not correct in modal. Should be as unknown for both (image 3)
- I've waited for a couple of minutes but I never got the WS message with the confirmation. Were you able to test this?
…d.dev into feature/unmerge-contact
…d.dev into feature/unmerge-contact
joanagmaia
approved these changes
Feb 23, 2024
gaspergrom
added a commit
that referenced
this pull request
Feb 26, 2024
Co-authored-by: anilb <[email protected]> (cherry picked from commit 878394b)
gaspergrom
added a commit
that referenced
this pull request
Feb 27, 2024
Co-authored-by: anilb <[email protected]> (cherry picked from commit 878394b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
copilot:summary
copilot:poem
Why
How
copilot:walkthrough
Checklist ✅
Feature
,Improvement
, orBug
.