LF contributor unmerge #2224
LF contributor unmerge #2224
Conversation
| static async unmerge(memberId, preview) { | ||
| const tenantId = AuthCurrentTenant.get(); | ||
|
|
||
| const response = await authAxios.post( |
There was a problem hiding this comment.
Can you sync with Anil about which segments we should pass in the request?
Since we are not explicitly passing any, by default it will send all sub projects ids of the selected project group. Not sure that's what we want
There was a problem hiding this comment.
we're not using segments on merge/unmerge bcs we already know what segments a member belongs to. If a user can see the member in current segment, they should be able to unmerge it, and we deduce the unmerged members segments from its activities that were moved
It's okay to not send the segment information to these endpoints
There was a problem hiding this comment.
@epipav makes sense. If it's an extraction and we don't know the segments we will create the member in the same segments as the original one?
There was a problem hiding this comment.
yes, we sync the member to opensearch to segments that the primary member is in. We also set the member.manuallyCreated to true for secondary member
Co-authored-by: anilb <[email protected]> (cherry picked from commit 878394b)
(cherry picked from commit 0c6fd0f)
(cherry picked from commit 653404b)
(cherry picked from commit 457d286)
(cherry picked from commit 8dd2025)
(cherry picked from commit d0e3ae6)
(cherry picked from commit dc3f905)
(cherry picked from commit c50e2e4)
(cherry picked from commit 407ae3a)
gaspergrom
force-pushed
the
improvement/lf-contributor-unmerge
branch
from
7cf1eb8 to
80eddda
Compare
Changes proposed ✍️
What
copilot:summary
copilot:poem
Why
How
copilot:walkthrough
Checklist ✅
Feature,Improvement, orBug.