fix first instance context alignment and dropdown alignment

[emlimlf]

Changes proposed ✍️

What

Fix button alignment for the work history item. Align the first instance of the context menu button to be aligned with the organization name. Also fixed the issue with the dropdown appearing a bit far from the button.

Why

UI bug fixes

Ticket

CM-1963

Checklist ✅

• Label appropriately with Feature, Improvement, or Bug.
• Add screenshots to the PR description for relevant FE changes
• New backend functionality has been unit-tested.
• API documentation has been updated (if necessary) (see docs on API documentation).
• Quality standards are met.

Summary by CodeRabbit

• New Features

  • Enhanced work history timeline component with index tracking
  • Added conditional styling for first work history item
  • Improved dropdown positioning and styling for work history items

• Refactor

  • Updated component props to support more dynamic rendering

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request introduces changes to the work history components in a Vue.js application. The modifications involve adding an index prop to the work history item component, enabling more precise rendering and styling of timeline items. The changes allow for conditional styling of the first item in the work history list, with specific adjustments to the dropdown positioning and appearance.

Changes

File	Change Summary
frontend/src/modules/contributor/components/details/contributor-details-work-history.vue	Added :index="index" prop when rendering timeline items
frontend/src/modules/contributor/components/details/work-history/contributor-details-work-history-item.vue	- Added index: number to props - Introduced conditional first-item class - Added relative class to div - Added work-history-item-dropdown class to dropdown - Created scoped style for first-item dropdown margin

Possibly related PRs

• Feature/lfx 1843 work history #2716: Modifications to contributor work history components with similar rendering enhancements
• Bugfix/lfx 1960 work history glitch #2764: UI improvements to work history timeline item component

Suggested labels

bug

Suggested reviewers

• joanagmaia
• gaspergrom

Poem

🐰 A rabbit's tale of code so neat,
Work history items now look so sweet
With index in hand and styles just right
Our timeline dances with pure delight!
Hop, hop, hooray for Vue's clever might! 🎉

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

frontend/src/modules/contributor/components/details/work-history/contributor-details-work-history-item.vue (2)

3-3: LGTM! Consider using template literal syntax enhancement.

The positioning changes look good and properly address the alignment issues. The relative positioning and specific dropdown class provide the necessary styling hooks.

Consider simplifying the class binding syntax:

-:class="`${props.index === 0 ? 'first-item' : ''}`"
+:class="{ 'first-item': props.index === 0 }"

Also applies to: 7-7, 21-21

---

137-141: Consider using CSS custom properties for magic numbers.

While the margin adjustment fixes the alignment, using a magic number (-28px) could make future maintenance challenging.

Consider using a CSS custom property:

+<style>
+:root {
+  --work-history-dropdown-offset: -28px;
+}
+</style>
+
 <style scoped>
 .first-item .work-history-item-dropdown {
-  margin-top: -28px;
+  margin-top: var(--work-history-dropdown-offset);
 }
 </style>

This makes the offset value more maintainable and allows for easy adjustments if needed.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0341e55 and 348a840.

📒 Files selected for processing (2)

• frontend/src/modules/contributor/components/details/contributor-details-work-history.vue (1 hunks)
• frontend/src/modules/contributor/components/details/work-history/contributor-details-work-history-item.vue (4 hunks)

🔇 Additional comments (2)

frontend/src/modules/contributor/components/details/work-history/contributor-details-work-history-item.vue (1)

77-77: LGTM! Props type is correctly defined.

The index prop addition is well-typed and necessary for the first-item styling logic.

frontend/src/modules/contributor/components/details/contributor-details-work-history.vue (1)

35-35: LGTM! Index is correctly passed to child component.

The integration of the index prop with the v-for directive is well implemented, enabling the first-item styling in the child component.

Also applies to: 40-40