Replace networkidle with domcontentloaded in e2e page object#355
Open
mraible wants to merge 1 commit into
Open
Replace networkidle with domcontentloaded in e2e page object#355mraible wants to merge 1 commit into
mraible wants to merge 1 commit into
Conversation
The Falcon console never reaches networkidle due to persistent background
telemetry and websocket traffic. Tests hung on waitForLoadState('networkidle')
even though the app UI was fully rendered and interactive. This matches the
pattern used by @crowdstrike/foundry-playwright which uses domcontentloaded
exclusively.
mraible
force-pushed
the
fix/replace-networkidle-with-domcontentloaded
branch
from
a954757 to
d392e9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Falcon console never reaches
networkidledue to persistent background telemetry and websocket traffic. E2E tests hung onwaitForLoadState('networkidle')even though the app UI was fully rendered and interactive, causing 6 of 9 tests to time out at 60s consistently.This replaces all 13 occurrences of
waitForLoadState('networkidle')withwaitForLoadState('domcontentloaded')inRapidResponseHomePage.ts, matching the pattern used by@crowdstrike/foundry-playwrightwhich usesdomcontentloadedexclusively across all its page objects.Verified locally: all 10 tests pass in under 60s (previously 6 failed on every run).