fix(go): Fix execute command request payload placement#81
Open
romann-cs wants to merge 1 commit into
Open
Conversation
mraible
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Config(DomainConfigData) instead ofRequest(DomainRequest). TheConfigfield is for authentication data, whileRequestcarries the actual operation bodysent to ServiceNow.
TestExecuteCommandPayloadJSONwhich validates the full JSON wire format of the execute command request, preventing this class of regression if the SDK struct changes again.Context
The gofalcon v0.20.0 upgrade (commit 3fab32a) incorrectly moved the request payload from
RequesttoConfigdue to a struct rename in the regenerated SDK (gofalcon). Both fields accept a JSON interface, so it compiled andexisting tests passed, but the payload was being sent in the wrong field at the API level.
Test plan
Verified the new test catches the bug by temporarily reverting to the broken code