fix(ci): enforce commitlint instead of continue-on-error - #1384
Merged
afurious merged 1 commit intoAug 24, 2026
Conversation
Collaborator
|
fix your failed ci checks |
MusaTheDev001
force-pushed
the
fix/enforce-commitlint
branch
from
August 22, 2026 17:51
4636111 to
6a17005
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Title: fix(ci): enforce commitlint instead of continue-on-error
Summary
CONTRIBUTING.mdsays commit messages must follow conventional commits,.commitlintrc.jsonencodes that, andrust_ci.ymlrunscommitlinton every PR - but the step carriedcontinue-on-error: true, so a failing lint still reported green. The convention was documented, tooled, and checked, yet never binding. 25 of the last 100 non-merge commits fail the config.Changes
github/workflows/rust_ci.yml: moved commit linting out of thecheckjob into its owncommitlintjob (Lint commit messages) and dropped continue-on-error. Guarded with if: github.event_name == 'pull_request' so pushes to main/develop, which replay already-merged history, can't fail on commits nobody can rewrite. A separate job also keeps a bad subject line from hiding Rust build/test results.CONTRIBUTING.md: type list now matches the config (added style, refactor, perf, revert); documented the two undocumented rules (no all-caps subject, header ≤ 100 chars); stated that only PR commits are linted, older history is exempt, and merge commits are ignored; added the local self-check command.Closes
Closes #1382