fix(ci): exempt severity: critical/high issues from stale auto-close - #1390
Merged
afurious merged 1 commit intoAug 24, 2026
Merged
Conversation
The stale-bot's exempt-issue-labels/exempt-pr-labels lists don't include this repo's severity: critical/severity: high audit labels, so genuine fund-drain and correctness findings can be silently auto-closed by the generic inactivity message with no fix ever merged (as already happened to issues Crowdfunding-DApp#1351, Crowdfunding-DApp#1312, Crowdfunding-DApp#1320, Crowdfunding-DApp#1321). Closes Crowdfunding-DApp#1380 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/staleworkflow'sexempt-issue-labels/exempt-pr-labelslists (pinned,security,in-progress,blocked) don't include this repo's audit severity labels (severity: critical,severity: high), so genuine fund-drain and correctness/availability findings can be silently auto-closed after 30+7 days of inactivity.access_control.rsreferencesDataKeyvariants that don't exist and can't compile if wired in #1351, [Audit #40]stellar_token_minter.rsis a completely empty file #1312, [Audit #48] Factory's hardcodedsalt = [0; 32]limits each creator to exactly one campaign ever #1320, and [Audit #49] Factory offers no way to passmin_contribution,platform_config, or bonus-goal parameters #1321 were auto-closed by the stale bot's generic message with no PR ever merged to fix the underlying defects, which are still present in the code today.severity: criticalandseverity: highto both label-exemption lists in.github/workflows/stale.yml. Surgical config-only change — no code paths touched, and no previously-closed issues are reopened by this PR.Test plan
python3 -c "import yaml; yaml.safe_load(open('.github/workflows/stale.yml'))"actionlintnot available in this environment; diff manually inspected for the exact label strings expected byactions/stale@v9cargo test --workspaceunaffected by this change (no Rust paths touched)Closes #1380