feat: update on issue 1378 - #1391
Merged
afurious merged 1 commit intoAug 29, 2026
Merged
Conversation
afurious
added a commit
that referenced
this pull request
Sep 3, 2026
The check job of Rust CI fails at the formatting step on an unformatted assert_eq! in the factory tests (merged via #1391), and would fail the next step on a clippy::useless_conversion in the crowdfund tests (merged via #1392) where std::string::String::from wraps an already-owned String. - factory: reflow assert_eq! per rustfmt - crowdfund: drop the redundant String::from around "a".repeat(n)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1378
Description
Related Issues
Closes #
Type of Change
Required CI Checks
The following status checks must pass before this PR can be merged:
Frontend CI (
frontend_ci.yml—ci-frontendjob):pnpm --filter @stellar-raise/frontend typecheck)pnpm --filter @stellar-raise/frontend test)pnpm lint)pnpm format:check)Rust CI (
rust_ci.yml—checkjob):cargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningscargo build --release --target wasm32-unknown-unknowncargo test --workspaceChecklist
develop, notmaincargo fmt --alland the code is properly formattedcargo clippy --all-targets -- -D warningswith no warningscargo testand all tests passpnpm typecheckwith no type errorspnpm testand all frontend tests passpnpm lintwith no ESLint errorspnpm format:checkwith no formatting violations///doc commentsCHANGELOG.mdif applicableScreenshots / Logs (if applicable)
Additional Notes