Skip to content

GT-2594 Setup a new compose renderer module #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: feature/compose
Choose a base branch
from

Conversation

frett
Copy link
Contributor

@frett frett commented May 2, 2025

No description provided.

Copy link

github-actions bot commented May 2, 2025

Typescript headers

  • kotlin-mpp-godtools-tool-parser-publishing-npm.d.ts
Diff

kotlin-mpp-godtools-tool-parser-publishing-npm.d.ts

--- a/home/runner/work/kotlin-mpp-godtools-tool-parser/kotlin-mpp-godtools-tool-parser/diff/base/kotlin-mpp-godtools-tool-parser-publishing-npm.d.ts
+++ b/home/runner/work/kotlin-mpp-godtools-tool-parser/kotlin-mpp-godtools-tool-parser/diff/head/kotlin-mpp-godtools-tool-parser-publishing-npm.d.ts
@@ -219,6 +219,7 @@ export declare namespace org.cru.godtools.shared.tool.parser.model {
         get iconGravity(): org.cru.godtools.shared.tool.parser.model.Gravity.Horizontal;
         get iconSize(): number;
         get text(): org.cru.godtools.shared.tool.parser.model.Text;
+        static createTestButton(parent?: any/* org.cru.godtools.shared.tool.parser.model.Base */, style?: Nullable<org.cru.godtools.shared.tool.parser.model.Button.Style>, color?: Nullable<any>/* Nullable<com.github.ajalt.colormath.Color> */, gravity?: org.cru.godtools.shared.tool.parser.model.Gravity.Horizontal, width?: org.cru.godtools.shared.tool.parser.model.Dimension, iconGravity?: org.cru.godtools.shared.tool.parser.model.Gravity.Horizontal, iconSize?: number, analyticsEvents?: kotlin.collections.KtList<org.cru.godtools.shared.tool.parser.model.AnalyticsEvent>, events?: kotlin.collections.KtList<org.cru.godtools.shared.tool.parser.model.EventId>, url?: Nullable<string>, text?: Nullable<(p0: any/* org.cru.godtools.shared.tool.parser.model.Base */) => Nullable<org.cru.godtools.shared.tool.parser.model.Text>>): org.cru.godtools.shared.tool.parser.model.Button;
         get buttonColor(): string;
         get backgroundColor(): string;
         isInvisible(state: org.cru.godtools.shared.tool.state.State): boolean;

GitHub Actions

Copy link

github-actions bot commented May 2, 2025

iOS Framework headers

  • GodToolsToolParser.h
Diff

GodToolsToolParser.h

--- a/Users/runner/work/kotlin-mpp-godtools-tool-parser/kotlin-mpp-godtools-tool-parser/diff/base/GodToolsToolParser.h
+++ b/Users/runner/work/kotlin-mpp-godtools-tool-parser/kotlin-mpp-godtools-tool-parser/diff/head/GodToolsToolParser.h
@@ -6,7 +6,7 @@
 #import <Foundation/NSString.h>
 #import <Foundation/NSValue.h>
 
-@class GTTPAccordionSection, GTTPAnalyticsActionNames, GTTPAnalyticsAppSectionNames, GTTPAnalyticsEvent, GTTPAnalyticsEventSystem, GTTPAnalyticsEventTrigger, GTTPAnalyticsScreenNames, GTTPAnalyticsUserProperties, GTTPAspectRatio, GTTPBadge, GTTPBadgeBadgeType, GTTPBaseModel, GTTPButton, GTTPButtonStyle, GTTPCallToAction, GTTPCardCollectionPage, GTTPCardCollectionPageCard, GTTPCardCollectionPageHeader, GTTPCategory, GTTPColormathAnsi16, GTTPColormathAnsi16Companion, GTTPColormathAnsi256, GTTPColormathAnsi256Companion, GTTPColormathCMYK, GTTPColormathCMYKCompanion, GTTPColormathColorComponentInfo, GTTPColormathHPLuv, GTTPColormathHPLuvCompanion, GTTPColormathHSL, GTTPColormathHSLCompanion, GTTPColormathHSLuv, GTTPColormathHSLuvCompanion, GTTPColormathHSV, GTTPColormathHSVCompanion, GTTPColormathHWB, GTTPColormathHWBCompanion, GTTPColormathICtCp, GTTPColormathICtCpCompanion, GTTPColormathJzAzBz, GTTPColormathJzAzBzCompanion, GTTPColormathJzCzHz, GTTPColormathJzCzHzCompanion, GTTPColormathLAB, GTTPColormathLABCompanion, GTTPColormathLCHab, GTTPColormathLCHabCompanion, GTTPColormathLCHuv, GTTPColormathLCHuvCompanion, GTTPColormathLUV, GTTPColormathLUVCompanion, GTTPColormathOklab, GTTPColormathOklabCompanion, GTTPColormathOklch, GTTPColormathOklchCompanion, GTTPColormathRGB, GTTPColormathRGBCompanion, GTTPColormathRenderCondition, GTTPColormathWhitePoint, GTTPColormathXYZ, GTTPColormathXYZCompanion, GTTPColormathxyY, GTTPCommonThemeType, GTTPContent, GTTPDeviceType, GTTPDimension, GTTPEventId, GTTPEventIdCompanion, GTTPFlow, GTTPFlowItem, GTTPFlowItemCompanion, GTTPFlowWatcher, GTTPGravity, GTTPGravityCompanion, GTTPGravityHorizontal, GTTPGravityVertical, GTTPHeader, GTTPHero, GTTPIconColors, GTTPImageScaleType, GTTPInputError, GTTPInputErrorInvalidEmail, GTTPInputErrorRequired, GTTPInputType, GTTPKotlinArray<T>, GTTPKotlinEnum<E>, GTTPKotlinEnumCompanion, GTTPKotlinException, GTTPKotlinFloatArray, GTTPKotlinFloatIterator, GTTPKotlinIllegalStateException, GTTPKotlinRuntimeException, GTTPKotlinThrowable, GTTPLessonPage, GTTPLogLevel, GTTPManifest, GTTPManifestParser, GTTPManifestType, GTTPManifestXmlFile, GTTPModal, GTTPMultiselect, GTTPMultiselectOption, GTTPMultiselectOptionStyle, GTTPPage, GTTPPageCollectionPageCompanion, GTTPParagraph, GTTPParserConfig, GTTPParserConfigCompanion, GTTPParserResult, GTTPParserResultError, GTTPParser_expressionsExpression, GTTPResource, GTTPSaxXmlPullParser, GTTPSaxXmlPullParserQName, GTTPShareable, GTTPSpacerMode, GTTPState, GTTPStylesCompanion, GTTPTabsTab, GTTPText, GTTPTextAlign, GTTPTextStyle, GTTPTip, GTTPTipPage, GTTPTipType, GTTPToolAnalyticsActionNames, GTTPToolAnalyticsScreenNames, GTTPTractPage, GTTPTractPageCard, GTTPTutorialAnalyticsActionNames, GTTPTutorialAnalyticsAppSectionNames, GTTPUserActivity, GTTPUserActivityColors, GTTPUserCounterNames, GTTPVideoProvider, GTTPXmlPullParserFactory, NSData, NSLocale, NSURL, NSXMLParser, UIColor;
+@class GTTPAccordionSection, GTTPAnalyticsActionNames, GTTPAnalyticsAppSectionNames, GTTPAnalyticsEvent, GTTPAnalyticsEventSystem, GTTPAnalyticsEventTrigger, GTTPAnalyticsScreenNames, GTTPAnalyticsUserProperties, GTTPAspectRatio, GTTPBadge, GTTPBadgeBadgeType, GTTPBaseModel, GTTPButton, GTTPButtonStyle, GTTPCallToAction, GTTPCardCollectionPage, GTTPCardCollectionPageCard, GTTPCardCollectionPageHeader, GTTPCategory, GTTPColormathAnsi16, GTTPColormathAnsi16Companion, GTTPColormathAnsi256, GTTPColormathAnsi256Companion, GTTPColormathCMYK, GTTPColormathCMYKCompanion, GTTPColormathColorComponentInfo, GTTPColormathHPLuv, GTTPColormathHPLuvCompanion, GTTPColormathHSL, GTTPColormathHSLCompanion, GTTPColormathHSLuv, GTTPColormathHSLuvCompanion, GTTPColormathHSV, GTTPColormathHSVCompanion, GTTPColormathHWB, GTTPColormathHWBCompanion, GTTPColormathICtCp, GTTPColormathICtCpCompanion, GTTPColormathJzAzBz, GTTPColormathJzAzBzCompanion, GTTPColormathJzCzHz, GTTPColormathJzCzHzCompanion, GTTPColormathLAB, GTTPColormathLABCompanion, GTTPColormathLCHab, GTTPColormathLCHabCompanion, GTTPColormathLCHuv, GTTPColormathLCHuvCompanion, GTTPColormathLUV, GTTPColormathLUVCompanion, GTTPColormathOklab, GTTPColormathOklabCompanion, GTTPColormathOklch, GTTPColormathOklchCompanion, GTTPColormathRGB, GTTPColormathRGBCompanion, GTTPColormathRenderCondition, GTTPColormathWhitePoint, GTTPColormathXYZ, GTTPColormathXYZCompanion, GTTPColormathxyY, GTTPCommonThemeType, GTTPContent, GTTPDeviceType, GTTPDimension, GTTPEventId, GTTPEventIdCompanion, GTTPFlow, GTTPFlowItem, GTTPFlowItemCompanion, GTTPFlowWatcher, GTTPGravity, GTTPGravityCompanion, GTTPGravityHorizontal, GTTPGravityVertical, GTTPHeader, GTTPHero, GTTPIconColors, GTTPImageScaleType, GTTPInputError, GTTPInputErrorInvalidEmail, GTTPInputErrorRequired, GTTPInputType, GTTPKotlinArray<T>, GTTPKotlinEnum<E>, GTTPKotlinEnumCompanion, GTTPKotlinException, GTTPKotlinFloatArray, GTTPKotlinFloatIterator, GTTPKotlinIllegalStateException, GTTPKotlinRuntimeException, GTTPKotlinThrowable, GTTPLessonPage, GTTPLogLevel, GTTPManifest, GTTPManifestParser, GTTPManifestType, GTTPManifestXmlFile, GTTPModal, GTTPMultiselect, GTTPMultiselectOption, GTTPMultiselectOptionStyle, GTTPPage, GTTPPageCollectionPageCompanion, GTTPParagraph, GTTPParserConfig, GTTPParserConfigCompanion, GTTPParserResult, GTTPParserResultError, GTTPParser_expressionsExpression, GTTPResource, GTTPSaxXmlPullParser, GTTPSaxXmlPullParserQName, GTTPShareable, GTTPSpacerMode, GTTPState, GTTPStylesCompanion, GTTPTabsTab, GTTPText, GTTPTextAlign, GTTPTextStyle, GTTPTip, GTTPTipPage, GTTPTipType, GTTPToolAnalyticsActionNames, GTTPToolAnalyticsScreenNames, GTTPTractPage, GTTPTractPageCard, GTTPTutorialAnalyticsActionNames, GTTPTutorialAnalyticsAppSectionNames, GTTPUserActivity, GTTPUserActivityColors, GTTPUserCounterNames, GTTPVideoProvider, GTTPXmlPullParserFactory, NSData, NSLocale, NSURL, NSXMLParser, UIColor, UIViewController;
 
 @protocol GTTPBase, GTTPClickable, GTTPColormathColor, GTTPColormathColorSpace, GTTPColormathHueColor, GTTPColormathLABColorSpace, GTTPColormathLCHabColorSpace, GTTPColormathLCHuvColorSpace, GTTPColormathLUVColorSpace, GTTPColormathRGBColorSpace, GTTPColormathRGBColorSpaceTransferFunctions, GTTPColormathWhitePointColorSpace, GTTPColormathXYZColorSpace, GTTPHasAnalyticsEvents, GTTPHasPages, GTTPKotlinComparable, GTTPKotlinIterator, GTTPKotlinx_coroutines_coreFlow, GTTPKotlinx_coroutines_coreFlowCollector, GTTPParcelable, GTTPParent, GTTPStyles, GTTPVisibility;
 
@@ -540,6 +540,12 @@ __attribute__((swift_name("AspectRatio")))
 __attribute__((objc_subclassing_restricted))
 __attribute__((swift_name("Button")))
 @interface GTTPButton : GTTPContent <GTTPHasAnalyticsEvents, GTTPClickable>
+
+/**
+ * @note annotations
+ *   androidx.annotation.RestrictTo(value=[Scope.TESTS])
+*/
+- (instancetype)initWithParent:(id<GTTPBase>)parent style:(GTTPButtonStyle * _Nullable)style color:(id<GTTPColormathColor> _Nullable)color gravity:(GTTPGravityHorizontal *)gravity width:(GTTPDimension *)width iconGravity:(GTTPGravityHorizontal *)iconGravity iconSize:(int32_t)iconSize analyticsEvents:(NSArray<GTTPAnalyticsEvent *> *)analyticsEvents events:(NSArray<GTTPEventId *> *)events url:(NSURL * _Nullable)url text:(GTTPText * _Nullable (^ _Nullable)(id<GTTPBase>))text __attribute__((swift_name("init(parent:style:color:gravity:width:iconGravity:iconSize:analyticsEvents:events:url:text:)"))) __attribute__((objc_designated_initializer));
 - (NSArray<GTTPAnalyticsEvent *> *)getAnalyticsEventsType:(GTTPAnalyticsEventTrigger *)type __attribute__((swift_name("getAnalyticsEvents(type:)")));
 @property (readonly) id<GTTPColormathColor> backgroundColor __attribute__((swift_name("backgroundColor")));
 @property (readonly) id<GTTPColormathColor> buttonColor __attribute__((swift_name("buttonColor")));
@@ -1625,6 +1631,12 @@ __attribute__((swift_name("ColorKt")))
 + (UIColor *)toUIColor:(id<GTTPColormathColor>)receiver __attribute__((swift_private));
 @end
 
+__attribute__((objc_subclassing_restricted))
+__attribute__((swift_name("ContentStackViewKt")))
+@interface GTTPContentStackViewKt : GTTPBase
++ (UIViewController *)ContentStackViewContent:(NSArray<GTTPContent *> *)content __attribute__((swift_name("ContentStackView(content:)")));
+@end
+
 __attribute__((objc_subclassing_restricted))
 __attribute__((swift_name("LoggingKt")))
 @interface GTTPLoggingKt : GTTPBase

GitHub Actions

Copy link

codecov bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 83.84%. Comparing base (c47adcc) to head (6deb29f).

Files with missing lines Patch % Lines
.../godtools/shared/renderer/content/RenderContent.kt 40.00% 4 Missing and 2 partials ⚠️
...u/godtools/shared/renderer/content/RenderButton.kt 75.00% 0 Missing and 4 partials ⚠️
...odtools/shared/renderer/content/RenderParagraph.kt 0.00% 4 Missing ⚠️
...ools/shared/renderer/content/RenderContentStack.kt 66.66% 0 Missing and 1 partial ⚠️
...cru/godtools/shared/renderer/content/RenderText.kt 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           feature/compose     #795      +/-   ##
===================================================
- Coverage            85.74%   83.84%   -1.91%     
===================================================
  Files                   93       99       +6     
  Lines                 2308     2389      +81     
  Branches               558      586      +28     
===================================================
+ Hits                  1979     2003      +24     
- Misses                 112      161      +49     
- Partials               217      225       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@frett frett force-pushed the setupComposeBuild branch 4 times, most recently from f20ac30 to 52556b7 Compare May 5, 2025 16:56
@frett frett force-pushed the setupComposeBuild branch from 52556b7 to 490e857 Compare May 14, 2025 17:37
@frett frett force-pushed the feature/compose branch from 8ca8a99 to 6217c80 Compare May 14, 2025 18:34
@frett frett force-pushed the setupComposeBuild branch from 490e857 to a49db2e Compare May 14, 2025 18:37
@frett frett force-pushed the setupComposeBuild branch from ccee079 to c43ccc0 Compare May 14, 2025 20:17
@frett frett force-pushed the setupComposeBuild branch 3 times, most recently from d39920d to 328918d Compare May 14, 2025 21:21
@frett frett force-pushed the feature/compose branch from 70aebd2 to c47adcc Compare May 16, 2025 19:26
@frett frett force-pushed the setupComposeBuild branch 2 times, most recently from 18f3948 to a644f12 Compare May 16, 2025 19:40
@frett frett force-pushed the setupComposeBuild branch from a644f12 to 96d4ac1 Compare May 16, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant