MPDX-8449 - deleteAppealContact mutation FE fixes

[wjames111]

Description

Currently, on the deleteAppealContact mutation, we have to pass in the Appeal's Contact's ID, which is a join table id. Could we change this, so we just have to pass in the contact's ID and the appeal ID?

Currently, we have to loop through all the appeal contacts to find the appeal contact which is associated with the contact the user wants to delete.

This is causing some issues. We can fix those issues, but we think it's best that the FE just sends the contact ID and appeal ID, and the server tracks down the correct Appeal Contact.

Related task:

Helpscout ticket:

Jira Ticket here

Checklist:

• I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
• I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
• I have requested a review from another person on the project

[github-actions]

Bundle sizes [mpdx-react]

Compared against 43fe02b

No significant changes found

[github-actions]

Preview branch generated at https://MPDX-8449-delete-appeal-contact.d3dytjb8adxkk5.amplifyapp.com

[wjames111]

Not exactly sure why typescript check is failing or why test chunk is failing. All the tests passed locally.

[dr-bizz]

@wjames111 TypeScript is failing as the code hasn't been pushed to the API production. These tests hit the production API. This explains how those 2 tests are failing.

Also, I added code, as I need to code. Been looking at emails and in meetings for too long

[dr-bizz]

Amazing work on this! Both failing tests are due to the API code is not in production.

The functionality works so well, and this really improves performance.

Thank you for taking this off my plate.

You will need to connect with the backend team to plan for when you both merge the PRs into production. I recommend Monday next week.

[wjames111]

Sound good, I'll do that. Thanks @dr-bizz !