MPDX-8388 - Suggested task tags show up in tags autocomplete #1315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjames111
changed the title
Contributor
Bundle sizes [mpdx-react]Compared against f18df0d No significant changes found |
wjames111
added
On Staging
Contributor
|
Preview branch generated at https://MPDX-8388-suggested-tags-autocomplete.d3dytjb8adxkk5.amplifyapp.com |
Contributor
Author
|
Although maybe it would be better if additional tags had all phase tags filtered out. That way there's no overlap between the two. |
Contributor
|
Is this ready for review? |
Contributor
Author
|
@dr-bizz I was going to wait to mark it as ready for review as I didn't want to flood you guys with PR review requests, but it's ready whenever you guys have time. |
dr-bizz
approved these changes
May 21, 2025
Contributor
dr-bizz
left a comment
dr-bizz
left a comment
There was a problem hiding this comment.
This is looking great! Awesome job on this.
| await waitFor(() => | ||
| expect(queryByRole('option', { name: 'tag-1' })).not.toBeInTheDocument(), | ||
| ); | ||
| }, 10000); |
Contributor
There was a problem hiding this comment.
Do you need to have this time limit?
Contributor
Author
There was a problem hiding this comment.
Looks like it is not needed. It's been removed.
wjames111
force-pushed
the
MPDX-8388-suggested-tags-autocomplete
branch
from
0d34027 to
cb150ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suggested tags seem to save on the server as lowercase. That means that when I edit a task with suggested tags, the suggested tags are correctly highlighted, but they also show up in the "Additional Tags" dropdown.
Jira ticket available here
Things to Note
So I think the easiest solution to this problem would be to filter out the selected task tags from autocomplete. However this still felt a little awkward. In addition to this I wanted to make the suggested tags and additional tags a little more in sync with each other so when one is selected it's reflected in the other, and the same with removing. The only caveat is when a suggested tag is selected I did not want it to create an entry in additional tags, so they aren't entirely in sync with each other, but more so then before.
Checklist: