Skip to content

Conversation

@wjames111
Copy link
Contributor

@wjames111 wjames111 commented Sep 12, 2025

Description

  • Removes gap between header and right panel when SectionList gets too long by making SectionList scrollable.
  • Adds ScrollTo functionality on the main panel, allowing users to click on a specific section in the left sidebar and have the main panel scroll to it.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@wjames111 wjames111 changed the base branch from main to MPDX-8766-primary-budget-category-mutations September 12, 2025 18:14
@wjames111 wjames111 changed the base branch from MPDX-8766-primary-budget-category-mutations to MPDX-8825-subcategory-right-panels September 12, 2025 18:14
@wjames111 wjames111 self-assigned this Sep 12, 2025
@wjames111 wjames111 added Preview Environment Add this label to create an Amplify Preview On Staging Will be merged to the staging branch by Github Actions labels Sep 12, 2025
@github-actions
Copy link
Contributor

Preview branch generated at https://MPDX-goal-calculator-scroll.d3dytjb8adxkk5.amplifyapp.com

@wjames111 wjames111 force-pushed the MPDX-goal-calculator-scroll branch from 7b55a19 to 6d02173 Compare September 12, 2025 18:26
@wjames111 wjames111 force-pushed the MPDX-8825-subcategory-right-panels branch from f0d9fa1 to 477076f Compare September 12, 2025 18:43
Base automatically changed from MPDX-8825-subcategory-right-panels to MPDX-8766-primary-budget-category-mutations September 12, 2025 18:43
@zweatshirt
Copy link
Contributor

@wjames111 There seems to be a decent bit of overlap between this PR and the one I'm working on currently: #1438
I'll probably wait for you to finish this to continue

@wjames111
Copy link
Contributor Author

@zweatshirt if you've already done work on this, we can go with yours.

@zweatshirt
Copy link
Contributor

@wjames111

@zweatshirt if you've already done work on this, we can go with yours.

Oh no you're all good! The PR I linked is for making the GoalCalculatorLayout a shared component. There are no improvements apart from breaking it out into a more reusable component. I would be happy to add these changes to the shared component when you're done and it shouldn't take long for me to do. I just wanted to let you know about the PR.

@wjames111 wjames111 force-pushed the MPDX-8766-primary-budget-category-mutations branch from 951bb77 to 9a041c7 Compare September 17, 2025 16:27
@wjames111 wjames111 force-pushed the MPDX-8766-primary-budget-category-mutations branch 2 times, most recently from 173c9b6 to 9e31071 Compare September 17, 2025 19:50
Base automatically changed from MPDX-8766-primary-budget-category-mutations to main September 17, 2025 20:06
@zweatshirt
Copy link
Contributor

@wjames111 Do you know if you'll continue working on this? If not, I'll finish up #1438

@wjames111
Copy link
Contributor Author

@zweatshirt go for it that would be super helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants