-
Notifications
You must be signed in to change notification settings - Fork 1
MPDX goal calculator scroll #1437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…in GoalCalculatorGrid.
|
Preview branch generated at https://MPDX-goal-calculator-scroll.d3dytjb8adxkk5.amplifyapp.com |
7b55a19 to
6d02173
Compare
f0d9fa1 to
477076f
Compare
|
@wjames111 There seems to be a decent bit of overlap between this PR and the one I'm working on currently: #1438 |
|
@zweatshirt if you've already done work on this, we can go with yours. |
Oh no you're all good! The PR I linked is for making the GoalCalculatorLayout a shared component. There are no improvements apart from breaking it out into a more reusable component. I would be happy to add these changes to the shared component when you're done and it shouldn't take long for me to do. I just wanted to let you know about the PR. |
951bb77 to
9a041c7
Compare
173c9b6 to
9e31071
Compare
|
@wjames111 Do you know if you'll continue working on this? If not, I'll finish up #1438 |
|
@zweatshirt go for it that would be super helpful. |
Description
SectionListgets too long by makingSectionListscrollable.Checklist: