Skip to content

Conversation

@canac
Copy link
Contributor

@canac canac commented Dec 18, 2025

Description

Show minimum required and requested salary in the UI. The minimum required salary is amount required by the IRS. The minimum requested salary is the minimum that the user must request to hit that limit.

Important note: the minimum calculations are currently broken on the API side because the taxable income returns nil.

Depends on https://github.com/CruGlobal/mpdx_api/pull/3101 (merged 🚀)

MPDX-9107

Testing

  • Go to /accountLists/_/reports/salaryCalculator
  • Go to the Requested Salary step and scroll to the "Requested Salary" step
  • Check that the required minimum shows up in the help text (MHA + $min - SECA) ⚠️ currently not working until the API is fixed
  • Check that the Salary Minimum amount shows up (requested minimum) ⚠️ currently not working until the API is fixed

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
  • I have run the Claude Code /pr-review command locally and fixed any relevant suggestions
  • I have requested a review from another person on the project
  • I have tested my changes in preview or in staging
  • I have cleaned up my commit history

@canac canac requested a review from wjames111 December 18, 2025 19:35
@canac canac self-assigned this Dec 18, 2025
@canac canac added Preview Environment Add this label to create an Amplify Preview Staging API Run GraphQL codegen against the staging API labels Dec 18, 2025
@github-actions
Copy link
Contributor

Preview branch generated at https://9107-min-salary.d3dytjb8adxkk5.amplifyapp.com

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

Bundle sizes [mpdx-react]

Compared against 92a3ae1

No significant changes found

Base automatically changed from 9108-max-salary to main December 18, 2025 21:12
@canac canac removed the Staging API Run GraphQL codegen against the staging API label Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Preview Environment Add this label to create an Amplify Preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants